From patchwork Wed Apr 5 16:56:03 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthias Kaehlcke X-Patchwork-Id: 9664739 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id A069E60353 for ; Wed, 5 Apr 2017 16:57:01 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8673E26BE9 for ; Wed, 5 Apr 2017 16:57:01 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7ACB9281AA; Wed, 5 Apr 2017 16:57:01 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.4 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_SORBS_SPAM autolearn=no version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 3DE7E27F54 for ; Wed, 5 Apr 2017 16:57:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=ii824KvUeIuTdkJ35CxAQkPjaDl6lL237q/AK9OFg0Y=; b=WTg AXQtsAHXni17tPXSuP1nyf18f7y+blvF/itIG/N0+eEmIYArRq0+HlNySu51zJKuufGUX0F5KBZE4 2jd3ibLF6o2EgH3UQB7iuI3ZZM8CwrxhY3y5lNxsxnLP6xQaJ/rlQnZE7eFKAZBYpV6PSBluGhiOr 1CIJr9c99uRqlbvHXulM+tT7W7R1hRcTRJug10UFV6OxxMn3/+AG7QjelUJWPoRDD1+wKILma/vsY +5zNy71IFkMeVCRszeKnQ9zIlspT6+N5OAezNbwNGTO00AlTkbRWmHg1+cWz/jjW3W0mMHbgHS3lf 8bQsVar/x5Rs8iT/mhlUN0wZz3wZtOw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1cvoEt-0008Ea-Ol; Wed, 05 Apr 2017 16:56:59 +0000 Received: from mail-pf0-f178.google.com ([209.85.192.178]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1cvoEp-0008CR-TZ for linux-arm-kernel@lists.infradead.org; Wed, 05 Apr 2017 16:56:57 +0000 Received: by mail-pf0-f178.google.com with SMTP id s16so10130815pfs.0 for ; Wed, 05 Apr 2017 09:56:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=2IsENTkS6wi+KRrKUESUz1FyswFUBoXcWSXxZgSSnpk=; b=p3ZRZE9rykyIS5wEceOG3b8cCmh8ZEJcTkbHmuj+9dF37MrvOSteVA0oZly5kFnlS4 cBOpWIK7Sv4mZ9sp8jzYdD6oMU7PynrCPsjOfkSs3zQssJclif97aDRfZV17zEiqB+xX pVy0cQHN8YPEK38o6WzdZZn2d9aVJWdehjPUrrAIN+dKItLjQyUXm8AMrx0vMRLBTUbT 5G6/qDT5PufnZ6aLt+Fkj72vwuNlQ04HEna/fS6Coi56obPj2cnjHlxTQMZWWLTPZjvD yPBSC/+vXmK8JvBbjK4unkFXPvSUhzgBuspraOBzRrHQ6zdvvXk5l0zATEzm7nxPaPy5 /JLw== X-Gm-Message-State: AFeK/H3+cyYCngYXohIUPQm7lbniIzRpQho+BbJF9lmPgqt1YrYeDu4avv5kpS836t5M6BMO X-Received: by 10.99.247.69 with SMTP id f5mr32006644pgk.63.1491411394475; Wed, 05 Apr 2017 09:56:34 -0700 (PDT) Received: from mka.mtv.corp.google.com ([172.22.64.162]) by smtp.gmail.com with ESMTPSA id s14sm8264566pgs.0.2017.04.05.09.56.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 05 Apr 2017 09:56:33 -0700 (PDT) From: Matthias Kaehlcke To: Ard Biesheuvel , Greg Hackmann , Herbert Xu , "David S . Miller" , Catalin Marinas , Will Deacon Subject: [PATCH] crypto: arm64/sha: use %c constraint code in ASM_EXPORT Date: Wed, 5 Apr 2017 09:56:03 -0700 Message-Id: <20170405165603.87264-1-mka@chromium.org> X-Mailer: git-send-email 2.12.2.715.g7642488e1d-goog X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170405_095655_977372_9FE83A14 X-CRM114-Status: UNSURE ( 9.52 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Grant Grundler , linux-kernel@vger.kernel.org, Michael Davidson , Matthias Kaehlcke , linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP From: Greg Hackmann The current definition of ASM_EXPORT doesn't work properly with clang, according to https://bugs.llvm.org//show_bug.cgi?id=27250#c3 it relies on gcc specific behavior. Change the constraint from an intermediate to an output expression which works with both gcc and clang. From: Greg Hackmann Commit-message-by: Matthias Kaehlcke Signed-off-by: Greg Hackmann Signed-off-by: Matthias Kaehlcke --- arch/arm64/crypto/sha1-ce-glue.c | 2 +- arch/arm64/crypto/sha2-ce-glue.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/crypto/sha1-ce-glue.c b/arch/arm64/crypto/sha1-ce-glue.c index aefda9868627..c71e94ba0e43 100644 --- a/arch/arm64/crypto/sha1-ce-glue.c +++ b/arch/arm64/crypto/sha1-ce-glue.c @@ -18,7 +18,7 @@ #include #define ASM_EXPORT(sym, val) \ - asm(".globl " #sym "; .set " #sym ", %0" :: "I"(val)); + asm(".globl " #sym "; .set " #sym ", %c0" :: "I"(val)); MODULE_DESCRIPTION("SHA1 secure hash using ARMv8 Crypto Extensions"); MODULE_AUTHOR("Ard Biesheuvel "); diff --git a/arch/arm64/crypto/sha2-ce-glue.c b/arch/arm64/crypto/sha2-ce-glue.c index 7cd587564a41..381b5fb2dcb2 100644 --- a/arch/arm64/crypto/sha2-ce-glue.c +++ b/arch/arm64/crypto/sha2-ce-glue.c @@ -18,7 +18,7 @@ #include #define ASM_EXPORT(sym, val) \ - asm(".globl " #sym "; .set " #sym ", %0" :: "I"(val)); + asm(".globl " #sym "; .set " #sym ", %c0" :: "I"(val)); MODULE_DESCRIPTION("SHA-224/SHA-256 secure hash using ARMv8 Crypto Extensions"); MODULE_AUTHOR("Ard Biesheuvel ");