From patchwork Wed Apr 5 15:22:24 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ralph Sennhauser X-Patchwork-Id: 9664467 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id BA29660353 for ; Wed, 5 Apr 2017 15:22:59 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AB008284BC for ; Wed, 5 Apr 2017 15:22:59 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9F99B28533; Wed, 5 Apr 2017 15:22:59 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FROM autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 0814F284BC for ; Wed, 5 Apr 2017 15:22:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=reLWXR6qIJ26UhJNgBs/WOFwrklDAo8A/ATvsVAydC8=; b=ntMYyzbX+qWR2V axpx/a4MDbxs6jF/eU+W7cPktXyaIVR62yokY931tKgh8rEB2ptsex9i+afrgI9LO0JIS95184fgz bBPSxrdZ9sy6QKbL+DO8BzcYGviOF1kKGmFfL3fxEf7WZwQWo+KO6+RhUJrn+wtZaAvwMbJL9BtT2 jnNg0Xj8PrH10UqKtUPBnnLorXl3cEfxyqiELAUzYxGsp9a9QykXBDRFqbbur0YHXDPQQZA5kgVbZ k4QDY2+c8jQUrGoU+t5MV/k6C+LfcwJlJZatp2SxP6TA4Gl+HDB+qoOdxBAjKJUD5Mwg309V02+Ob 0CoEJnrAAdsha+80oMjg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1cvmlo-0000pe-Kj; Wed, 05 Apr 2017 15:22:52 +0000 Received: from mail-wr0-x244.google.com ([2a00:1450:400c:c0c::244]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1cvmlk-0000mC-Bv for linux-arm-kernel@lists.infradead.org; Wed, 05 Apr 2017 15:22:50 +0000 Received: by mail-wr0-x244.google.com with SMTP id w43so3634712wrb.1 for ; Wed, 05 Apr 2017 08:22:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=yacrxVtdXGWWr0mdvu5Vh8vino9+Ta0UGFZThbSyB3c=; b=fQZ6p7kp5bYxXAMs8ajK7szq4o9ZGXw3axNnsytkPhi6dJA053v8QYvB+CB3DGAULQ tPk/oeA3MSADtVEotHimQcYMTQEv2cP1ufy0BOp+B2A6Xn4B47xJ9mvO9Hmw5N7r59Ts GlWHseVBzl5pP5rDK6RuwOX1FaJzTmpEbhhDWVXNX9Lr/9yNAHr4cb4QGpYvqcRRjY1A J4zVaQMKMp9NkkKtBU5Dajc3YZ8F8a+AYjrHTIZb3VplyxsxObOk2dxdbF01W/wjYYQ/ FkEEJWzt3bToijs0H2jN+vM7eNLSR2xnQJup93tVHzK3nLK77jA1EfwA/K5lnQokCJgF 1Jeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=yacrxVtdXGWWr0mdvu5Vh8vino9+Ta0UGFZThbSyB3c=; b=o/CPJ2Mg25hwGwFH2mLwbGIIAnp+ZO3+/8VZ5gIIZ23TtQLumLyuaZ1hSAax/0VNoa XkQHn5XQhwpWEeEcZYhlEoMPRmT61zjPmTNx0oCQ36WmUHT+jyjl9jOcYD/Qmdz1X6Lj fjZTLnXWhPfToDPXQuUHeJ0Ao7ccD40xJpi9dx1Ij1OTWRNSwnretXNqzaazliTYN8AB MtNkf9/h9G4qu566XMjPdvLpxWl3DWYX6+wN4vOac2zH1kp4vgJ9p0TrPV1WOiXYwHrI 6dphO5EwvJAObChSYA6IjyLdXvJZhoH//r8j3Lqhffp8xa5+XWTJSP9CxxU9QyKFAzuX TAZg== X-Gm-Message-State: AFeK/H0e8Efz+H1z7MJ0IG11gxpjm+z1ncQxdAX2cNQoRufRdogKwRR4k0KaT85WXX5sxg== X-Received: by 10.223.128.231 with SMTP id 94mr27155028wrl.20.1491405746268; Wed, 05 Apr 2017 08:22:26 -0700 (PDT) Received: from localhost ([37.209.189.139]) by smtp.googlemail.com with ESMTPSA id e23sm18403360wmi.16.2017.04.05.08.22.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 05 Apr 2017 08:22:26 -0700 (PDT) Date: Wed, 5 Apr 2017 17:22:24 +0200 From: Ralph Sennhauser To: Andrew Lunn Subject: Re: [PATCH 1/1] ARM: dts: armada-xp-linksys-mamba: use wan instead of internet for DSA port Message-ID: <20170405172224.38c1f9fb@gmail.com> In-Reply-To: <20170405142824.GB13449@lunn.ch> References: <20170405052847.326-1-ralph.sennhauser@gmail.com> <20170405142824.GB13449@lunn.ch> Organization: none X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170405_082248_580679_28CD79A6 X-CRM114-Status: GOOD ( 23.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Jason Cooper , linux-kernel@vger.kernel.org, Russell King , Rob Herring , Gregory Clement , linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP On Wed, 5 Apr 2017 16:28:24 +0200 Andrew Lunn wrote: > On Wed, Apr 05, 2017 at 07:28:46AM +0200, Ralph Sennhauser wrote: > > The LEDs for the "wan" port are already labeled "mamba:amber:wan" > > resp. "mamba:white:wan". So besides being an outlier with regard to > > the rest of the product line (see table below) changing the label > > fixes an internal inconsistency as well. > > > > This will be visible in user space. Given commit cb4f71c42988 ("ARM: > > dts: armada-38x: change order of ethernet DT nodes on Armada 38x") > > it's expected to happen anyway. Commit 499400c9ac20 ("ARM: dts: > > armada-xp-linksys-mamba: Utilize new DSA binding") switches to the > > new bindings, use this opportunity to do it now rather than later. > > > > |-----------------------------------------------------------------| > > | Labels used for the case and those used for the DSA ports | > > |-----------------------------------------------------------------| > > | case labels | armada-385-linksys-* | > > armada-xp-linksys-mamba | > > |---------------|-----------------------|-------------------------| > > | internet | wan | > > internet | | 1 | > > lan1 | lan1 | | > > 2 | lan2 | > > lan2 | | 3 | > > lan3 | lan3 | | > > 4 | lan4 | > > lan4 | > > |-----------------------------------------------------------------| > > Hi Ralph > > I always encourage people to use the case labels as interface names. > So if i was going to make a change, it would be wan->internet for the > armada-385-linksys-*. Glad Imre used lan1 instead of 1 ;) The reverse I have appended to this mail so people know what it would look like. In fact "internet" label on the case is uppercase, would this matter for you for new bindings, or would you still use the lowercase version? It's not relevant here, just wondering. > > > I underestimated the urge of people to make all the same before. > > While I do not particularly like this sort of change I see it > > coming anyway. So this patch is meant to make it a deliberate > > decision so it no longer is an item lurking in the shadows. Whether > > this patch gets taken or rejected my goal is reached. > > I would say, this is now too late. Changing an interface name will > break configuration scripts. We are stuck with it. > If it weren't for commit cb4f71c42988 that would have been obvious for me as well. Thanks Ralph The inverse (following trough all the way) would look the following, same changes applies to Rango which is not yet supported by vanilla kernel. diff --git a/arch/arm/boot/dts/armada-385-linksys-caiman.dts b/arch/arm/boot/dts/armada-385-linksys-caiman.dts index a1b6e68..3efceda 100644 --- a/arch/arm/boot/dts/armada-385-linksys-caiman.dts +++ b/arch/arm/boot/dts/armada-385-linksys-caiman.dts @@ -53,13 +53,13 @@ #address-cells = <1>; #size-cells = <0>; - wan_amber@0 { - label = "caiman:amber:wan"; + internet_amber@0 { + label = "caiman:amber:internet"; reg = <0x0>; }; - wan_white@1 { - label = "caiman:white:wan"; + internet_white@1 { + label = "caiman:white:internet"; reg = <0x1>; }; diff --git a/arch/arm/boot/dts/armada-385-linksys-cobra.dts b/arch/arm/boot/dts/armada-385-linksys-cobra.dts index a1a75af..4f2e7f6 100644 --- a/arch/arm/boot/dts/armada-385-linksys-cobra.dts +++ b/arch/arm/boot/dts/armada-385-linksys-cobra.dts @@ -53,13 +53,13 @@ #address-cells = <1>; #size-cells = <0>; - wan_amber@0 { - label = "cobra:amber:wan"; + internet_amber@0 { + label = "cobra:amber:internet"; reg = <0x0>; }; - wan_white@1 { - label = "cobra:white:wan"; + internet_white@1 { + label = "cobra:white:internet"; reg = <0x1>; }; diff --git a/arch/arm/boot/dts/armada-385-linksys-shelby.dts b/arch/arm/boot/dts/armada-385-linksys-shelby.dts index c7a8ddd..a7b47f7 100644 --- a/arch/arm/boot/dts/armada-385-linksys-shelby.dts +++ b/arch/arm/boot/dts/armada-385-linksys-shelby.dts @@ -53,13 +53,13 @@ #address-cells = <1>; #size-cells = <0>; - wan_amber@0 { - label = "shelby:amber:wan"; + internet_amber@0 { + label = "shelby:amber:internet"; reg = <0x0>; }; - wan_white@1 { - label = "shelby:white:wan"; + internet_white@1 { + label = "shelby:white:internet"; reg = <0x1>; }; diff --git a/arch/arm/boot/dts/armada-385-linksys.dtsi b/arch/arm/boot/dts/armada-385-linksys.dtsi index aa0d225..8460066 100644 --- a/arch/arm/boot/dts/armada-385-linksys.dtsi +++ b/arch/arm/boot/dts/armada-385-linksys.dtsi @@ -145,7 +145,7 @@ port@4 { reg = <4>; - label = "wan"; + label = "internet"; }; port@5 { @@ -360,7 +360,7 @@ port@4 { reg = <4>; - label = "wan"; + label = "internet"; }; port@5 { diff --git a/arch/arm/boot/dts/armada-xp-linksys-mamba.dts b/arch/arm/boot/dts/armada-xp-linksys-mamba.dts index 9efcf59..ed2fe8f 100644 --- a/arch/arm/boot/dts/armada-xp-linksys-mamba.dts +++ b/arch/arm/boot/dts/armada-xp-linksys-mamba.dts @@ -140,13 +140,13 @@ compatible = "ti,tlc59116"; reg = <0x68>; - wan_amber@0 { - label = "mamba:amber:wan"; + internet_amber@0 { + label = "mamba:amber:internet"; reg = <0x0>; }; - wan_white@1 { - label = "mamba:white:wan"; + internet_white@1 { + label = "mamba:white:internet"; reg = <0x1>; };