| Message ID | 20170417182820.26670-4-martin.blumenstingl@googlemail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 17/04/17 19:28, Martin Blumenstingl wrote: > These are only passed as of_device_id.data and never modified. Thus we > can mark them as static const, just like the of_device_id instances > where they are used. > > Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> Reordering the patches would make this simpler as you'd only have to do the existing ones. Not a bit issue though so you could just not bother... Jonathan > --- > drivers/iio/adc/meson_saradc.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/iio/adc/meson_saradc.c b/drivers/iio/adc/meson_saradc.c > index cf13691009ee..8f742b71b165 100644 > --- a/drivers/iio/adc/meson_saradc.c > +++ b/drivers/iio/adc/meson_saradc.c > @@ -843,31 +843,31 @@ static const struct iio_info meson_sar_adc_iio_info = { > .driver_module = THIS_MODULE, > }; > > -struct meson_sar_adc_data meson_sar_adc_meson8_data = { > +static const struct meson_sar_adc_data meson_sar_adc_meson8_data = { > .has_bl30_integration = false, > .resolution = 10, > .name = "meson-meson8b-saradc", > }; > > -struct meson_sar_adc_data meson_sar_adc_meson8b_data = { > +static const struct meson_sar_adc_data meson_sar_adc_meson8b_data = { > .has_bl30_integration = false, > .resolution = 10, > .name = "meson-meson8b-saradc", > }; > > -struct meson_sar_adc_data meson_sar_adc_gxbb_data = { > +static const struct meson_sar_adc_data meson_sar_adc_gxbb_data = { > .has_bl30_integration = true, > .resolution = 10, > .name = "meson-gxbb-saradc", > }; > > -struct meson_sar_adc_data meson_sar_adc_gxl_data = { > +static const struct meson_sar_adc_data meson_sar_adc_gxl_data = { > .has_bl30_integration = true, > .resolution = 12, > .name = "meson-gxl-saradc", > }; > > -struct meson_sar_adc_data meson_sar_adc_gxm_data = { > +static const struct meson_sar_adc_data meson_sar_adc_gxm_data = { > .has_bl30_integration = true, > .resolution = 12, > .name = "meson-gxm-saradc", >
diff --git a/drivers/iio/adc/meson_saradc.c b/drivers/iio/adc/meson_saradc.c index cf13691009ee..8f742b71b165 100644 --- a/drivers/iio/adc/meson_saradc.c +++ b/drivers/iio/adc/meson_saradc.c @@ -843,31 +843,31 @@ static const struct iio_info meson_sar_adc_iio_info = { .driver_module = THIS_MODULE, }; -struct meson_sar_adc_data meson_sar_adc_meson8_data = { +static const struct meson_sar_adc_data meson_sar_adc_meson8_data = { .has_bl30_integration = false, .resolution = 10, .name = "meson-meson8b-saradc", }; -struct meson_sar_adc_data meson_sar_adc_meson8b_data = { +static const struct meson_sar_adc_data meson_sar_adc_meson8b_data = { .has_bl30_integration = false, .resolution = 10, .name = "meson-meson8b-saradc", }; -struct meson_sar_adc_data meson_sar_adc_gxbb_data = { +static const struct meson_sar_adc_data meson_sar_adc_gxbb_data = { .has_bl30_integration = true, .resolution = 10, .name = "meson-gxbb-saradc", }; -struct meson_sar_adc_data meson_sar_adc_gxl_data = { +static const struct meson_sar_adc_data meson_sar_adc_gxl_data = { .has_bl30_integration = true, .resolution = 12, .name = "meson-gxl-saradc", }; -struct meson_sar_adc_data meson_sar_adc_gxm_data = { +static const struct meson_sar_adc_data meson_sar_adc_gxm_data = { .has_bl30_integration = true, .resolution = 12, .name = "meson-gxm-saradc",
These are only passed as of_device_id.data and never modified. Thus we can mark them as static const, just like the of_device_id instances where they are used. Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> --- drivers/iio/adc/meson_saradc.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)