From patchwork Wed Apr 19 21:22:11 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthias Kaehlcke X-Patchwork-Id: 9689033 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 85E25602C9 for ; Wed, 19 Apr 2017 21:23:05 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 74FC9282E2 for ; Wed, 19 Apr 2017 21:23:05 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 67F4D283E2; Wed, 19 Apr 2017 21:23:05 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.4 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_SORBS_SPAM autolearn=no version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 257AD282E2 for ; Wed, 19 Apr 2017 21:23:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=cA7HKasy/q7IKqm6DihyNCkiYho03Nhl9ajErJJxxg8=; b=Y4M XRZCJ3Bq+BIRX6HPAWdPM4wW+995qMy1zc1NkBhnziH38/1eI4vdlN86DAOTpB1NNCn7j9RofcBc6 U+hDs7pGM30G0i60n3LyckXot2mMrIbhoSWUQGjTgCN8vvhhktbI5M9/MBp2TxLjaBFUly8JyXPrS MXvTwSo4W+QZDO7DbRHChZaEmuf+QACLH86Au7b4E2ODnb8cBHboTExpmoP1KpNg4CGnGO77Ywrf2 jvu4skDZbeaI64vgVl7Xe+/MCPEmBoYFUhSsspGdlTJtEAL10PakFMG2/GfZJUaBtNxOQN29aSEtH 6EsRGa3h+mp9FwQHl7Xj0zOvecb+ZGQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1d0x44-0005nB-Ak; Wed, 19 Apr 2017 21:23:04 +0000 Received: from mail-yb0-f176.google.com ([209.85.213.176]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1d0x41-0005Xf-Af for linux-arm-kernel@lists.infradead.org; Wed, 19 Apr 2017 21:23:02 +0000 Received: by mail-yb0-f176.google.com with SMTP id 11so13738408ybw.1 for ; Wed, 19 Apr 2017 14:22:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=nFX5/8LJGCbBYqY1qkFroKP9ZO+3x8sftOHdqBH/qd8=; b=miEzFcTDVQXL5gLLMJ+s/AHVCejRYaIu05Zn0/4e0hHmwhxKVz3ecFuZCwyQ19F7Nu sygOruxv6G/xpbR2sChHAuCk0WfChjBu4NBTODyBVAsq4tkDBOyKNj57Lp4CBVoOSGDz bcbxGQDE89rWRDeSzuMFSJFiF0Q/IZd6OOr5IlSO/RPHTtnu8o238xYdN+lLqdtBOQJt kDGh8zJu4E8Bf2PiTTb6FEkXl9r7SQlP71lTIL2BjvQfqBVEK0EYB2o/VK66L91ZRAf7 fqdMCKmLVkMmy2ItbyhTHFWPKFSfUUhwhPyGNvw6SjaLMiyg7PILAwIuP9QtGuBhpgbn q8AA== X-Gm-Message-State: AN3rC/75XENL4+7FLkC9IrJgvhzEHkQXiBGgwS3K4YJYDj0QgVOQ8iue yGiJ3QbPVndsJbir X-Received: by 10.98.71.202 with SMTP id p71mr4872808pfi.39.1492636959525; Wed, 19 Apr 2017 14:22:39 -0700 (PDT) Received: from mka.mtv.corp.google.com ([172.22.64.162]) by smtp.gmail.com with ESMTPSA id s136sm6218196pfs.70.2017.04.19.14.22.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 19 Apr 2017 14:22:38 -0700 (PDT) From: Matthias Kaehlcke To: Catalin Marinas , Will Deacon Subject: [PATCH] arm64: prefetch: Change assembly to be compatible with gcc and clang Date: Wed, 19 Apr 2017 14:22:11 -0700 Message-Id: <20170419212211.95803-1-mka@chromium.org> X-Mailer: git-send-email 2.12.2.816.g2cccc81164-goog X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170419_142301_435235_A58CD44A X-CRM114-Status: GOOD ( 10.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Grant Grundler , linux-kernel@vger.kernel.org, Greg Hackmann , Michael Davidson , Matthias Kaehlcke , Kristof Beyls , linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP clang fails to build with the current code: arch/arm64/include/asm/processor.h:172:15: error: invalid operand in inline asm: 'prfm pldl1keep, ${0:a}' Apparently clang does not support the 'a' modifier. Change the constraint from 'p' ('An operand that is a valid memory address is allowed') to 'Q' ('A memory address which uses a single base register with no offset'), which works for both gcc and clang. Signed-off-by: Matthias Kaehlcke --- arch/arm64/include/asm/processor.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm64/include/asm/processor.h b/arch/arm64/include/asm/processor.h index c97b8bd2acba..bfdc82e924a5 100644 --- a/arch/arm64/include/asm/processor.h +++ b/arch/arm64/include/asm/processor.h @@ -165,21 +165,21 @@ extern struct task_struct *cpu_switch_to(struct task_struct *prev, #define ARCH_HAS_PREFETCH static inline void prefetch(const void *ptr) { - asm volatile("prfm pldl1keep, %a0\n" : : "p" (ptr)); + asm volatile("prfm pldl1keep, %0\n" : : "Q" (ptr)); } #define ARCH_HAS_PREFETCHW static inline void prefetchw(const void *ptr) { - asm volatile("prfm pstl1keep, %a0\n" : : "p" (ptr)); + asm volatile("prfm pstl1keep, %0\n" : : "Q" (ptr)); } #define ARCH_HAS_SPINLOCK_PREFETCH static inline void spin_lock_prefetch(const void *ptr) { asm volatile(ARM64_LSE_ATOMIC_INSN( - "prfm pstl1strm, %a0", - "nop") : : "p" (ptr)); + "prfm pstl1strm, %0", + "nop") : : "Q" (ptr)); } #define HAVE_ARCH_PICK_MMAP_LAYOUT