From patchwork Wed Apr 26 22:04:43 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Andersson X-Patchwork-Id: 9702153 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id AA26E60245 for ; Wed, 26 Apr 2017 22:05:28 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9ABD9212BE for ; Wed, 26 Apr 2017 22:05:28 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8F69B26419; Wed, 26 Apr 2017 22:05:28 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 34177212BE for ; Wed, 26 Apr 2017 22:05:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=JMBcWELpYPajq4cFVuFGpBH/caIdi1phR513teHmBXI=; b=E9U Nl0GRDSpzCDEEvKCFMMA/AxWg2LzSFlal9RB1SInEOQ/qy6otUfXLAPXUhk5h1yQ7YJ3UOPGndJdx SquY8F2GcanljHp5FoAvwsuBeVxb0L+dSFoba/tFQZDjDgBvZ8Yfo5r7tH1a6pUW4OTn70A413E0J ZAth9vF9a43cIq6WT1wZhISbvVtfdcTCLfLawvZKv2OV72bZmkP0JbrHitQLyTGiuweUqq4mZlKCe 4dcaU0o64lpwWgHPuRkaYgNS9NPZPC4JivIIjfIyyLGZnVc73LXtRJPoPJq8FyIxYSffe1Kn+4/Xe MOrU/u2fCer2dO0uZBh0kBB7OJdrQ3w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1d3V3u-0007No-7o; Wed, 26 Apr 2017 22:05:26 +0000 Received: from mail-pf0-x232.google.com ([2607:f8b0:400e:c00::232]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1d3V3d-0005sq-HC for linux-arm-kernel@lists.infradead.org; Wed, 26 Apr 2017 22:05:13 +0000 Received: by mail-pf0-x232.google.com with SMTP id 194so6941775pfv.3 for ; Wed, 26 Apr 2017 15:04:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=evGbeb4ehuBCPy+HzvVqJKRM82ozeDbmTGrseC55628=; b=A3zFme6JErTtW+tbs/MCm52NFYBBxQ+mhjRuDVxMgacd2kTL/1g84yJm1podYDIsc2 WrJOB4ylLphTexjb9FUWKuTEIeiWw61DyGY4lcipenSrE1dd0kvz5JHtHQpcPKLD9s1N rzKMggtSBixKEzGAU2VeBxjCl7jMraQHtojDs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=evGbeb4ehuBCPy+HzvVqJKRM82ozeDbmTGrseC55628=; b=HGYIO4oNLWzPq7cckMIv3IUEEXMLtV7tmn1vchBSi6vCUfiJa7ZOrYUGDAbPZ/DHiR 5OqKSb2Q8KCv9faPzYqeqf2W5WSX4IZNQxKc0UHvFXGSG5W0HBafNWeekwZmcPamnrvO E78NEKtOlDu1swh2I8US68Mlo+D59vBCM9BIPAVDfOIKN8gF88usGmi0Iap5a8Pf/7T8 FV5RWy2kt+yDW01HI8r6VbOww7s7XM0BpU5PzVo9mZaijet8NvkN3rf7lMQfb3eKwDuH sn6AB2iG1vqJB6j+fT0iOCL2SyQ+k9iHP+d0h6lPY24UEiWEsFXwNbP3oGPN1awOIJBG itEg== X-Gm-Message-State: AN3rC/7unS6x9hnZ83vn8X0ekx17g1tHD5Y3Aue4gnszjh4psbyED02Q /iHpeautWplRvT3J X-Received: by 10.84.136.70 with SMTP id 64mr2762179plk.82.1493244288648; Wed, 26 Apr 2017 15:04:48 -0700 (PDT) Received: from localhost.localdomain (ip68-111-223-48.sd.sd.cox.net. [68.111.223.48]) by smtp.gmail.com with ESMTPSA id t141sm468942pgb.3.2017.04.26.15.04.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 26 Apr 2017 15:04:48 -0700 (PDT) From: Bjorn Andersson To: Eugene Krasnikov , Kalle Valo Subject: [PATCH 1/2] wcn36xx: Pass used skb to ieee80211_tx_status() Date: Wed, 26 Apr 2017 15:04:43 -0700 Message-Id: <20170426220444.10539-1-bjorn.andersson@linaro.org> X-Mailer: git-send-email 2.12.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170426_150509_665873_28178CA7 X-CRM114-Status: GOOD ( 10.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, David Brown , Nicolas Dechesne , netdev@vger.kernel.org, Andy Gross , wcn36xx@lists.infradead.org, linux-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP As the tx skbs are collected they should be passed to ieee80211_tx_status() rather than ieee80211_free_txskb(), as the prior will take care of monitoring and LED triggers while the latter will consider the skb dropped. Signed-off-by: Bjorn Andersson --- drivers/net/wireless/ath/wcn36xx/dxe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/wcn36xx/dxe.c b/drivers/net/wireless/ath/wcn36xx/dxe.c index 87dfdaf9044c..938b7bd733cf 100644 --- a/drivers/net/wireless/ath/wcn36xx/dxe.c +++ b/drivers/net/wireless/ath/wcn36xx/dxe.c @@ -371,7 +371,7 @@ static void reap_tx_dxes(struct wcn36xx *wcn, struct wcn36xx_dxe_ch *ch) info = IEEE80211_SKB_CB(ctl->skb); if (!(info->flags & IEEE80211_TX_CTL_REQ_TX_STATUS)) { /* Keep frame until TX status comes */ - ieee80211_free_txskb(wcn->hw, ctl->skb); + ieee80211_tx_status(wcn->hw, ctl->skb); } spin_lock(&ctl->skb_lock); if (wcn->queues_stopped) {