[v2] ARM: dts: rockchip: add eDP panel support for Firefly

Commit Message

ayaka May 8, 2017, 3:58 p.m. UTC

This patch adds the supporting to the eDP panel sold by
the T-CHIP for the Firefly RK3288. I assign the VOP lite
for the eDP panel and VOP big to HDMI, as the HDMI supports
4K resolution. With a different VOP device, eDP panel
and HDMI could display a different contents.

The InvenSense MPU6050 sensor at the botton of the panel
is also enabled.

The Firefly RK3288 Reload use a different GPIO pin to enable
the power of the eDP panel.

Signed-off-by: Randy Li <[e-mail]>
---
 arch/arm/boot/dts/rk3288-firefly.dtsi | 112 ++++++++++++++++++++++++++++++++++
 1 file changed, 112 insertions(+)

Comments

Heiko Stuebner May 24, 2017, 3:45 p.m. UTC | #1

Hi Randy,

Am Montag, 8. Mai 2017, 23:58:33 CEST schrieb Randy Li:
> This patch adds the supporting to the eDP panel sold by
> the T-CHIP for the Firefly RK3288. I assign the VOP lite
> for the eDP panel and VOP big to HDMI, as the HDMI supports
> 4K resolution. With a different VOP device, eDP panel
> and HDMI could display a different contents.
> 
> The InvenSense MPU6050 sensor at the botton of the panel
> is also enabled.
> 
> The Firefly RK3288 Reload use a different GPIO pin to enable
> the power of the eDP panel.
> 
> Signed-off-by: Randy Li <[e-mail]>

Sorry, I'm not yet sure, what to make of this patch.

On the firefly the edp pins are actual part of the general pin header and
while the edp pins themself do not have multiple functions, for example
the pin you claim as interrupt for the mpu6050 (gpio5_b4) also is part
of the spi0 set of pins and that pin also seems pretty randomly selected.
Same with the enable-gpio of the display.


Also claiming that every firefly board has this display connected also
feels strange and the whole display thing would make more sense
as a devicetree overlay [0], though I don't know how these
should get handled in-kernel - if at all.


And finally, please don't try to use the devicetree to configure outputs
(forcing edp to one and hdmi to the other). The devicetree is supposed
to describe the hardware and of course both vops can drive the edp and
if necessary the drm driver should handle differences and decide on the
vop to use.


Heiko

[0] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/overlay-notes.txt

Patch

diff --git a/arch/arm/boot/dts/rk3288-firefly.dtsi b/arch/arm/boot/dts/rk3288-firefly.dtsi
index 436878b..db22316 100644
--- a/arch/arm/boot/dts/rk3288-firefly.dtsi
+++ b/arch/arm/boot/dts/rk3288-firefly.dtsi
@@ -62,6 +62,62 @@ 
 		};
 	};
 
+	backlight: backlight {
+		compatible = "pwm-backlight";
+		brightness-levels = <
+			  3   4   5   6   7
+			  8   9  10  11  12  13  14  15
+			 16  17  18  19  20  21  22  23
+			 24  25  26  27  28  29  30  31
+			 32  33  34  35  36  37  38  39
+			 40  41  42  43  44  45  46  47
+			 48  49  50  51  52  53  54  55
+			 56  57  58  59  60  61  62  63
+			 64  65  66  67  68  69  70  71
+			 72  73  74  75  76  77  78  79
+			 80  81  82  83  84  85  86  87
+			 88  89  90  91  92  93  94  95
+			 96  97  98  99 100 101 102 103
+			104 105 106 107 108 109 110 111
+			112 113 114 115 116 117 118 119
+			120 121 122 123 124 125 126 127
+			128 129 130 131 132 133 134 135
+			136 137 138 139 140 141 142 143
+			144 145 146 147 148 149 150 151
+			152 153 154 155 156 157 158 159
+			160 161 162 163 164 165 166 167
+			168 169 170 171 172 173 174 175
+			176 177 178 179 180 181 182 183
+			184 185 186 187 188 189 190 191
+			192 193 194 195 196 197 198 199
+			200 201 202 203 204 205 206 207
+			208 209 210 211 212 213 214 215
+			216 217 218 219 220 221 222 223
+			224 225 226 227 228 229 230 231
+			232 233 234 235 236 237 238 239
+			240 241 242 243 244 245 246 247
+			248 249 250 251 252 253 254 255>;
+		default-brightness-level = <180>;
+		pwms = <&pwm1 0 25000 0>;
+		pwm-names = "backlight";
+		power-supply = <&vcc_sys>;
+	};
+
+	panel: panel {
+		compatible ="lg,lp079qx1-sp0v";
+		power-supply = <&vcc_sys>;
+		backlight = <&backlight>;
+		enable-gpios = <&gpio0 RK_PB5 GPIO_ACTIVE_HIGH>;
+
+		ports {
+			panel_in: port {
+				panel_in_edp: endpoint {
+					remote-endpoint = <&edp_out_panel>;
+				};
+			};
+		};
+	};
+
 	dovdd_1v8: dovdd-1v8-regulator {
 		compatible = "regulator-fixed";
 		regulator-name = "dovdd_1v8";
@@ -203,6 +259,32 @@ 
 	cpu0-supply = <&vdd_cpu>;
 };
 
+&edp {
+	vcc-supply = <&vdd_10>;
+	vccio-supply = <&vcc_18>;
+	status = "okay";
+
+	ports {
+		edp_out: port@1 {
+			reg = <1>;
+			#address-cells = <1>;
+			#size-cells = <0>;
+			edp_out_panel: endpoint {
+				reg = <0>;
+				remote-endpoint = <&panel_in_edp>;
+			};
+		};
+	};
+};
+
+&edp_in {
+	/delete-node/ endpoint@0;
+};
+
+&edp_phy {
+	status = "okay";
+};
+
 &emmc {
 	bus-width = <8>;
 	cap-mmc-highspeed;
@@ -240,8 +322,14 @@ 
 &hdmi {
 	ddc-i2c-bus = <&i2c5>;
 	status = "okay";
+
+};
+
+&hdmi_in {
+	/delete-node/ endpoint@1;
 };
 
+
 &i2c0 {
 	clock-frequency = <400000>;
 	status = "okay";
@@ -385,6 +473,22 @@ 
 
 &i2c1 {
 	status = "okay";
+
+	mpu6050@68 {
+		compatible = "invensense,mpu6050";
+		reg = <0x68>;
+		interrupt-parent = <&gpio5>;
+		interrupts = <RK_PB4 IRQ_TYPE_LEVEL_LOW>;
+		mount-matrix = "0",
+			       "1",
+			       "0",
+			       "-1",
+			       "0",
+			       "0",
+			       "0",
+			       "0",
+			       "-1";
+	};
 };
 
 &i2c2 {
@@ -601,6 +705,10 @@ 
 	status = "okay";
 };
 
+&vopb_out {
+	/delete-node/ endpoint@1;
+};
+
 &vopl {
 	status = "okay";
 };
@@ -609,6 +717,10 @@ 
 	status = "okay";
 };
 
+&vopl_out {
+	/delete-node/ endpoint@0;
+};
+
 &wdt {
 	status = "okay";
 };