| Message ID | 20170607061750.28516-1-antoine.tenart@free-electrons.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
From: Antoine Tenart <antoine.tenart@free-electrons.com> Date: Wed, 7 Jun 2017 08:17:50 +0200 > The mvpp22_port_mii_set() function was added by 2697582144dd, but the > function directly returns without doing anything. This return was used > when debugging and wasn't removed before sending the patch. Fix this. > > Fixes: 2697582144dd ("net: mvpp2: handle misc PPv2.1/PPv2.2 differences") > Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com> > Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Applied, thank you.
diff --git a/drivers/net/ethernet/marvell/mvpp2.c b/drivers/net/ethernet/marvell/mvpp2.c index 9b875d776b29..70bca2a6fb02 100644 --- a/drivers/net/ethernet/marvell/mvpp2.c +++ b/drivers/net/ethernet/marvell/mvpp2.c @@ -4186,8 +4186,6 @@ static void mvpp22_port_mii_set(struct mvpp2_port *port) { u32 val; - return; - /* Only GOP port 0 has an XLG MAC */ if (port->gop_id == 0) { val = readl(port->base + MVPP22_XLG_CTRL3_REG);
The mvpp22_port_mii_set() function was added by 2697582144dd, but the function directly returns without doing anything. This return was used when debugging and wasn't removed before sending the patch. Fix this. Fixes: 2697582144dd ("net: mvpp2: handle misc PPv2.1/PPv2.2 differences") Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com> Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> --- Since v1: - Added the Fixes tag. - Added Thomas' Acked-by. drivers/net/ethernet/marvell/mvpp2.c | 2 -- 1 file changed, 2 deletions(-)