[v8] clk: Add Gemini SoC clock controller

Commit Message

Stephen Boyd June 21, 2017, 5:45 p.m. UTC

On 06/21, Linus Walleij wrote:
> The Cortina Systems Gemini (SL3516/CS3516) has an on-chip clock
> controller that derive all clocks from a single crystal, using some
> documented and some undocumented PLLs, half dividers, counters and
> gates. This is a best attempt to construct a clock driver for the
> clocks so at least we can gate off unused hardware and driver the
> PCI bus clock.
> 
> Acked-by: Philipp Zabel <[e-mail]>
> Signed-off-by: Linus Walleij <[e-mail]>
> ---

Applied to clk-next + this fixup

---8<---

Comments

Linus Walleij June 25, 2017, 10:08 p.m. UTC | #1

On Wed, Jun 21, 2017 at 7:45 PM, Stephen Boyd <[e-mail]> wrote:
> On 06/21, Linus Walleij wrote:
>> The Cortina Systems Gemini (SL3516/CS3516) has an on-chip clock
>> controller that derive all clocks from a single crystal, using some
>> documented and some undocumented PLLs, half dividers, counters and
>> gates. This is a best attempt to construct a clock driver for the
>> clocks so at least we can gate off unused hardware and driver the
>> PCI bus clock.
>>
>> Acked-by: Philipp Zabel <[e-mail]>
>> Signed-off-by: Linus Walleij <[e-mail]>
>> ---
>
> Applied to clk-next + this fixup

Thanks, and thanks a lot for fixing.

Hm, I copied that code from somewhere.

Now I need to try to remember where so I can go and
fix the bad example.

Yours,
Linus Walleij

Patch

diff --git a/drivers/clk/clk-gemini.c b/drivers/clk/clk-gemini.c
index 3ddd2faec674..b82db96ce0c7 100644
--- a/drivers/clk/clk-gemini.c
+++ b/drivers/clk/clk-gemini.c
@@ -279,13 +279,9 @@  static int gemini_clk_probe(struct platform_device *pdev)
 
 	/* Remap the system controller for the exclusive register */
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	if (!res)
-		return -ENODEV;
 	base = devm_ioremap_resource(dev, res);
-	if (!base) {
-		dev_err(dev, "no memory base\n");
-		return -ENODEV;
-	}
+	if (IS_ERR(base))
+		return PTR_ERR(base);
 
 	map = syscon_node_to_regmap(np);
 	if (IS_ERR(map)) {