From patchwork Wed Jun 21 17:45:40 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Boyd X-Patchwork-Id: 9802415 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 6757D60234 for ; Wed, 21 Jun 2017 17:46:12 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 506BD28633 for ; Wed, 21 Jun 2017 17:46:12 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 440E5285BA; Wed, 21 Jun 2017 17:46:12 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id BF409285BA for ; Wed, 21 Jun 2017 17:46:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=f4PLRRV6SKK2Hz5X06G6x3iAImRWJevxk6KWum+qsL8=; b=gpEjNp8uv7rbVG DRWZSfcELUdOU/l0IUGHWGCHs9i8zfzTUsCR8hSPa1HKu8h7pi7/+F9heiqusvoNlKWrsmUFTbHQg 0WqcqIPCTo45Z82U3CkxDitxLOn2kYR8LxBe/TC/XPwjexBeNaXFmwcrx1IrLlqV2bKE9n39uXnyh ccXqUaxxctPNW/1FLSB+b9WgKH7SV7Sak6kv224Nz+OyzhTvSlkBtzjauW2hP9GLge3IgqDdyz9XR 11SfZMDMapqEBCQFsFkWtJw7KsuYqoAoaP839iocc1nNZbWgCbqM3l2kHu7fWCP9j+gks03QhO6C5 REFZcrJUrNiAhc+i+15Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1dNjhf-0003Br-8t; Wed, 21 Jun 2017 17:46:07 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1dNjhb-0003AM-0D for linux-arm-kernel@lists.infradead.org; Wed, 21 Jun 2017 17:46:04 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 54518607CE; Wed, 21 Jun 2017 17:45:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1498067142; bh=kdTKKbMeTbzEgD58ovaKnddgbjih5+eZNVDkcZM0YFo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lMQAFRecsSzHQX4rNTaV5WYrOdmlmMKBdgAY5LcgAlqQdwQ1Xi2n39hl45Uv9FXo5 FguJxOpxR4zC2lHl3/NrQF0v+ojpL2zIXfvWNQByIj/Bmo3VvAmBWZsACvTeH5b84L Da2tYD2f5/SKHUVDIRvEApJkTZUj/ZYttmdtXTPg= Received: from localhost (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: sboyd@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 46B33601A0; Wed, 21 Jun 2017 17:45:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1498067141; bh=kdTKKbMeTbzEgD58ovaKnddgbjih5+eZNVDkcZM0YFo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=S3mnSdTJ4X5hSLKVv5uPK8LJ0HzkjBuMa3NYRHX7EN5lANuxiKTMeCG0xSsjBPckT mpNLDGG9ANv5jnvsah6GLZsnTgl+cecrZHhhJlTUgh45NGu9p+EW2WVQqC4/LVNtUy QGmCUv5q8cRKf9CADnzqlfRbDwtisnqrjCFdzBFU= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 46B33601A0 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=sboyd@codeaurora.org Date: Wed, 21 Jun 2017 10:45:40 -0700 From: Stephen Boyd To: Linus Walleij Subject: Re: [PATCH v8] clk: Add Gemini SoC clock controller Message-ID: <20170621174540.GB4493@codeaurora.org> References: <20170621075952.26387-1-linus.walleij@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20170621075952.26387-1-linus.walleij@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170621_104603_070529_ECC0D371 X-CRM114-Status: GOOD ( 15.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Florian Fainelli , Paulius Zaleckas , Michael Turquette , Philipp Zabel , Janos Laube , Hans Ulli Kroll , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP On 06/21, Linus Walleij wrote: > The Cortina Systems Gemini (SL3516/CS3516) has an on-chip clock > controller that derive all clocks from a single crystal, using some > documented and some undocumented PLLs, half dividers, counters and > gates. This is a best attempt to construct a clock driver for the > clocks so at least we can gate off unused hardware and driver the > PCI bus clock. > > Acked-by: Philipp Zabel > Signed-off-by: Linus Walleij > --- Applied to clk-next + this fixup ---8<--- diff --git a/drivers/clk/clk-gemini.c b/drivers/clk/clk-gemini.c index 3ddd2faec674..b82db96ce0c7 100644 --- a/drivers/clk/clk-gemini.c +++ b/drivers/clk/clk-gemini.c @@ -279,13 +279,9 @@ static int gemini_clk_probe(struct platform_device *pdev) /* Remap the system controller for the exclusive register */ res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!res) - return -ENODEV; base = devm_ioremap_resource(dev, res); - if (!base) { - dev_err(dev, "no memory base\n"); - return -ENODEV; - } + if (IS_ERR(base)) + return PTR_ERR(base); map = syscon_node_to_regmap(np); if (IS_ERR(map)) {