staging: fsl-mc: be consistent when checking strcmp() returns

Commit Message

Laurentiu Tudor Aug. 17, 2017, 11:55 a.m. UTC

From: Laurentiu Tudor <[e-mail]>

Throughout the driver we use == 0 / != 0 to check strcmp() returns except
this place, so fix it.

Signed-off-by: Laurentiu Tudor <[e-mail]>
---
 drivers/staging/fsl-mc/bus/dprc-driver.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Greg KH Aug. 23, 2017, 1:40 a.m. UTC | #1

On Thu, Aug 17, 2017 at 02:55:04PM +0300, [e-mail] wrote:
> From: Laurentiu Tudor <[e-mail]>
> 
> Throughout the driver we use == 0 / != 0 to check strcmp() returns except
> this place, so fix it.

You will just get someone else fixing it as it is not what checkpatch
recommends, so just leave it as-is please.

thanks,

greg k-h

Joe Perches Aug. 23, 2017, 2:33 a.m. UTC | #2

On Tue, 2017-08-22 at 18:40 -0700, Greg KH wrote:
> On Thu, Aug 17, 2017 at 02:55:04PM +0300, [e-mail] wrote:
> > From: Laurentiu Tudor <[e-mail]>
> > 
> > Throughout the driver we use == 0 / != 0 to check strcmp() returns except
> > this place, so fix it.
> 
> You will just get someone else fixing it as it is not what checkpatch
> recommends, so just leave it as-is please.

No.  That's not correct.

checkpatch does not make a recommendation about
style use with the strcmp family of functions.

Greg KH Aug. 23, 2017, 5:38 a.m. UTC | #3

On Tue, Aug 22, 2017 at 07:33:45PM -0700, Joe Perches wrote:
> On Tue, 2017-08-22 at 18:40 -0700, Greg KH wrote:
> > On Thu, Aug 17, 2017 at 02:55:04PM +0300, [e-mail] wrote:
> > > From: Laurentiu Tudor <[e-mail]>
> > > 
> > > Throughout the driver we use == 0 / != 0 to check strcmp() returns except
> > > this place, so fix it.
> > 
> > You will just get someone else fixing it as it is not what checkpatch
> > recommends, so just leave it as-is please.
> 
> No.  That's not correct.
> 
> checkpatch does not make a recommendation about
> style use with the strcmp family of functions.

Ah, ok, nevermind then...

Laurentiu, can you resend this?

thanks,

greg k-h

Patch

diff --git a/drivers/staging/fsl-mc/bus/dprc-driver.c b/drivers/staging/fsl-mc/bus/dprc-driver.c
index 485abad..06df528 100644
--- a/drivers/staging/fsl-mc/bus/dprc-driver.c
+++ b/drivers/staging/fsl-mc/bus/dprc-driver.c
@@ -29,7 +29,7 @@  static bool fsl_mc_device_match(struct fsl_mc_device *mc_dev,
 				struct fsl_mc_obj_desc *obj_desc)
 {
 	return mc_dev->obj_desc.id == obj_desc->id &&
-	       !strcmp(mc_dev->obj_desc.type, obj_desc->type);
+	       strcmp(mc_dev->obj_desc.type, obj_desc->type) == 0;
 
 }