From patchwork Wed Aug 30 17:42:28 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wolfram Sang X-Patchwork-Id: 9930365 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 52F2760309 for ; Wed, 30 Aug 2017 17:42:59 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3F35B28711 for ; Wed, 30 Aug 2017 17:42:59 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 338EB28716; Wed, 30 Aug 2017 17:42:59 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id B718A28711 for ; Wed, 30 Aug 2017 17:42:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Ev2e26ENPbn6eg7cO0c8Q6Av2T1VyJ4OvEx9ArfIHOM=; b=PDB7vH6qaIxMp3OUSmYBoXR+Y GoicdiRHp7v1wAhEEfS7jCAgZMA8/fSWZlNu7XybHgxQu8gETFlDvRSrI9W831NxoU6yNap+V21I+ o8bYLn9E+ao2ILouVS5rhjIIEVQXxkf6MkzXOVJYlfFf7G7TDRBbu2PKGcbSf6grJlTZoMNl22/KZ TzIdB9Do32q3toi41AWHUlmTlPIq2DYcm0g15wisQPFkrr8SIGpdP63nt8FfbOapmlRhxdy4859Lc e3RZ+nrVH0iYZQhlmVymKU4ZkTNN38pBRAm1fJsDR+pgCgHGWoYDMgxfflOx97if6YYIZn68csBsS 2J8QBvkVA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1dn70w-0006FU-2y; Wed, 30 Aug 2017 17:42:54 +0000 Received: from sauhun.de ([88.99.104.3] helo=pokefinder.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1dn70s-0006DR-8p for linux-arm-kernel@lists.infradead.org; Wed, 30 Aug 2017 17:42:53 +0000 Received: from localhost (p54B33EA6.dip0.t-ipconnect.de [84.179.62.166]) by pokefinder.org (Postfix) with ESMTPSA id DA2292C2F9C; Wed, 30 Aug 2017 19:42:28 +0200 (CEST) Date: Wed, 30 Aug 2017 19:42:28 +0200 From: Wolfram Sang To: Javier Martinez Canillas Subject: Re: [RESEND PATCH v5 00/16] eeprom: at24: Add OF device ID table Message-ID: <20170830174228.sx5jgtxxy56zq47t@ninjato> References: <20170615185418.13980-1-javier@dowhile0.org> <20170731153009.xkjknygpmckv2pfp@ninjato> <20170828160121.gu4wf7jqu4ditksc@ninjato> <20170829084831.hsdok3ksi7anxzuc@ninjato> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170830_104250_484622_85A0A5A5 X-CRM114-Status: GOOD ( 17.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Catalin Marinas , Will Deacon , Russell King , Masahiro Yamada , Paul Mackerras , Linux I2C , Rob Herring , Michael Ellerman , Magnus Damm , Michal Simek , Andy Shevchenko , =?utf-8?B?U8O2cmVu?= Brinkmann , Benjamin Herrenschmidt , "devicetree@vger.kernel.org" , David Lechner , Sekhar Nori , Joachim Eastwood , Scott Wood , Simon Horman , Santosh Shilimkar , "linux-arm-kernel@lists.infradead.org" , Florian Larysch , Linux Kernel , Linux-Renesas , Dinh Nguyen , Rob Herring , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , linuxppc-dev Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP On Wed, Aug 30, 2017 at 06:19:02PM +0200, Javier Martinez Canillas wrote: > Hello Wolfram, > > On Tue, Aug 29, 2017 at 10:48 AM, Wolfram Sang wrote: > > > >> I don't have a DT based system at hand now, but I'll test it again and > >> let you know probably tomorrow. > > > > I will try again today, too. Thanks! > > > > Ok, I had some time to do some tests again. I used an ARM Chromebook > (Exynos Peach Pi) that has an I2C touchpad (Atmel maXTouch). I tried again as well and it still fails for me. > Tested the following cases: I think we should talk about the same case: Let me repeat what I did: 1) I added your patch "eeprom: at24: Add OF device ID table" 2) I added an EEPROM node to an I2C + eeprom@50 { + compatible = "renesas,24c01"; + reg = <0x50>; + }; -> no at24 binding to the device 3) I revert your patch -> at24 binding to the device I think you should be able to test this DTS snipplet even without a real eeprom. Especially after applying this to the at24 driver. Can you check this? Thanks, Wolfram diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c index 79c5c39be29cac..f9f547680c53db 100644 --- a/drivers/misc/eeprom/at24.c +++ b/drivers/misc/eeprom/at24.c @@ -805,11 +805,6 @@ static int at24_probe(struct i2c_client *client, const struct i2c_device_id *id) * Perform a one-byte test read to verify that the * chip is functional. */ - err = at24_read(at24, 0, &test_byte, 1); - if (err) { - err = -ENODEV; - goto err_clients; - } at24->nvmem_config.name = dev_name(&client->dev); at24->nvmem_config.dev = &client->dev;