From patchwork Sun Sep 3 13:16:19 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin King X-Patchwork-Id: 9936329 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 7D5BB6038C for ; Sun, 3 Sep 2017 13:17:49 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6DCD028650 for ; Sun, 3 Sep 2017 13:17:49 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 618A028657; Sun, 3 Sep 2017 13:17:49 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id F019128650 for ; Sun, 3 Sep 2017 13:17:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=H7p9qOtLPampr/G6/Wq3A85vHsA+gAJ4jdL0UG766hM=; b=Do2+jE7yCBlr7d 1W660hDoRUnMfMqK/AwiJP69qgyZusL//f75nBb8eOsSxDOyyb6xwJU+dfBny8SpjqIR2rdf2HDkt B56l8oOh0ys1g2VmPa9mv3tQvLprHs7IRj8uTM7L0T1JLMAsd4cfWwcpGyfBuQbXaePjZvhgawbLf 3UKOpMm16R632cqqFHN+KE8uCwosdZ+YV33astB1uUX2yMRTk8l3VN+2Cp8VTUdA3yYKhezLXGdm9 Gnfi0/X2qMqTYjLJStHDXxPCGG9OfzO2O/ep3oDt8324Z+lioxTrbqsTmIK0mKgjEuEZNt+xgtl3a LqE3r3G9rd+925qYAE5Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1doUlf-0006Cm-SL; Sun, 03 Sep 2017 13:16:51 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1doUlc-0006AM-Tz for linux-arm-kernel@lists.infradead.org; Sun, 03 Sep 2017 13:16:50 +0000 Received: from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.76) (envelope-from ) id 1doUlA-00064U-Az; Sun, 03 Sep 2017 13:16:20 +0000 From: Colin King To: Markus Mayer , bcm-kernel-feedback-list@broadcom.com, Zhang Rui , Eduardo Valentin , Brian Norris , Gregory Fong , Florian Fainelli , linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH][thermal-next] thermal: brcmstb: remove two redundant integer range checks Date: Sun, 3 Sep 2017 14:16:19 +0100 Message-Id: <20170903131619.6857-1-colin.king@canonical.com> X-Mailer: git-send-email 2.14.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170903_061649_118828_E2714410 X-CRM114-Status: UNSURE ( 8.55 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP From: Colin Ian King The comparisons for integer low on low > INT_MAX and also integer high > INT_MAX are never going to be true since an int type cannot be greater than INT_MAX. Remove these redundant checks. Detected by: CoverityScan CID#1455245, 1455248 ("Operands don't affect result (CONSTANT_EXPRESSION_RESULT)") Signed-off-by: Colin Ian King --- drivers/thermal/broadcom/brcmstb_thermal.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/thermal/broadcom/brcmstb_thermal.c b/drivers/thermal/broadcom/brcmstb_thermal.c index 87b8e7a86ee3..bcb3945feea6 100644 --- a/drivers/thermal/broadcom/brcmstb_thermal.c +++ b/drivers/thermal/broadcom/brcmstb_thermal.c @@ -278,8 +278,6 @@ static int brcmstb_set_trips(void *data, int low, int high) dev_dbg(priv->dev, "set trips %d <--> %d\n", low, high); if (low) { - if (low > INT_MAX) - low = INT_MAX; avs_tmon_set_trip_temp(priv, TMON_TRIP_TYPE_LOW, low); avs_tmon_trip_enable(priv, TMON_TRIP_TYPE_LOW, 1); } else { @@ -287,8 +285,6 @@ static int brcmstb_set_trips(void *data, int low, int high) } if (high < ULONG_MAX) { - if (high > INT_MAX) - high = INT_MAX; avs_tmon_set_trip_temp(priv, TMON_TRIP_TYPE_HIGH, high); avs_tmon_trip_enable(priv, TMON_TRIP_TYPE_HIGH, 1); } else {