From patchwork Wed Sep 6 20:52:01 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 9941309 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 2EB6560216 for ; Wed, 6 Sep 2017 20:54:38 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 200641FF61 for ; Wed, 6 Sep 2017 20:54:38 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 14AC6223A0; Wed, 6 Sep 2017 20:54:38 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_MED autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 8BE811FF61 for ; Wed, 6 Sep 2017 20:54:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=R66TCtHApVMYfEwFrp+ibCQeajheSILZHMFzvmBNYiM=; b=KvbxJo8I6hI9NFZqyd+gdr9pcD tlc3qCVF0U8gKuTycylBAUXy+gjq82/wYtP2u3TsawlB/6adu7LBNfoMFNz7husMLENCuAHAw9rlk H+ELdX1Ce78N8DfJukkhr8ABHONFBy3TR3jOfIRgITg4d1dpKNquYPPEjUdOY5YFQNvwwWeS7BRYl FdAFVUKixxjkSSvxinmPeLbh9uWxkHmj41H8dS89u2/ByvLvV/TPKKWxymvSh4vTiVWPAjVkw/xSN BQxgMmvskw4WKSWdwCCthuUrNRAJRbfq9k2CTWed0b5kYvZLg+pHU9Mbp1Ltke9xEjndFHsEUf8A3 lMAGuJjQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1dphLD-00057e-Uh; Wed, 06 Sep 2017 20:54:31 +0000 Received: from mail-pg0-x22d.google.com ([2607:f8b0:400e:c05::22d]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1dphJq-0003pU-MR for linux-arm-kernel@lists.infradead.org; Wed, 06 Sep 2017 20:53:24 +0000 Received: by mail-pg0-x22d.google.com with SMTP id t3so17308516pgt.0 for ; Wed, 06 Sep 2017 13:52:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=RGJYVtXUqZTktrTYKq6bxiqJyOQURV/m1l7oaoVlKuo=; b=a7HnsJHRhbVJC/phl+dgDtjvicHHNlVfRWM3Vvrhj/leapSuYVcQNmbhaJqnGiTUM+ 0ddYrfH8pbxXsTOR4i/AhSsKCrO5Sl15wZ4ryq9rBHXXqT+uG+HtDMrWaRWdHg5BTq7H 5ivmd9E/KD+UoHLc+MNXIWUZiWlOtpvIjik6Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=RGJYVtXUqZTktrTYKq6bxiqJyOQURV/m1l7oaoVlKuo=; b=KXdWbacTuTGAS20Zpkl8+Op73H7mI8dJLe5r3fRKMikZ21yN4dUs57/llNWOE0Z6v3 DkW2Amj9JGkhGl5ZxERPxHkHz3xbPpj3UUr2U4UsIl+7gb1xMKgs8dsgRK/L9QIm1K2j WWXwK5kjxHOY7WXBB1NiOFUcjzIcb3Rtj6AAExYDOGKx+TdHzfRPs/hmSJ4GHXl6vSnE JWe8ShGUtPTwztZYMn4E38NrwciV0wAFE162KI6+hkMng4csCGeEhuEv32YATpRTVjXc Vk5POQippA6FvfIVC1va3fzCJUEVKzLoFcd6/6u16Od/3eZkTnpBQWapd9G1SJig5Cpa EFaA== X-Gm-Message-State: AHPjjUjYNpl+BorRAlEmWv/TdrpFk1gRQr4io8TNQ2hGxbTAeV5CMnvf llK/tcaJTWndwdYC X-Google-Smtp-Source: ADKCNb5T5v2TVgx8pFiBs2Zns7pULjRtkGxzCYgMJV5mD95JjcESvUTZG603XHzF+RUGCJfv28B4Nw== X-Received: by 10.98.98.5 with SMTP id w5mr406166pfb.337.1504731165806; Wed, 06 Sep 2017 13:52:45 -0700 (PDT) Received: from tictac.mtv.corp.google.com ([172.22.112.154]) by smtp.gmail.com with ESMTPSA id r15sm870771pfj.41.2017.09.06.13.52.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 06 Sep 2017 13:52:45 -0700 (PDT) From: Douglas Anderson To: kishon@ti.com, heiko@sntech.de, zyw@rock-chips.com Subject: [PATCH 3/3] phy: rockchip-typec: Do the calibration more correctly Date: Wed, 6 Sep 2017 13:52:01 -0700 Message-Id: <20170906205201.16207-4-dianders@chromium.org> X-Mailer: git-send-email 2.14.1.581.gf28d330327-goog In-Reply-To: <20170906205201.16207-1-dianders@chromium.org> References: <20170906205201.16207-1-dianders@chromium.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170906_135310_695491_4E497EBE X-CRM114-Status: GOOD ( 13.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: shawnn@chromium.org, Douglas Anderson , dnschneid@chromium.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Calculate the calibration code as per the docs. The docs talk about reading and averaging the pullup and pulldown calibration codes. They also talk about adding in some adjustment codes. Let's do what the docs say. In practice this doesn't seem to matter a whole lot. On a device I tested the pullup and pulldown codes were nearly the same (0x23 and 0x24) and the adjustment codes were 0. Reviewed-by: Chris Zhong Signed-off-by: Douglas Anderson --- drivers/phy/rockchip/phy-rockchip-typec.c | 28 +++++++++++++++++++--------- 1 file changed, 19 insertions(+), 9 deletions(-) diff --git a/drivers/phy/rockchip/phy-rockchip-typec.c b/drivers/phy/rockchip/phy-rockchip-typec.c index b8696a7c45fb..e59983a82dcc 100644 --- a/drivers/phy/rockchip/phy-rockchip-typec.c +++ b/drivers/phy/rockchip/phy-rockchip-typec.c @@ -194,6 +194,7 @@ /* Use this for "n" in macros like "_MULT_XXX" to target the aux channel */ #define AUX_CH_LANE 8 + #define TX_ANA_CTRL_REG_1 (0x5020 << 2) #define TXDA_DP_AUX_EN BIT(15) @@ -560,24 +561,33 @@ static void tcphy_dp_aux_calibration(struct rockchip_typec_phy *tcphy) u16 val; u16 tx_ana_ctrl_reg_1; u16 tx_ana_ctrl_reg_2; - s32 pu_calib_code; - - /* disable txda_cal_latch_en for rewrite the calibration values */ - tx_ana_ctrl_reg_1 = readl(tcphy->base + TX_ANA_CTRL_REG_1); - tx_ana_ctrl_reg_1 &= ~TXDA_CAL_LATCH_EN; - writel(tx_ana_ctrl_reg_1, tcphy->base + TX_ANA_CTRL_REG_1); + s32 pu_calib_code, pd_calib_code; + s32 pu_adj, pd_adj; + u16 calib; /* - * read a resistor calibration code from CMN_TXPUCAL_CTRL[5:0] and - * write it to TX_DIG_CTRL_REG_2[5:0]. + * Calculate calibration code as per docs: use an average of the + * pull down and pull up. Then add in adjustments. */ val = readl(tcphy->base + CMN_TXPUCAL_CTRL); pu_calib_code = CMN_CALIB_CODE_POS(val); + val = readl(tcphy->base + CMN_TXPDCAL_CTRL); + pd_calib_code = CMN_CALIB_CODE_POS(val); + val = readl(tcphy->base + CMN_TXPU_ADJ_CTRL); + pu_adj = CMN_CALIB_CODE(val); + val = readl(tcphy->base + CMN_TXPD_ADJ_CTRL); + pd_adj = CMN_CALIB_CODE(val); + calib = (pu_calib_code + pd_calib_code) / 2 + pu_adj + pd_adj; + + /* disable txda_cal_latch_en for rewrite the calibration values */ + tx_ana_ctrl_reg_1 = readl(tcphy->base + TX_ANA_CTRL_REG_1); + tx_ana_ctrl_reg_1 &= ~TXDA_CAL_LATCH_EN; + writel(tx_ana_ctrl_reg_1, tcphy->base + TX_ANA_CTRL_REG_1); /* write the calibration, then delay 10 ms as sample in docs */ val = readl(tcphy->base + TX_DIG_CTRL_REG_2); val &= ~(TX_RESCAL_CODE_MASK << TX_RESCAL_CODE_OFFSET); - val |= pu_calib_code << TX_RESCAL_CODE_OFFSET; + val |= calib << TX_RESCAL_CODE_OFFSET; writel(val, tcphy->base + TX_DIG_CTRL_REG_2); usleep_range(10000, 10050);