From patchwork Mon Sep 11 11:05:22 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leif Lindholm X-Patchwork-Id: 9947109 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id C322E603F3 for ; Mon, 11 Sep 2017 11:06:48 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A115D28B56 for ; Mon, 11 Sep 2017 11:06:48 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9576D28B91; Mon, 11 Sep 2017 11:06:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 8A22F28B98 for ; Mon, 11 Sep 2017 11:06:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=b14CP/QU+IcxkQbqH6fDFvHURTMwZSb9pN85+5mhAwg=; b=kWi7VcAA19j4Wg dTRvO7aYqXK3A9JuumpHpf66WVqXB3H2aPXUmbHTSEt9rNL1zUzl/ZZFlaKOd5oQ7C35MqFJlVry3 umK56PnPavnBtD+8MpZx7KFiuJt+4tNfLE2UlhkdwxDRK+SfTk2UV2lTPgB4y9vkMrmtWeBOq8n+z ixQnJ/vgCniHOAzC/YOmykLGDBOXu5nZWqlALWQs/+AqBu5VqySnOgTdT9/Ep24l03fKkiqVa+z45 npA6xeDtjn7GzJHgMfvvGZqVICRd3BZyudXjnePIcltc5oJzfUcGoa8dw9JqZHTNKmUiXVSIM9SUu QuJDVWqGBE4bzlRhfgLg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1drMXJ-0008VA-70; Mon, 11 Sep 2017 11:05:53 +0000 Received: from mail-wr0-x22d.google.com ([2a00:1450:400c:c0c::22d]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1drMXF-0008R3-49 for linux-arm-kernel@lists.infradead.org; Mon, 11 Sep 2017 11:05:51 +0000 Received: by mail-wr0-x22d.google.com with SMTP id k20so13763422wre.4 for ; Mon, 11 Sep 2017 04:05:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=AF2reZF0f+bCZ1DLjGUsX2Pqv7MeTTlrmnsaclXRW1o=; b=k1LIUUXacUL2q3vE2wvIQZEGwFGaJND4+c1gk43VjKcb7ouh7Qcx8C5aNQwt+4jv3k rdSXvTUkAkNG47OI0uH7jXqCaOH9KpV+VC6Uv/zdGZJM2P2P0KrK98+ruh9c0Z6J1vlC i970hbppkhW/FuP7orpc9Sl+l6srbk81Q4fgk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=AF2reZF0f+bCZ1DLjGUsX2Pqv7MeTTlrmnsaclXRW1o=; b=VhPvdf8YzqctO9ZgxaYoL0N94xiUb2mQ9UlP92owIeY421w1SyS/hTezZYolMtzlPS XF+B3BEtXQ2iW6Gl22Jz6IwiMJ7UVumP1ziflk35bR+fENtIB6EMxt/ETRMaGIHVqp9B 14y5j2SGhIoDpLLGjuptVhwJNO95uxJYZlQiSGJSRmu07T2yY8uy8S4lz0hvux4UhngF uz50QfXIasAhJBeny2KGyODkEDR44T13wGBc3cHKV3PKrXZppt0bFsHH6eNyAd3jFmMs WZO7iJMrVERlKNR7zz5obbXk8NRPlFIOdczfFyNcxnESiA+dBjvrtOQtwzop1fDQ3Qoh EJMQ== X-Gm-Message-State: AHPjjUiucJuFPb1AMR1IePT817XREYWBqQUts5cmvKGCVQJXSYvjdNJN QkkGr+weARyl3cMf X-Google-Smtp-Source: ADKCNb5jB5ngoWCHEZp0/dU2EbWy1riBYK1JvgZs5z4ZNVRV3I4bpYG0W7hTF1orfnQVan0QUz8gyA== X-Received: by 10.223.168.105 with SMTP id l96mr8471733wrc.248.1505127925833; Mon, 11 Sep 2017 04:05:25 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id e186sm8971706wma.3.2017.09.11.04.05.24 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 11 Sep 2017 04:05:24 -0700 (PDT) Date: Mon, 11 Sep 2017 12:05:22 +0100 From: Leif Lindholm To: Andreas Schwab Subject: Re: [PATCH v11 2/4] ACPI: parse SPCR and enable matching console Message-ID: <20170911110522.vwgwnohjrrj2twtk@bivouac.eciton.net> References: <20160927151953.GB4371@kroah.com> <20160927205418.31529-1-aleksey.makarov@linaro.org> <20160927205418.31529-2-aleksey.makarov@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170911_040549_360879_6404C552 X-CRM114-Status: GOOD ( 14.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Zheng, Lv" , Kefeng Wang , Russell King , Peter Hurley , Graeme Gregory , Greg Kroah-Hartman , Jiri Slaby , "Rafael J . Wysocki" , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, Andy Shevchenko , Yury Norov , Christopher Covington , linux-serial@vger.kernel.org, Mark Salter , Al Stone , linux-arm-kernel@lists.infradead.org, Len Brown Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP I'm afraid Aleksey is no longer assigned to Linaro (you will probably have seen a bounce). On Mon, Sep 11, 2017 at 11:11:49AM +0200, Andreas Schwab wrote: > On Sep 27 2016, Aleksey Makarov wrote: > > > 'ARM Server Base Boot Requiremets' [1] mentions SPCR (Serial Port > > Console Redirection Table) [2] as a mandatory ACPI table that > > specifies the configuration of serial console. > > > > Defer initialization of DT earlycon until ACPI/DT decision is made. > > > > Parse the ACPI SPCR table, setup earlycon if required, > > enable specified console. > > How can I tell the kernel to ignore this table and use the console on > the command line instead? I guess we could just ignore the table completely if (console_set_on_cmdline) like its counterpart in of_console_check(). Like so (not tested beyond compile testing): Are you asking because you want to use a different console in a lab setup or because there are issues with SPCR on your platform? / Leif diff --git a/drivers/acpi/spcr.c b/drivers/acpi/spcr.c index 324b35bfe781..c3cf0f1ebb8f 100644 --- a/drivers/acpi/spcr.c +++ b/drivers/acpi/spcr.c @@ -96,6 +96,9 @@ int __init parse_spcr(bool earlycon) int baud_rate; int err; + if (console_set_on_cmdline) + return 0; + if (acpi_disabled) return -ENODEV;