From patchwork Tue Sep 19 19:04:56 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Corentin Labbe X-Patchwork-Id: 9960029 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 04E50601E9 for ; Tue, 19 Sep 2017 19:07:42 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E95C028531 for ; Tue, 19 Sep 2017 19:07:41 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id DDBF22883D; Tue, 19 Sep 2017 19:07:41 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FROM, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 7669A28531 for ; Tue, 19 Sep 2017 19:07:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=xCfEiD5V9Z5yCnWozMSQsXlx277EJYwl5ztLa3VbcLs=; b=UDP LGHyaPptmOddCvk40C49eO57LP7/fXXShLAuT4P/L277z1hnZ7Bcul2T/9oB/RPmS4F0OLGioA9Ex UZxNh4Aw0+EA+S13fEGFvqHRjQpk/6VIn/xgUSJmXEu3aQl4Q3C1qBSo6SV1wNophoWmBqQ5qCyHl UdBQWMbUaYH29eQMEYlfi89looOXG/rTkIsvqvYqXnk1i7zTRqyGDplatkMddyxcbIWTf9SRcpGTP uMHAVh422hiTlFGmwt+sif4l1CzFxGAnrmZeAUnngVn2OH1a6MJgfOb1NkhBX4Dajhvfi8oqS2Mh7 fu1UQyWMQNUHpYyJ5R9jZH2yn0Uq5tg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1duNrl-00077N-LT; Tue, 19 Sep 2017 19:07:29 +0000 Received: from mail-wr0-x242.google.com ([2a00:1450:400c:c0c::242]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1duNrh-000757-RO; Tue, 19 Sep 2017 19:07:27 +0000 Received: by mail-wr0-x242.google.com with SMTP id b9so295577wra.0; Tue, 19 Sep 2017 12:07:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=6AHbkOUP64/LW8PY4PfX/CpGS2ATDkUuq1rQFNvbWV0=; b=YBHfEjccdRfeGKtEXjSafqA53CON/X4Xh5AJRIQM8S78cVmzVTy5Ql/QzPqtdCSroz FpJRR8t8m8EOsgVdHoRcVnyVdsSmi/bfFJbmnQscSsq51wweSvBdv5wXhE6RAU/nNSvL Q9VJYihByD7/G1+aDNiOmYfj10ERFEPkt8DLBOtVdcsG413AA3B+4saVRirKn2Ja/w4C UTuvfl9JOS5A6NOA44kDaqVUDLxGxKDjqhrhr8RejQxy4Tx+A77Ne0b9cpqWStAQhu7d shDfL0Tf4Wol6OBA5swu8/E5OFu6Y5M3Eilyag2gElUM8jgpB/tj/upMSruL6FU5RsJz DVwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=6AHbkOUP64/LW8PY4PfX/CpGS2ATDkUuq1rQFNvbWV0=; b=LDC46QIxjZwP5GFrc46TBp3eUdx4JOrxnI9gNosIesf4zf90KieJpVz7zudE7Iir8/ +5uJrAz+4bcZwS5OQiuP28m5q4vveoML7w583rGONfxyHD71ihvwKFrL+AqEimt2sK8r fWVvm9SAT78ycsC6gL9QD15J/q+5TEEdx67IFsT9MN5E22tbAo6d2+t32hWcNtQSUkd8 q0znelsyIQjleUnfyPoLvTUo8uMkMvjxRy75K9FrsswP5/M0v0epJNmP0ZwMKgVBFouy y/bU6lln/wqzAjslw+BrHbSENwDhX3tiTd8RFnE94bWkEy6Vac5XsHnVayVcAPYQkInP BylA== X-Gm-Message-State: AHPjjUgVZGR4hjxPwK+LCg++pzeo2BxdDVCDDdbFewWxqM9cMcq0gT6d QHydaKu8rTatRan4w9IioISwJQ== X-Google-Smtp-Source: AOwi7QCmSoVDFlg2JhjRlq3Pkh39AQZp51NYRdfACvLWliAhoNBR3RSDbnRye8RUl9olhEPOdUqn/Q== X-Received: by 10.223.151.54 with SMTP id r51mr2450286wrb.207.1505848024336; Tue, 19 Sep 2017 12:07:04 -0700 (PDT) Received: from Red.local (LFbn-MAR-1-580-96.w90-118.abo.wanadoo.fr. [90.118.159.96]) by smtp.googlemail.com with ESMTPSA id w5sm16463wrg.65.2017.09.19.12.07.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 19 Sep 2017 12:07:03 -0700 (PDT) From: Corentin Labbe To: linus.walleij@linaro.org, f.fainelli@gmail.com, rjui@broadcom.com, sbranden@broadcom.com, bcm-kernel-feedback-list@broadcom.com, eric@anholt.net, stefan.wahren@i2se.com Subject: [PATCH] pinctrl: bcm2835: fix build warning in bcm2835_gpio_irq_handle_bank Date: Tue, 19 Sep 2017 21:04:56 +0200 Message-Id: <20170919190456.26522-1-clabbe.montjoie@gmail.com> X-Mailer: git-send-email 2.13.5 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170919_120726_046650_329A3EB3 X-CRM114-Status: UNSURE ( 9.45 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-gpio@vger.kernel.org, Corentin Labbe , linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP This patch fix the following build warning: drivers/pinctrl/bcm/pinctrl-bcm2835.c:376:15: warning: variable 'type' set but not used [-Wunused-but-set-variable] Furthermore, it is unused for a long time, at least since commit 85ae9e512f43 ("pinctrl: bcm2835: switch to GPIOLIB_IRQCHIP") where a "FIXME no clue why the code looks up the type here" was added. A year after, nobody answeered this question, so its time to remove it. Signed-off-by: Corentin Labbe Acked-by: Stefan Wahren --- drivers/pinctrl/bcm/pinctrl-bcm2835.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/pinctrl/bcm/pinctrl-bcm2835.c b/drivers/pinctrl/bcm/pinctrl-bcm2835.c index 0944310225db..ff782445dfb7 100644 --- a/drivers/pinctrl/bcm/pinctrl-bcm2835.c +++ b/drivers/pinctrl/bcm/pinctrl-bcm2835.c @@ -373,16 +373,12 @@ static void bcm2835_gpio_irq_handle_bank(struct bcm2835_pinctrl *pc, unsigned long events; unsigned offset; unsigned gpio; - unsigned int type; events = bcm2835_gpio_rd(pc, GPEDS0 + bank * 4); events &= mask; events &= pc->enabled_irq_map[bank]; for_each_set_bit(offset, &events, 32) { gpio = (32 * bank) + offset; - /* FIXME: no clue why the code looks up the type here */ - type = pc->irq_type[gpio]; - generic_handle_irq(irq_linear_revmap(pc->gpio_chip.irqdomain, gpio)); }