From patchwork Wed Sep 27 06:27:02 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Stanley X-Patchwork-Id: 9973181 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 10AA06037F for ; Wed, 27 Sep 2017 06:29:32 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 03878290A7 for ; Wed, 27 Sep 2017 06:29:32 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id EC394290AB; Wed, 27 Sep 2017 06:29:31 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_MED autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 71885290A7 for ; Wed, 27 Sep 2017 06:29:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=rPiaM07XqHohkOzrQZhk7iQG8jPwkdvC38aOXTsWeW4=; b=LNPvkFpcAvbRM2EeMDJWp/R3GJ yNwfYI7EOhWR40XHMBSI0/kxRiMnXZBoAeyQ3ebyY6/fS+2HGiUexQISI2lNApfFjSoNlBBn86MWx hSi4lZEbytHeQeyDR5Mz9MtMnIzfg4U7NWFbIsINGvSZk6LTmyOl1bXcKVVMh5HFP58VMi+ELjieA qBuwWQpGkQRxbVQeF40CcJ1B+YFiQezj4L7C6YXdGOzxsRrx9qhHeWxDoILDDylo8Bd1UELHtzPOJ MnxHO/bSPd5ucRBtOi2EgAMIcGeKnfT/E6sNJ7YY7YnbS9nY937AEh26vr9aQM5mOWwcXcuK1jkH3 RpKkFMAw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1dx5qV-00079B-VU; Wed, 27 Sep 2017 06:29:24 +0000 Received: from mail-pg0-x242.google.com ([2607:f8b0:400e:c05::242]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1dx5pj-0006EH-O1 for linux-arm-kernel@lists.infradead.org; Wed, 27 Sep 2017 06:28:50 +0000 Received: by mail-pg0-x242.google.com with SMTP id j16so8151814pga.2 for ; Tue, 26 Sep 2017 23:28:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=tabUEba9bihTTYuienB300wIGl8uqcC+QFp6tat38BY=; b=GcnMaiT1e43zFKF2ktzWUoSScjUGuDox0E49Md9Izs8Cw7sL7939e8CnfzEFaeRw8y i/nQNVoCCIvI8MSMzKKVYmHN1iWNcA6bWlWQKd0Qk/4nhGaMFAwl7SO01RTNSRDQHFtm +iQHRNgks1n6NFpOvZxFD+Qt/8qq5bddVyJh9RCzoz8YCteO0fuLjBKjkPue3QFFuy0X uPlSIjiNvDvcBzpzrWIvGEPDXq6TwhqngTGfP8yktF2NHm/qOjbn8GdI/Q+jE6lWulS3 /PtfY0ghHCroxO8zr/rKy8Ui0ec6H/qKDT5mKb4fYYgLLDtTXCiNbqQ1/I4NHa7o8I5L 9VZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=tabUEba9bihTTYuienB300wIGl8uqcC+QFp6tat38BY=; b=oF2os+ZY4VqzExYixiKnsSnbuiJ+9KHueYVgGtI6JDkp0gxOpfB1JmvJ53Afo+QuBe C0368sWwbZG1FOSs8Qj0vjSnqwTnhGfXojG5zl+q/3DHzy8eOvYsnPQepatbkcGcOPRv HL2WTEb16DW4wMjIknBR1sc3+TajFpN4WJCXTujP3rXB9PKMaCgXoJMsO3AvROzaN1hA G6hoITTtxQ27UGwLU1nu6OWwFcpcHaOGbyZV5R8bD41o7cDrp87+IrFj3/VwBW2GztPi Ig7XtZKykSvgATTkv34AAbDEr0q0Treou5ua2karPvQOMhGI2Ut+6nM+KVr9Q3VNhcx8 hhqA== X-Gm-Message-State: AHPjjUiu1VQlKnHsluEv8KA32JMj1IUxdKApJulhiIFLd2fbb+1m4x4z iUQ8q/Um3bwBqvTMzmLAhe8= X-Google-Smtp-Source: AOwi7QDv4l9iVCGqugPa63K4RRP30GaBJL8KqAPx/bIQUSjemCo9SHz0stDYntJUATI2AXdYHBxTXA== X-Received: by 10.159.218.6 with SMTP id v6mr361057plp.1.1506493693767; Tue, 26 Sep 2017 23:28:13 -0700 (PDT) Received: from aurora.jms.id.au ([203.0.153.9]) by smtp.gmail.com with ESMTPSA id v2sm18708482pgo.38.2017.09.26.23.28.07 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 26 Sep 2017 23:28:12 -0700 (PDT) Received: by aurora.jms.id.au (sSMTP sendmail emulation); Wed, 27 Sep 2017 15:58:04 +0930 From: Joel Stanley To: Lee Jones , Michael Turquette , Stephen Boyd Subject: [PATCH v3 5/5] clk: aspeed: Add reset controller Date: Wed, 27 Sep 2017 15:57:02 +0930 Message-Id: <20170927062702.11350-6-joel@jms.id.au> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20170927062702.11350-1-joel@jms.id.au> References: <20170927062702.11350-1-joel@jms.id.au> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170926_232836_408432_E43B36FF X-CRM114-Status: GOOD ( 15.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ryan Chen , Arnd Bergmann , Andrew Jeffery , Benjamin Herrenschmidt , linux-kernel@vger.kernel.org, Rick Altherr , Jeremy Kerr , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP There are some resets that are not associated with gates. These are represented by a reset controller. Signed-off-by: Joel Stanley --- v3: - Add named initalisers for the reset defines - Add define for ADC --- drivers/clk/clk-aspeed.c | 82 +++++++++++++++++++++++++++++++- include/dt-bindings/clock/aspeed-clock.h | 10 ++++ 2 files changed, 91 insertions(+), 1 deletion(-) diff --git a/drivers/clk/clk-aspeed.c b/drivers/clk/clk-aspeed.c index 42a69839d86e..4b08ad3b7960 100644 --- a/drivers/clk/clk-aspeed.c +++ b/drivers/clk/clk-aspeed.c @@ -17,6 +17,7 @@ #include #include #include +#include #include #include @@ -272,6 +273,68 @@ static const struct clk_ops aspeed_clk_gate_ops = { .is_enabled = aspeed_clk_is_enabled, }; +/** + * struct aspeed_reset - Aspeed reset controller + * @map: regmap to access the containing system controller + * @rcdev: reset controller device + */ +struct aspeed_reset { + struct regmap *map; + struct reset_controller_dev rcdev; +}; + +#define to_aspeed_reset(p) container_of((p), struct aspeed_reset, rcdev) + +static const u8 aspeed_resets[] = { + [ASPEED_RESET_XDMA] = 25, + [ASPEED_RESET_MCTP] = 24, + [ASPEED_RESET_ADC] = 23, + [ASPEED_RESET_JTAG_MASTER] = 22, + [ASPEED_RESET_MIC] = 18, + [ASPEED_RESET_PWM] = 9, + [ASPEED_RESET_PCIVGA] = 8, + [ASPEED_RESET_I2C] = 2, + [ASPEED_RESET_AHB] = 1, +}; + +static int aspeed_reset_deassert(struct reset_controller_dev *rcdev, + unsigned long id) +{ + struct aspeed_reset *ar = to_aspeed_reset(rcdev); + u32 rst = BIT(aspeed_resets[id]); + + return regmap_update_bits(ar->map, ASPEED_RESET_CTRL, rst, 0); +} + +static int aspeed_reset_assert(struct reset_controller_dev *rcdev, + unsigned long id) +{ + struct aspeed_reset *ar = to_aspeed_reset(rcdev); + u32 rst = BIT(aspeed_resets[id]); + + return regmap_update_bits(ar->map, ASPEED_RESET_CTRL, rst, rst); +} + +static int aspeed_reset_status(struct reset_controller_dev *rcdev, + unsigned long id) +{ + struct aspeed_reset *ar = to_aspeed_reset(rcdev); + u32 val, rst = BIT(aspeed_resets[id]); + int ret; + + ret = regmap_read(ar->map, ASPEED_RESET_CTRL, &val); + if (ret) + return ret; + + return !!(val & rst); +} + +static const struct reset_control_ops aspeed_reset_ops = { + .assert = aspeed_reset_assert, + .deassert = aspeed_reset_deassert, + .status = aspeed_reset_status, +}; + static struct clk_hw *aspeed_clk_hw_register_gate(struct device *dev, const char *name, const char *parent_name, unsigned long flags, struct regmap *map, u8 clock_idx, u8 reset_idx, @@ -313,10 +376,11 @@ static int __init aspeed_clk_probe(struct platform_device *pdev) { const struct aspeed_clk_soc_data *soc_data; struct device *dev = &pdev->dev; + struct aspeed_reset *ar; struct regmap *map; struct clk_hw *hw; u32 val, rate; - int i; + int i, ret; map = syscon_node_to_regmap(dev->of_node); if (IS_ERR(map)) { @@ -324,6 +388,22 @@ static int __init aspeed_clk_probe(struct platform_device *pdev) return PTR_ERR(map); } + ar = devm_kzalloc(dev, sizeof(*ar), GFP_KERNEL); + if (!ar) + return -ENOMEM; + + ar->map = map; + ar->rcdev.owner = THIS_MODULE; + ar->rcdev.nr_resets = ARRAY_SIZE(aspeed_resets); + ar->rcdev.ops = &aspeed_reset_ops; + ar->rcdev.of_node = dev->of_node; + + ret = devm_reset_controller_register(dev, &ar->rcdev); + if (ret) { + dev_err(dev, "could not register reset controller\n"); + return ret; + } + /* SoC generations share common layouts but have different divisors */ soc_data = of_device_get_match_data(&pdev->dev); diff --git a/include/dt-bindings/clock/aspeed-clock.h b/include/dt-bindings/clock/aspeed-clock.h index 4a99421d77c8..8e19646d8025 100644 --- a/include/dt-bindings/clock/aspeed-clock.h +++ b/include/dt-bindings/clock/aspeed-clock.h @@ -39,4 +39,14 @@ #define ASPEED_NUM_CLKS 35 +#define ASPEED_RESET_XDMA 0 +#define ASPEED_RESET_MCTP 1 +#define ASPEED_RESET_ADC 2 +#define ASPEED_RESET_JTAG_MASTER 3 +#define ASPEED_RESET_MIC 4 +#define ASPEED_RESET_PWM 5 +#define ASPEED_RESET_PCIVGA 6 +#define ASPEED_RESET_I2C 7 +#define ASPEED_RESET_AHB 8 + #endif