From patchwork Sat Sep 30 03:40:54 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Berger X-Patchwork-Id: 9979099 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 973CD6037F for ; Sat, 30 Sep 2017 03:44:43 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 87D2D298D9 for ; Sat, 30 Sep 2017 03:44:43 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7CA23298DB; Sat, 30 Sep 2017 03:44:43 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FROM, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 19A3B298D9 for ; Sat, 30 Sep 2017 03:44:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=kPCmeTzUcaFSV1mnyuz3gX22PA3OXZmLSaN6Z54VcD8=; b=VD9OqHp6ZQjwaEsEmjv7qidKz/ GGZuF33j2S4ESmu1Bx0Z3F11ZpTDhRRoPcXo3oF8ZV4kgd4aodmjYKCW4rxJ26jkGOfUpxmKo4jVH rhShN8gRjXb6soppj3wQIIiEeRaDBRHAzMtj7UppUpg3X5SgXaozbNYA7wWd/90cK+qCuEVrbiP+R 4IkFJKN2caysbRZqpzpN5iB/wmy3p5YlrrnTAS+qqlV4HdQDu3FwT3iwu4HnH/Spyh+ivtBG+KeiO EJAslS9OfxL3z3bAhAg+lrVqgpIxLmi8ra7uKx9xh5MgrjR5Jw+51DuhFsuXRbWOeuB/E1+PnR35u rxmVVh+Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1dy8hh-0007VI-8Y; Sat, 30 Sep 2017 03:44:37 +0000 Received: from mail-qt0-x243.google.com ([2607:f8b0:400d:c0d::243]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1dy8fK-0005JY-TG for linux-arm-kernel@lists.infradead.org; Sat, 30 Sep 2017 03:42:13 +0000 Received: by mail-qt0-x243.google.com with SMTP id l25so1839111qtf.13 for ; Fri, 29 Sep 2017 20:41:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=gaWBELiuW0RU1+X84wr6VA9h4E75YU4xrAobJbpqriE=; b=pKBlxyW8RVBYN9whNBnDUaJ3kJCuzl3a+efD9NTLldvZMMKV4sgoDCTyRBxz6a2cY5 EZHGyOAXFJiOmOg4u4FwuEvFZMsNg74QhOjGxDyhVrxVejT/7gWFqz/YhWtLVWC2j4/Y 55bV00job3uaF3aLBM9yXXjM+00yQTAamdOjB6Jpl/rC/Xvj+wQwQLrLL+ARPSwbyvuq jGfLoW6Y//X2z6+knjLVD7rVD66x0rsmFf7spri0fn0PJ8VDA82A2VlumGwwdkaaa2IT 2aiOpGzxy5ISjpGAde7WKtCl1muIGcNRU+nu1FkSxorMlPl4o60BC9iN+7T6x2lkvDQG aXnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=gaWBELiuW0RU1+X84wr6VA9h4E75YU4xrAobJbpqriE=; b=lrPAS7nE1Z51LheANZH2L3v/iYP1Ac1i8ffSE4nN52upSW5753NXF5aEWc2kyLlzpB bkiM8O1QoM4hluqHQGAhHWNz65ZTLOP/KkLN67TjR1etRqfC2eEEN/7SjP9pmtCTgnVj aF10R9Pw02kXwC1uknnFtLuK8+IHRjAb+otFQJD8Ed0qxx2omYJ3foXPOcaHFsmbL4ID FbtOUw3dBePvmW1N2oO5oW5PKZpxbaORoa+L4HL4zMWJnmd9+tdJI76qWpo+/iJM5iPM Gy3HnLuoanS9zikbtXXwotoPODA9d9AvtH6S577frkZTuptOKXt1WmXEZ+z/hn6kUBFC pAPw== X-Gm-Message-State: AMCzsaXIVX7RHhiQLqu0lr5x4LmB23mgUeevqyQu64zy6QmXjh+GRopF YYeVxdJvivtEvM0onsT/cx0= X-Google-Smtp-Source: AOwi7QDmbCEPJoRtBeaowBa9RBp+W7DBk1lM6j+CmygX56hxONBxD7XxxoC8M+u4RXpvx5QxiN22Ig== X-Received: by 10.237.34.228 with SMTP id q33mr9266510qtc.278.1506742909471; Fri, 29 Sep 2017 20:41:49 -0700 (PDT) Received: from stb-bld-02.irv.broadcom.com ([192.19.255.250]) by smtp.gmail.com with ESMTPSA id 4sm3574693qke.50.2017.09.29.20.41.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 29 Sep 2017 20:41:49 -0700 (PDT) From: Doug Berger To: Gregory Fong Subject: [PATCH 4/7] gpio: brcmstb: correct the configuration of level interrupts Date: Fri, 29 Sep 2017 20:40:54 -0700 Message-Id: <20170930034057.15166-5-opendmb@gmail.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20170930034057.15166-1-opendmb@gmail.com> References: <20170930034057.15166-1-opendmb@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170929_204211_340017_3F3633D5 X-CRM114-Status: GOOD ( 11.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Florian Fainelli , Linus Walleij , linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Doug Berger , bcm-kernel-feedback-list@broadcom.com, Brian Norris , linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP This commit corrects a bug when configuring the GPIO hardware for IRQ_TYPE_LEVEL_LOW and IRQ_TYPE_LEVEL_HIGH interrupt types. The hardware is now correctly configured to support those types. Fixes: 19a7b6940b78 ("gpio: brcmstb: Add interrupt and wakeup source support") Signed-off-by: Doug Berger Acked-by: Gregory Fong --- drivers/gpio/gpio-brcmstb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-brcmstb.c b/drivers/gpio/gpio-brcmstb.c index c186141927bb..0418cb266586 100644 --- a/drivers/gpio/gpio-brcmstb.c +++ b/drivers/gpio/gpio-brcmstb.c @@ -137,13 +137,13 @@ static int brcmstb_gpio_irq_set_type(struct irq_data *d, unsigned int type) switch (type) { case IRQ_TYPE_LEVEL_LOW: - level = 0; + level = mask; edge_config = 0; edge_insensitive = 0; break; case IRQ_TYPE_LEVEL_HIGH: level = mask; - edge_config = 0; + edge_config = mask; edge_insensitive = 0; break; case IRQ_TYPE_EDGE_FALLING: