| Message ID | 20170930034057.15166-6-opendmb@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Doug, On Fri, Sep 29, 2017 at 8:40 PM, Doug Berger <opendmb@gmail.com> wrote: > Mask the GPIO interrupt while its type is being changed, just in case > it can prevent a spurious interrupt. "Just in case"? I don't have access to hardware documentation for this anymore, but I'd expect to some stronger claim that the hardware actually requires masking before changing the trigger type. If you can quote documentation for this or explain an actual problem seen, that would be good. > > Signed-off-by: Doug Berger <opendmb@gmail.com> > --- > drivers/gpio/gpio-brcmstb.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpio/gpio-brcmstb.c b/drivers/gpio/gpio-brcmstb.c > index 0418cb266586..e2fff559c1ca 100644 > --- a/drivers/gpio/gpio-brcmstb.c > +++ b/drivers/gpio/gpio-brcmstb.c > @@ -363,7 +363,9 @@ static int brcmstb_gpio_irq_setup(struct platform_device *pdev, > bank->irq_chip.irq_set_type = brcmstb_gpio_irq_set_type; > > /* Ensures that all non-wakeup IRQs are disabled at suspend */ > - bank->irq_chip.flags = IRQCHIP_MASK_ON_SUSPEND; > + /* and that interrupts are masked when changing their type */ This doesn't follow the kernel multi-line comment style, please adjust. > + bank->irq_chip.flags = IRQCHIP_MASK_ON_SUSPEND | > + IRQCHIP_SET_TYPE_MASKED; > > if (IS_ENABLED(CONFIG_PM_SLEEP) && !priv->parent_wake_irq && > of_property_read_bool(np, "wakeup-source")) { > -- > 2.14.1 > Thanks, Gregory
On 10/03/2017 07:10 PM, Gregory Fong wrote: > Hi Doug, > > On Fri, Sep 29, 2017 at 8:40 PM, Doug Berger <opendmb@gmail.com> wrote: >> Mask the GPIO interrupt while its type is being changed, just in case >> it can prevent a spurious interrupt. > > "Just in case"? I don't have access to hardware documentation for > this anymore, but I'd expect to some stronger claim that the hardware > actually requires masking before changing the trigger type. If you > can quote documentation for this or explain an actual problem seen, > that would be good. Well spotted ;). This was a protectionist change added at the request of a user of the driver. I believe that it is superfluous and I suppose that belief leaked through in the language of my comment. In actuality, the GPIO APIs don't make provision for clearing GPIO interrupts before enabling them so this masking is really only a deferral of a spurious interrupt if one is triggered by changes in the hardware programming. I can strike this from the upstream submission and save a couple lines of source code (after IRQCHIP_MASK_ON_SUSPEND goes away) if you prefer. > >> >> Signed-off-by: Doug Berger <opendmb@gmail.com> >> --- >> drivers/gpio/gpio-brcmstb.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/gpio/gpio-brcmstb.c b/drivers/gpio/gpio-brcmstb.c >> index 0418cb266586..e2fff559c1ca 100644 >> --- a/drivers/gpio/gpio-brcmstb.c >> +++ b/drivers/gpio/gpio-brcmstb.c >> @@ -363,7 +363,9 @@ static int brcmstb_gpio_irq_setup(struct platform_device *pdev, >> bank->irq_chip.irq_set_type = brcmstb_gpio_irq_set_type; >> >> /* Ensures that all non-wakeup IRQs are disabled at suspend */ >> - bank->irq_chip.flags = IRQCHIP_MASK_ON_SUSPEND; >> + /* and that interrupts are masked when changing their type */ > > This doesn't follow the kernel multi-line comment style, please adjust. > >> + bank->irq_chip.flags = IRQCHIP_MASK_ON_SUSPEND | >> + IRQCHIP_SET_TYPE_MASKED; >> >> if (IS_ENABLED(CONFIG_PM_SLEEP) && !priv->parent_wake_irq && >> of_property_read_bool(np, "wakeup-source")) { >> -- >> 2.14.1 >> > > Thanks, > Gregory > Thanks again, Doug
On Tue, Oct 3, 2017 at 7:22 PM, Doug Berger <opendmb@gmail.com> wrote: > On 10/03/2017 07:10 PM, Gregory Fong wrote: >> Hi Doug, >> >> On Fri, Sep 29, 2017 at 8:40 PM, Doug Berger <opendmb@gmail.com> wrote: >>> Mask the GPIO interrupt while its type is being changed, just in case >>> it can prevent a spurious interrupt. >> >> "Just in case"? I don't have access to hardware documentation for >> this anymore, but I'd expect to some stronger claim that the hardware >> actually requires masking before changing the trigger type. If you >> can quote documentation for this or explain an actual problem seen, >> that would be good. > > Well spotted ;). This was a protectionist change added at the request > of a user of the driver. I believe that it is superfluous and I suppose > that belief leaked through in the language of my comment. > > In actuality, the GPIO APIs don't make provision for clearing GPIO > interrupts before enabling them so this masking is really only a > deferral of a spurious interrupt if one is triggered by changes in the > hardware programming. Indeed. If the hardware is behaving in unexpected ways that would be a whole different kind of problem. > > I can strike this from the upstream submission and save a couple lines > of source code (after IRQCHIP_MASK_ON_SUSPEND goes away) if you prefer. > Yes, please remove. Thanks, Gregory
diff --git a/drivers/gpio/gpio-brcmstb.c b/drivers/gpio/gpio-brcmstb.c index 0418cb266586..e2fff559c1ca 100644 --- a/drivers/gpio/gpio-brcmstb.c +++ b/drivers/gpio/gpio-brcmstb.c @@ -363,7 +363,9 @@ static int brcmstb_gpio_irq_setup(struct platform_device *pdev, bank->irq_chip.irq_set_type = brcmstb_gpio_irq_set_type; /* Ensures that all non-wakeup IRQs are disabled at suspend */ - bank->irq_chip.flags = IRQCHIP_MASK_ON_SUSPEND; + /* and that interrupts are masked when changing their type */ + bank->irq_chip.flags = IRQCHIP_MASK_ON_SUSPEND | + IRQCHIP_SET_TYPE_MASKED; if (IS_ENABLED(CONFIG_PM_SLEEP) && !priv->parent_wake_irq && of_property_read_bool(np, "wakeup-source")) {
Mask the GPIO interrupt while its type is being changed, just in case it can prevent a spurious interrupt. Signed-off-by: Doug Berger <opendmb@gmail.com> --- drivers/gpio/gpio-brcmstb.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)