| Message ID | 20171021082529.31351-2-matthias.bgg@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Sat, 2017-10-21 at 10:25 +0200, Matthias Brugger wrote: > When adding the MT6380 compatible, the sentinel for of_device_id was > deleted, which leades to the following compiler error: > FATAL: drivers/soc/mediatek/mtk-pmic-wrap: struct of_device_id is not terminated with a NULL entry! > > Fix this by adding the sentinel again. > > Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com> > --- > drivers/soc/mediatek/mtk-pmic-wrap.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c > index 912edf93c192..e9e054a15b7d 100644 > --- a/drivers/soc/mediatek/mtk-pmic-wrap.c > +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c > @@ -1380,6 +1380,7 @@ static const struct of_device_id of_slave_match_tbl[] = { > }, { > .compatible = "mediatek,mt6397", > .data = &pmic_mt6397, > + }, { > /* sentinel */ > } > }; Thanks for patching the mistaken edit I made. Acked-by: Sean Wang <sean.wang@mediatek.com>
On 10/22/2017 06:23 AM, Sean Wang wrote: > On Sat, 2017-10-21 at 10:25 +0200, Matthias Brugger wrote: >> When adding the MT6380 compatible, the sentinel for of_device_id was >> deleted, which leades to the following compiler error: >> FATAL: drivers/soc/mediatek/mtk-pmic-wrap: struct of_device_id is not terminated with a NULL entry! >> >> Fix this by adding the sentinel again. >> >> Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com> >> --- >> drivers/soc/mediatek/mtk-pmic-wrap.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c >> index 912edf93c192..e9e054a15b7d 100644 >> --- a/drivers/soc/mediatek/mtk-pmic-wrap.c >> +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c >> @@ -1380,6 +1380,7 @@ static const struct of_device_id of_slave_match_tbl[] = { >> }, { >> .compatible = "mediatek,mt6397", >> .data = &pmic_mt6397, >> + }, { >> /* sentinel */ >> } >> }; > > Thanks for patching the mistaken edit I made. > > Acked-by: Sean Wang <sean.wang@mediatek.com> > > Thanks, both patches pushed to v4.14-next/soc
diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c index 912edf93c192..e9e054a15b7d 100644 --- a/drivers/soc/mediatek/mtk-pmic-wrap.c +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c @@ -1380,6 +1380,7 @@ static const struct of_device_id of_slave_match_tbl[] = { }, { .compatible = "mediatek,mt6397", .data = &pmic_mt6397, + }, { /* sentinel */ } };
When adding the MT6380 compatible, the sentinel for of_device_id was deleted, which leades to the following compiler error: FATAL: drivers/soc/mediatek/mtk-pmic-wrap: struct of_device_id is not terminated with a NULL entry! Fix this by adding the sentinel again. Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com> --- drivers/soc/mediatek/mtk-pmic-wrap.c | 1 + 1 file changed, 1 insertion(+)