staging: fsl-mc: fix uninitialized variable use

Commit Message

Laurentiu Tudor Nov. 27, 2017, 9:01 a.m. UTC

From: Laurentiu Tudor <[e-mail]>

Fix this warning triggering on a powerpc build:
warning: 'error' may be used uninitialized in this function [-Wmaybe-uninitialized]

Signed-off-by: Laurentiu Tudor <[e-mail]>
---
 drivers/staging/fsl-mc/bus/fsl-mc-bus.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Greg KH Nov. 27, 2017, 9:08 a.m. UTC | #1

On Mon, Nov 27, 2017 at 11:01:34AM +0200, [e-mail] wrote:
> From: Laurentiu Tudor <[e-mail]>
> 
> Fix this warning triggering on a powerpc build:
> warning: 'error' may be used uninitialized in this function [-Wmaybe-uninitialized]
> 
> Signed-off-by: Laurentiu Tudor <[e-mail]>
> ---

You forgot a reported-by line :(

And I beat you by about 30 minutes to this patch, sorry about that.

Next time always test-build your patches...

thanks,

greg k-h

Laurentiu Tudor Nov. 27, 2017, 9:31 a.m. UTC | #2

On 11/27/2017 11:08 AM, Greg KH wrote:
> On Mon, Nov 27, 2017 at 11:01:34AM +0200, [e-mail] wrote:
>> From: Laurentiu Tudor <[e-mail]>
>>
>> Fix this warning triggering on a powerpc build:
>> warning: 'error' may be used uninitialized in this function [-Wmaybe-uninitialized]
>>
>> Signed-off-by: Laurentiu Tudor <[e-mail]>
>> ---
>
> You forgot a reported-by line :(
>
> And I beat you by about 30 minutes to this patch, sorry about that.

Sorry, I guess I'm slow on mondays before having my morning coffee. :-(

> Next time always test-build your patches...

I did but it didn't show up on my version of powerpc toolchain (gcc 
4.8.1). Maybe it's too old ...

---
Best Regards, Laurentiu

Greg KH Nov. 27, 2017, 9:44 a.m. UTC | #3

On Mon, Nov 27, 2017 at 09:31:21AM +0000, Laurentiu Tudor wrote:
> 
> 
> On 11/27/2017 11:08 AM, Greg KH wrote:
> > On Mon, Nov 27, 2017 at 11:01:34AM +0200, [e-mail] wrote:
> >> From: Laurentiu Tudor <[e-mail]>
> >>
> >> Fix this warning triggering on a powerpc build:
> >> warning: 'error' may be used uninitialized in this function [-Wmaybe-uninitialized]
> >>
> >> Signed-off-by: Laurentiu Tudor <[e-mail]>
> >> ---
> >
> > You forgot a reported-by line :(
> >
> > And I beat you by about 30 minutes to this patch, sorry about that.
> 
> Sorry, I guess I'm slow on mondays before having my morning coffee. :-(
> 
> > Next time always test-build your patches...
> 
> I did but it didn't show up on my version of powerpc toolchain (gcc 
> 4.8.1). Maybe it's too old ...

Yes, that's really old, please update to something more "modern" :)

thanks,

greg k-h

Dan Carpenter Nov. 28, 2017, 2:13 p.m. UTC | #4

On Mon, Nov 27, 2017 at 09:31:21AM +0000, Laurentiu Tudor wrote:
> I did but it didn't show up on my version of powerpc toolchain (gcc 
> 4.8.1). Maybe it's too old ...
> 

Smatch has new uninitialized variable warnings these days.  In theory,
it should be smarter and more strict than GCC.

regards,
dan carpenter

Patch

diff --git a/drivers/staging/fsl-mc/bus/fsl-mc-bus.c b/drivers/staging/fsl-mc/bus/fsl-mc-bus.c
index f84bc14..f15bab3 100644
--- a/drivers/staging/fsl-mc/bus/fsl-mc-bus.c
+++ b/drivers/staging/fsl-mc/bus/fsl-mc-bus.c
@@ -570,6 +570,7 @@  int fsl_mc_device_add(struct fsl_mc_obj_desc *obj_desc,
 	mc_dev->dev.release = fsl_mc_device_release;
 	mc_dev->dev.type = fsl_mc_get_device_type(obj_desc->type);
 	if (!mc_dev->dev.type) {
+		error = -ENODEV;
 		dev_err(parent_dev, "unknown device type %s\n", obj_desc->type);
 		goto error_cleanup_dev;
 	}