From patchwork Thu Nov 30 12:52:17 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Niklas_S=C3=B6derlund?= X-Patchwork-Id: 10084785 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 2794160234 for ; Thu, 30 Nov 2017 12:52:48 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1494B29DF9 for ; Thu, 30 Nov 2017 12:52:48 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 093BA29F89; Thu, 30 Nov 2017 12:52:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 828C329DF9 for ; Thu, 30 Nov 2017 12:52:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wq+EMRq8jRCOZvHjxoWyzTRMdUihljZP1Q1fenGIXqI=; b=ohdrP0lm14+hB5 ore+DBpQ0CLxr0P6g5kKEVsdoD+Cpm6WX3UlHmMxdMyaT+7y0qlsOGoNMciFtsSof+cb7jKnFnVbs /+FTqz0bw9139q0dAhJdqN0z2abqkyGeROxRcW6y2Kc/GvwAJYfeFe1dg+4bGbYhscZMLA6S/oFgi 35zIv7L3wGWZ7Hf1Y49D1cE7Q60bssyEfOaxQElQE8zr98jqzGmXqN8D7j66JtfqUAxU5NvkDKYVe 6IDklDNp4z0VNEp061WyI12O2iUQV82sldDxHtlQo/FEiLT22LLn+IfkDLNpmfTDfsyec2Wfzu3Sf 86CyH51MgCz6ltCH491w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1eKOKc-00030H-2p; Thu, 30 Nov 2017 12:52:46 +0000 Received: from mail-lf0-x244.google.com ([2a00:1450:4010:c07::244]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1eKOKY-0002zd-0K for linux-arm-kernel@lists.infradead.org; Thu, 30 Nov 2017 12:52:44 +0000 Received: by mail-lf0-x244.google.com with SMTP id a12so7770943lfe.4 for ; Thu, 30 Nov 2017 04:52:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ragnatech-se.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=CKhBn1Qxir/AcFvzrWEwAEPMHif9SparDRFv9vAkmbg=; b=CfBs4kn/qqnlFAmLlhA1YneuicIyH+u1Cui97szjxh3fiTND0c7AbwUdbbbOifcS62 LwL2B4k6cQ4vlbtbSaCqF436CAHTZMP0wxV+va2VtjkUh5MBnyDZCx0o82oPwKy13Ci+ AG8pIwlNuhYfP3qcg8uGuiw1fgiLh2fyBkh6Is5KIj2RRtV2RbcC1kISoeI1eDSbA81P 137jS2QK3AHxn2i4UtGCQ3Ob5kibbNV7DwVMFne9cSYq+iFIlYVW4vjRc3YwUepocQ55 +gPCserY4iAFIHmiz82ULHqn82VwcYYkqFE9I51qfyepFgnoms9f1y3JLamvEgfbyyFU /qHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=CKhBn1Qxir/AcFvzrWEwAEPMHif9SparDRFv9vAkmbg=; b=LRJh6K9/ACSctXbXgUUKvL+SEEUZIaKYP3H3qzkKJ/dJdp3N1tu/VKfkeBYo1p+ldc UskSjb/M3xHmqcChahwb3BFn3ucpF0kGhX/jvfrYtPopgpDCunx65ikAgmN3LNh595uq 9V2hL8bx/ZOk+9yrG5eW0XPqV8Z008k4kRt2OcRGKqs4bFGWJ/Zag9nYwqaQTuLE5Ips I4HVlDazrynms+E1q8Rv4LvOzV/sOmDmQ83d+lV6E+IYpf7IG9/XNsKAA+5MIw3DowkN FJIDQvR4/01rlpX5BsrDvctz99OZseXjIdIo4nspDG1tcjxOJVl9VJUbkH5+delNhUYM izIQ== X-Gm-Message-State: AJaThX7fC/WvGNeN2xSX5zc2XCVTC8B3s/U8wyGIr7OppH4hqR1T0PKm fiM0zwXZ74teTswu7jkklmNiHA== X-Google-Smtp-Source: AGs4zMZJOnb1dtAD+Jzf2kiKLae5ct2rdt2wTCan7jEK8C6N3XLJkNxJil7O3Xxer736ktN4a0OFPg== X-Received: by 10.46.29.67 with SMTP id d64mr3200174ljd.139.1512046339209; Thu, 30 Nov 2017 04:52:19 -0800 (PST) Received: from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99]) by smtp.gmail.com with ESMTPSA id g82sm843914ljg.57.2017.11.30.04.52.18 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 30 Nov 2017 04:52:18 -0800 (PST) Date: Thu, 30 Nov 2017 13:52:17 +0100 From: Niklas =?iso-8859-1?Q?S=F6derlund?= To: Simon Horman Subject: Re: [PATCH/RFT renesas-devel] arm64: dts: ulcb: Enable NFS root Message-ID: <20171130125217.GE22365@bigcity.dyn.berto.se> References: <1493717048-10740-1-git-send-email-horms+renesas@verge.net.au> <20171130094354.6pktdlcuc3gettji@verge.net.au> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20171130094354.6pktdlcuc3gettji@verge.net.au> User-Agent: Mutt/1.9.0 (2017-09-02) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20171130_045242_329145_E84EA745 X-CRM114-Status: GOOD ( 18.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux-Renesas , Magnus Damm , Geert Uytterhoeven , "linux-arm-kernel@lists.infradead.org" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Simon, On 2017-11-30 10:43:55 +0100, Simon Horman wrote: > On Tue, May 02, 2017 at 11:27:58AM +0200, Geert Uytterhoeven wrote: > > Hi Simon, > > > > On Tue, May 2, 2017 at 11:24 AM, Simon Horman > > wrote: > > > Enable NFS root on the r8a7795/h3ulcb and r8a7796/m3ulcb > > > as per: > > > * commit b2407c566ba29215 ("arm64: dts: r8a7795: enable nfs root on Salvator-X board"). > > > * commit 742a9dfb90f0 ("arm64: dts: r8a7796: salvator-x: Enable NFS root") > > > > > > Also set ignore_loglevel rw as boot args as is the case for the boards > > > for the boards for other Renesas ARM/ARM64 based SoCs. > > > > s/for the boards// > > > > > Signed-off-by: Simon Horman > > > > Reviewed-by: Geert Uytterhoeven > > > > Gr{oetje,eeting}s, > > Sergei has pointed out that bootargs has seems to have effect on ARM64 > kernels. So I think this patch should be withdrawn and we should consider > removing bootargs from those ARM64 boards where it is present. > I don't think this is true. I just added a argument to bootargs to salvator-common.dtsi for some hack testing and it took effect. Tested on-top of latest renesas-drivers and H3 ES2.0. >>> DIFF <<< # cat /sys/firmware/devicetree/base/chosen/bootargs ignore_loglevel rw root=/dev/nfs ip=dhcp adv748x.txbvc=1 And the module parameter had the expected effect on the adv7482x driver. Is there another issue here which I'm missing? diff --git a/arch/arm64/boot/dts/renesas/salvator-common.dtsi b/arch/arm64/boot/dts/renesas/salvator-common.dtsi index 7b30044a55367d35..4cb4b44f8be42cb4 100644 --- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi +++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi @@ -42,7 +42,7 @@ }; chosen { - bootargs = "ignore_loglevel rw root=/dev/nfs ip=dhcp"; + bootargs = "ignore_loglevel rw root=/dev/nfs ip=dhcp adv748x.txbvc=1"; stdout-path = "serial0:115200n8"; }; >>> END DIFF <<<