From patchwork Wed Dec 13 21:24:43 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dave Gerlach X-Patchwork-Id: 10110953 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id CF89A602B3 for ; Wed, 13 Dec 2017 21:38:15 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C0F6228F34 for ; Wed, 13 Dec 2017 21:38:15 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B592B28FBF; Wed, 13 Dec 2017 21:38:15 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 0636728F34 for ; Wed, 13 Dec 2017 21:38:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=Mz7kcpT8THcQEKUMviyxyZvpgGVgeIQcoYl4kZF2xrU=; b=F5qbIzGdURcfAC r9HfZeneBRI9LEIRYUB6b90rzWZEfEDFaC+r7akuA5vh0uGM733Ohw3Z/QLCUOOJUIPRWg66DlKXG OwHk+otUGAVCbsztPSUDZINMELHc3TRv6WSvdRfKO8uRvBCBeWqa1Abw+TcB3bG+uzdY7VqMfzuCJ fKnU78Fy4TXL0OftMz921HCyV1DVP7eQljr1xSBJVZjlZb+7l3rmWmr2XowC97guKaLXVByfM8Ydv K2gRiXt9VOJauNJFvbBph2BeLmAG3TjMl/XkPcnDY9Qipe97zzBz/tM40phyOGmcmt5oYy36Jzqur DS70BrQ1TKy63F2IAzhA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1ePEjG-0005Wp-HN; Wed, 13 Dec 2017 21:38:14 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1ePEjE-0005TT-0q for linux-arm-kernel@bombadil.infradead.org; Wed, 13 Dec 2017 21:38:12 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Type:MIME-Version:Message-ID: Date:Subject:CC:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Ekbo05Xb1sriHBMFy7K35ZwELHulObmYS83ulV2Yob4=; b=QnLVm6sHKxh8GNubhbjSMZ3cYQ KClIPJ76kDznGOFmcghDT4ujh8DjIxNcf5Vzm7gh6TvnxT38uYNCLQNA/d/J8eajCQwEy1pNy7oHQ efIRt2KK91cP8qM/NUtpzrlpiBvUYPcOsTlTdHuISu291tFUectME4Bq3R8s2H0SCmIQLlEY0DieG 0G6WUfJ5NpDCG1uy5umGfw17hFTr65oJobhGZZ/vVnQV/s0pHEI033GnbZz5KzR9DA1bbE6Vaypzq cLAyLpUE8xFRcRv8Pe5TNjMBw8VlsKGuS6u8ktrpAIVTb6uiNvn1baPaXzIceaqVT4hE8hEeIe/aC v2mzkWXA==; Received: from fllnx210.ext.ti.com ([198.47.19.17]) by casper.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1ePEWk-0002En-2r for linux-arm-kernel@lists.infradead.org; Wed, 13 Dec 2017 21:25:20 +0000 Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by fllnx210.ext.ti.com (8.15.1/8.15.1) with ESMTP id vBDLOpIZ016176; Wed, 13 Dec 2017 15:24:51 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ti.com; s=ti-com-17Q1; t=1513200291; bh=R6tKGLFKPYKNo+XvXp4ysdkD9ITVkzKJaYq2efs6cUk=; h=From:To:CC:Subject:Date; b=W/EY8H1306/Aq3a/eOVSS9G9xV4C702G7KVI6DvP2mm3t2jH3eUc1t33NZqdoIZkM hZwdkWkTeBFiQiEHjNN7ATZpsM3a1ysCGtormMJIEI9NuOykQUKwO2HZ+EXZGrpfMr fjrtawq8xS+GARM5tLJLWdZt3dUsQbyKAWHaPKVw= Received: from DLEE107.ent.ti.com (dlee107.ent.ti.com [157.170.170.37]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id vBDLOo2p004525; Wed, 13 Dec 2017 15:24:50 -0600 Received: from DLEE102.ent.ti.com (157.170.170.32) by DLEE107.ent.ti.com (157.170.170.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.845.34; Wed, 13 Dec 2017 15:24:50 -0600 Received: from dflp33.itg.ti.com (10.64.6.16) by DLEE102.ent.ti.com (157.170.170.32) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.845.34 via Frontend Transport; Wed, 13 Dec 2017 15:24:50 -0600 Received: from legion.dal.design.ti.com (legion.dal.design.ti.com [128.247.22.53]) by dflp33.itg.ti.com (8.14.3/8.13.8) with ESMTP id vBDLOoGF005388; Wed, 13 Dec 2017 15:24:50 -0600 Received: from localhost (uda0274052.dhcp.ti.com [128.247.59.203]) by legion.dal.design.ti.com (8.11.7p1+Sun/8.11.7) with ESMTP id vBDLOox25031; Wed, 13 Dec 2017 15:24:50 -0600 (CST) From: Dave Gerlach To: Tony Lindgren Subject: [PATCH] ARM: dts: am43xx: Fix inverted DS0_PULL_UP_DOWN_EN macro Date: Wed, 13 Dec 2017 15:24:43 -0600 Message-ID: <20171213212443.22632-1-d-gerlach@ti.com> X-Mailer: git-send-email 2.15.1 MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20171213_212518_351055_82A81A6F X-CRM114-Status: UNSURE ( 7.98 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Dave Gerlach Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Due to a mistake in documentation the DS0_PULL_UP_DOWN_EN macro was mistakenly defined as an active high bit, however setting the bit actually disables the internal pull resistor on the pin, so correct this macro and introduce a new DS0_PULL_UP_DOWN_DIS macro with the proper bit value set now that the documentation has been updated. Change based on AM437x Techninal Reference Manual SPRUHL7G Revised June 2017 Section 7.2.1. Signed-off-by: Dave Gerlach --- include/dt-bindings/pinctrl/am43xx.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/dt-bindings/pinctrl/am43xx.h b/include/dt-bindings/pinctrl/am43xx.h index a69e310789c5..6ce4a32f77d4 100644 --- a/include/dt-bindings/pinctrl/am43xx.h +++ b/include/dt-bindings/pinctrl/am43xx.h @@ -25,7 +25,8 @@ #define DS0_FORCE_OFF_MODE (1 << 24) #define DS0_INPUT (1 << 25) #define DS0_FORCE_OUT_HIGH (1 << 26) -#define DS0_PULL_UP_DOWN_EN (1 << 27) +#define DS0_PULL_UP_DOWN_EN (0 << 27) +#define DS0_PULL_UP_DOWN_DIS (1 << 27) #define DS0_PULL_UP_SEL (1 << 28) #define WAKEUP_ENABLE (1 << 29)