From patchwork Thu Dec 14 15:12:40 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andre Heider X-Patchwork-Id: 10112421 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id EAE0160352 for ; Thu, 14 Dec 2017 15:13:29 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DBA1729048 for ; Thu, 14 Dec 2017 15:13:29 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D08DA29059; Thu, 14 Dec 2017 15:13:29 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FROM, RCVD_IN_DNSWL_MED autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 697D729055 for ; Thu, 14 Dec 2017 15:13:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=IStR/dd6md+wyuoCNl9VZk7J6p5mxY7u0AigLgFBZlk=; b=Tdm wngK2TCblP6kmfn7N2HmRoEiY2H2HLqqzksJa6cwl5drRENJ1yD7iTir/r6NKZutdID7XKkhyOMlw APDYNf7xauYDonqYLCtEVwWapwcdjtsm+trd97E19Y1w1p0B1ROG5V2UJPgf78r+50kubZ6iMqWIR OGeYTYCJjWn1axPvOJXsyjM1azHCWnaFRCFPkNOh8d/kf+ASFL3OKpF8O/pNbHGCL211xGIQpMuwu ackejFB1kGP+2QtBUlnK7ClkB0UgCsVqJL9ZNOerYo/n8yS00Fr+Dal6HLwlYYx/GdsOST0xm5kJK ufTxFRt0+d+syeqsSyRm42oY5CCfchw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1ePVCP-0001Ru-I7; Thu, 14 Dec 2017 15:13:25 +0000 Received: from mail-wm0-x244.google.com ([2a00:1450:400c:c09::244]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1ePVCG-0001QC-6o for linux-arm-kernel@lists.infradead.org; Thu, 14 Dec 2017 15:13:23 +0000 Received: by mail-wm0-x244.google.com with SMTP id f9so12171210wmh.0 for ; Thu, 14 Dec 2017 07:12:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=KyYK8X1qaX0wgWs12W5zCz2p8dSchnJrt7wri1PqZgQ=; b=lJgDxHPe6yymCmgViozfYKlgQjzLe+dOrkP7FVmQ5RxS5g7KZk66uL1usIhv2gKfNL Gq9owwxsy2fxRnjsy4370cG50WkDBksRHd1pB5acO7nwZoYIJJzJviTZNy4k4s7G1KBl aGK59nfdo2xOlOY4yRJJ0/bTOO6lzHNA7LMMus7mRvU6/mV77q3ROHRu62KB+WjyNiqg RPO0XqZS13QZLRbsQRHEY5cd22N73TYeRWRE/CvoMr6ZyfhEipxYk7rZR/YO5zzhAQJO ZLkP68DjodXqOV5+XM148G27zg+NKDUMT9+ygEwUnCMKvtsKmlpbTRu5AzGYJYHQlhW9 0KMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=KyYK8X1qaX0wgWs12W5zCz2p8dSchnJrt7wri1PqZgQ=; b=SiVxPdCbcerUsrLZvFt9Lx19/DZZYsCHh/3pp8IvnVLMi8p2eZcXoFvoBMugrLRWPa +/wwwXJ6zPX6OU5QKf4cCQaqL9imDzP8APZq4v6guAnhaVpQa+0fp5hzWNYw+Nhm0gND EkBTNVFdoKEbLZat/RONtJ/9kZUcFEZlAjHlt89GzU4f5U3db9yNPEmMhaXQof5ZROdO bdhoJOIfQV6PfgbqOBgWBFOacnFx4LpfL0rlgDLjj432aPss2l/W/rwXz+lXs7nrXLbz GqIOIEsGPq49zKVhQGR8N7Xnsy7fBJ1IEZ7UhwO5N7yajEgL/R2Sbm2HC+qlmfoXNu5z 8w2A== X-Gm-Message-State: AKGB3mIJmU2dnU8OOsZzbK+v9Motujq/wzjMnBR0g0ApaMBnz+voSWFb M1kU40ErhRlAGs1EK5s0Bt4= X-Google-Smtp-Source: ACJfBovygk56LiYU/ZKmES4IacPRXsl7zIaCcj47Rusj4+asR1TGP6XIKAkGAWiSVZ2th1WCXfF4AQ== X-Received: by 10.28.35.4 with SMTP id j4mr2336914wmj.55.1513264369688; Thu, 14 Dec 2017 07:12:49 -0800 (PST) Received: from mamamia.internal (a89-182-105-235.net-htp.de. [89.182.105.235]) by smtp.gmail.com with ESMTPSA id 137sm4474424wms.28.2017.12.14.07.12.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 Dec 2017 07:12:49 -0800 (PST) From: Andre Heider To: Rob Herring , Frank Rowand , Masahiro Yamada , Michal Marek Subject: [PATCH] of: build dbts with symbols when CONFIG_OF_OVERLAY is set Date: Thu, 14 Dec 2017 16:12:40 +0100 Message-Id: <20171214151240.14555-1-a.heider@gmail.com> X-Mailer: git-send-email 2.15.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20171214_071317_289204_11C6DF3F X-CRM114-Status: UNSURE ( 9.71 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kbuild@vger.kernel.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP The overlay feature requires the base dtb to be built with symbols, so lets build the dtbs with symbols when overlay support was explicitly enabled. With CONFIG_OF_ALL_DTBS on ARCH=arm the 989 dtb files grow about ~38% on average. Totals in bytes with the 3 biggest ones: Before: 90471 arch/arm/boot/dts/am57xx-beagle-x15-revc.dtb 90521 arch/arm/boot/dts/am57xx-beagle-x15-revb1.dtb 92639 arch/arm/boot/dts/dra7-evm.dtb 25731296 total After: 133203 arch/arm/boot/dts/am57xx-beagle-x15-revc.dtb 133237 arch/arm/boot/dts/am57xx-beagle-x15-revb1.dtb 134545 arch/arm/boot/dts/dra7-evm.dtb 35464440 total Signed-off-by: Andre Heider --- Hi, while playing around with overlays I noticed that I needed to rebuilt my distro's device trees because they didn't come with symbols. Is that for a reason, maybe the not so minor increase in size? Thanks, Andre drivers/of/unittest-data/Makefile | 7 ------- scripts/Makefile.lib | 5 +++++ 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/of/unittest-data/Makefile b/drivers/of/unittest-data/Makefile index 32389acfa616..b65061013512 100644 --- a/drivers/of/unittest-data/Makefile +++ b/drivers/of/unittest-data/Makefile @@ -15,13 +15,6 @@ targets += overlay.dtb overlay.dtb.S targets += overlay_bad_phandle.dtb overlay_bad_phandle.dtb.S targets += overlay_bad_symbol.dtb overlay_bad_symbol.dtb.S targets += overlay_base.dtb overlay_base.dtb.S - -# enable creation of __symbols__ node -DTC_FLAGS_overlay := -@ -DTC_FLAGS_overlay_bad_phandle := -@ -DTC_FLAGS_overlay_bad_symbol := -@ -DTC_FLAGS_overlay_base := -@ - endif .PRECIOUS: \ diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib index 1ca4dcd2d500..c7ba4aa8a07a 100644 --- a/scripts/Makefile.lib +++ b/scripts/Makefile.lib @@ -278,6 +278,11 @@ DTC_FLAGS += -Wnode_name_chars_strict \ -Wproperty_name_chars_strict endif +ifeq ($(CONFIG_OF_OVERLAY),y) +# enable creation of __symbols__ node +DTC_FLAGS += -@ +endif + DTC_FLAGS += $(DTC_FLAGS_$(basetarget)) # Generate an assembly file to wrap the output of the device tree compiler