| Message ID | 20171215042528.28715-4-d-gerlach@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Dec 15, 2017 at 5:25 AM, Dave Gerlach <d-gerlach@ti.com> wrote: > Document the devicetree bindings that describe Texas Instruments > opp-supply which allow a platform to describe multiple regulators and > additional information, such as registers containing data needed to > program aforementioned regulators. > > Signed-off-by: Dave Gerlach <d-gerlach@ti.com> I need an ACK from Rob on this one. > --- > .../bindings/opp/ti-omap5-opp-supply.txt | 63 ++++++++++++++++++++++ > 1 file changed, 63 insertions(+) > create mode 100644 Documentation/devicetree/bindings/opp/ti-omap5-opp-supply.txt > > diff --git a/Documentation/devicetree/bindings/opp/ti-omap5-opp-supply.txt b/Documentation/devicetree/bindings/opp/ti-omap5-opp-supply.txt > new file mode 100644 > index 000000000000..832346e489a3 > --- /dev/null > +++ b/Documentation/devicetree/bindings/opp/ti-omap5-opp-supply.txt > @@ -0,0 +1,63 @@ > +Texas Instruments OMAP compatible OPP supply description > + > +OMAP5, DRA7, and AM57 family of SoCs have Class0 AVS eFuse registers which > +contain data that can be used to adjust voltages programmed for some of their > +supplies for more efficient operation. This binding provides the information > +needed to read these values and use them to program the main regulator during > +an OPP transitions. > + > +Also, some supplies may have an associated vbb-supply which is an Adaptive Body > +Bias regulator which much be transitioned in a specific sequence with regards > +to the vdd-supply and clk when making an OPP transition. By supplying two > +regulators to the device that will undergo OPP transitions we can make use > +of the multi regulator binding that is part of the OPP core described here [1] > +to describe both regulators needed by the platform. > + > +[1] Documentation/devicetree/bindings/opp/opp.txt > + > +Required Properties for Device Node: > +- vdd-supply: phandle to regulator controlling VDD supply > +- vbb-supply: phandle to regulator controlling Body Bias supply > + (Usually Adaptive Body Bias regulator) > + > +Required Properties for opp-supply node: > +- compatible: Should be one of: > + "ti,omap-opp-supply" - basic OPP supply controlling VDD and VBB > + "ti,omap5-opp-supply" - OMAP5+ optimized voltages in efuse(class0)VDD > + along with VBB > + "ti,omap5-core-opp-supply" - OMAP5+ optimized voltages in efuse(class0) VDD > + but no VBB. > +- reg: Address and length of the efuse register set for the device (mandatory > + only for "ti,omap5-opp-supply") > +- ti,efuse-settings: An array of u32 tuple items providing information about > + optimized efuse configuration. Each item consists of the following: > + volt: voltage in uV - reference voltage (OPP voltage) > + efuse_offseet: efuse offset from reg where the optimized voltage is stored. > +- ti,absolute-max-voltage-uv: absolute maximum voltage for the OPP supply. > + > +Example: > + > +/* Device Node (CPU) */ > +cpus { > + cpu0: cpu@0 { > + device_type = "cpu"; > + > + ... > + > + vdd-supply = <&vcc>; > + vbb-supply = <&abb_mpu>; > + }; > +}; > + > +/* OMAP OPP Supply with Class0 registers */ > +opp_supply_mpu: opp_supply@4a003b20 { > + compatible = "ti,omap5-opp-supply"; > + reg = <0x4a003b20 0x8>; > + ti,efuse-settings = < > + /* uV offset */ > + 1060000 0x0 > + 1160000 0x4 > + 1210000 0x8 > + >; > + ti,absolute-max-voltage-uv = <1500000>; > +}; > -- > 2.15.1 >
On Fri, Dec 15, 2017 at 3:29 PM, Rafael J. Wysocki <rafael@kernel.org> wrote: > On Fri, Dec 15, 2017 at 5:25 AM, Dave Gerlach <d-gerlach@ti.com> wrote: >> Document the devicetree bindings that describe Texas Instruments >> opp-supply which allow a platform to describe multiple regulators and >> additional information, such as registers containing data needed to >> program aforementioned regulators. >> >> Signed-off-by: Dave Gerlach <d-gerlach@ti.com> > > I need an ACK from Rob on this one. Actually, how this (and the next patch) is related to the [1-2/4]?
On Thu, Dec 14, 2017 at 10:25:27PM -0600, Dave Gerlach wrote: > Document the devicetree bindings that describe Texas Instruments > opp-supply which allow a platform to describe multiple regulators and > additional information, such as registers containing data needed to > program aforementioned regulators. > > Signed-off-by: Dave Gerlach <d-gerlach@ti.com> > --- > .../bindings/opp/ti-omap5-opp-supply.txt | 63 ++++++++++++++++++++++ > 1 file changed, 63 insertions(+) > create mode 100644 Documentation/devicetree/bindings/opp/ti-omap5-opp-supply.txt Acked-by: Rob Herring <robh@kernel.org>
Rafael, On 12/16/2017 04:52 AM, Rafael J. Wysocki wrote: > On Fri, Dec 15, 2017 at 3:29 PM, Rafael J. Wysocki <rafael@kernel.org> wrote: >> On Fri, Dec 15, 2017 at 5:25 AM, Dave Gerlach <d-gerlach@ti.com> wrote: >>> Document the devicetree bindings that describe Texas Instruments >>> opp-supply which allow a platform to describe multiple regulators and >>> additional information, such as registers containing data needed to >>> program aforementioned regulators. >>> >>> Signed-off-by: Dave Gerlach <d-gerlach@ti.com> >> >> I need an ACK from Rob on this one. > > Actually, how this (and the next patch) is related to the [1-2/4]? > The main goal of this series is to add support for scaling the multiple regulators needed for the CPU on these TI platforms. The OPP core supports multiple regulators but only to the point that it can associate a list of regulators to a device. It still by default only scales the normal vdd regulator when doing a rate transition. Because of this, we must define our own method of doing rate transitions to take the references to our regulators held in the OPP core and scale them in the proper sequence depending on what the platform needs. So to describe the purpose of each patch and their relation to each other: Patch 1: We must be able to defer the ti-cpufreq driver now that we look for regulators during probe as they likely won't be ready when we probe. Patch 2: Tell the OPP core about regulators needed for TI CPUFreq operation using the OPP core. This doesn't actually do anything besides place them in a list at this point because the OPP core can't know how TI platforms needs them scaled in relation to each other. Placing the regulator definition in ti-cpufreq driver ensures they are registered with opp core before cpufreq-dt probes (which is triggered at the end of ti-cpufreq probe) and actually makes the opp core get the regulators. Patch 3: Binding doc for patch 4 driver. Patch 4: TI OPP supply driver which understands how to actually make use of the two regulators that the OPP core now has a reference to. This overrides the standard opp_set_rate function to let us scale frequency and voltage as needed for TI platforms. Regards, Dave
On Mon, Dec 18, 2017 at 8:25 PM, Dave Gerlach <d-gerlach@ti.com> wrote: > Rafael, > On 12/16/2017 04:52 AM, Rafael J. Wysocki wrote: >> On Fri, Dec 15, 2017 at 3:29 PM, Rafael J. Wysocki <rafael@kernel.org> wrote: >>> On Fri, Dec 15, 2017 at 5:25 AM, Dave Gerlach <d-gerlach@ti.com> wrote: >>>> Document the devicetree bindings that describe Texas Instruments >>>> opp-supply which allow a platform to describe multiple regulators and >>>> additional information, such as registers containing data needed to >>>> program aforementioned regulators. >>>> >>>> Signed-off-by: Dave Gerlach <d-gerlach@ti.com> >>> >>> I need an ACK from Rob on this one. >> >> Actually, how this (and the next patch) is related to the [1-2/4]? >> > > The main goal of this series is to add support for scaling the multiple > regulators needed for the CPU on these TI platforms. The OPP core supports > multiple regulators but only to the point that it can associate a list of > regulators to a device. It still by default only scales the normal vdd regulator > when doing a rate transition. Because of this, we must define our own method of > doing rate transitions to take the references to our regulators held in the OPP > core and scale them in the proper sequence depending on what the platform needs. > > So to describe the purpose of each patch and their relation to each other: > > Patch 1: We must be able to defer the ti-cpufreq driver now that we look for > regulators during probe as they likely won't be ready when we probe. > > Patch 2: Tell the OPP core about regulators needed for TI CPUFreq operation > using the OPP core. This doesn't actually do anything besides place them in a > list at this point because the OPP core can't know how TI platforms needs them > scaled in relation to each other. Placing the regulator definition in ti-cpufreq > driver ensures they are registered with opp core before cpufreq-dt probes (which > is triggered at the end of ti-cpufreq probe) and actually makes the opp core get > the regulators. > > Patch 3: Binding doc for patch 4 driver. > > Patch 4: TI OPP supply driver which understands how to actually make use of the > two regulators that the OPP core now has a reference to. This overrides the > standard opp_set_rate function to let us scale frequency and voltage as needed > for TI platforms. Thanks for the explanation, I've applied the series.
diff --git a/Documentation/devicetree/bindings/opp/ti-omap5-opp-supply.txt b/Documentation/devicetree/bindings/opp/ti-omap5-opp-supply.txt new file mode 100644 index 000000000000..832346e489a3 --- /dev/null +++ b/Documentation/devicetree/bindings/opp/ti-omap5-opp-supply.txt @@ -0,0 +1,63 @@ +Texas Instruments OMAP compatible OPP supply description + +OMAP5, DRA7, and AM57 family of SoCs have Class0 AVS eFuse registers which +contain data that can be used to adjust voltages programmed for some of their +supplies for more efficient operation. This binding provides the information +needed to read these values and use them to program the main regulator during +an OPP transitions. + +Also, some supplies may have an associated vbb-supply which is an Adaptive Body +Bias regulator which much be transitioned in a specific sequence with regards +to the vdd-supply and clk when making an OPP transition. By supplying two +regulators to the device that will undergo OPP transitions we can make use +of the multi regulator binding that is part of the OPP core described here [1] +to describe both regulators needed by the platform. + +[1] Documentation/devicetree/bindings/opp/opp.txt + +Required Properties for Device Node: +- vdd-supply: phandle to regulator controlling VDD supply +- vbb-supply: phandle to regulator controlling Body Bias supply + (Usually Adaptive Body Bias regulator) + +Required Properties for opp-supply node: +- compatible: Should be one of: + "ti,omap-opp-supply" - basic OPP supply controlling VDD and VBB + "ti,omap5-opp-supply" - OMAP5+ optimized voltages in efuse(class0)VDD + along with VBB + "ti,omap5-core-opp-supply" - OMAP5+ optimized voltages in efuse(class0) VDD + but no VBB. +- reg: Address and length of the efuse register set for the device (mandatory + only for "ti,omap5-opp-supply") +- ti,efuse-settings: An array of u32 tuple items providing information about + optimized efuse configuration. Each item consists of the following: + volt: voltage in uV - reference voltage (OPP voltage) + efuse_offseet: efuse offset from reg where the optimized voltage is stored. +- ti,absolute-max-voltage-uv: absolute maximum voltage for the OPP supply. + +Example: + +/* Device Node (CPU) */ +cpus { + cpu0: cpu@0 { + device_type = "cpu"; + + ... + + vdd-supply = <&vcc>; + vbb-supply = <&abb_mpu>; + }; +}; + +/* OMAP OPP Supply with Class0 registers */ +opp_supply_mpu: opp_supply@4a003b20 { + compatible = "ti,omap5-opp-supply"; + reg = <0x4a003b20 0x8>; + ti,efuse-settings = < + /* uV offset */ + 1060000 0x0 + 1160000 0x4 + 1210000 0x8 + >; + ti,absolute-max-voltage-uv = <1500000>; +};
Document the devicetree bindings that describe Texas Instruments opp-supply which allow a platform to describe multiple regulators and additional information, such as registers containing data needed to program aforementioned regulators. Signed-off-by: Dave Gerlach <d-gerlach@ti.com> --- .../bindings/opp/ti-omap5-opp-supply.txt | 63 ++++++++++++++++++++++ 1 file changed, 63 insertions(+) create mode 100644 Documentation/devicetree/bindings/opp/ti-omap5-opp-supply.txt