From patchwork Fri Dec 22 02:45:22 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Stanley X-Patchwork-Id: 10128723 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id B20006038F for ; Fri, 22 Dec 2017 02:49:45 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A1E3B2997D for ; Fri, 22 Dec 2017 02:49:45 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 958C6299BC; Fri, 22 Dec 2017 02:49:45 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_MED autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 331BE2997D for ; Fri, 22 Dec 2017 02:49:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=i/Q3bD7Ztu/CjeeKsy4FkfOhdvlXKN22JGtLVZ9y1ds=; b=tQRTU2q3EXpcKD1VxVIvox5NkB It6lmM0Tj5Teflqv4sOw8+ZtDilE0VWSQTGd0/6j8EWoB/KYKbknl7fEqj9wov/oPz8ef4RNHnRCE j0q/T3veHmYdaS1XEKhMAI6azvmjK1Vv37EeY/LJRk5BfxaJCUYO/VCPvYE41jTZpR0Ubl59hTlHT 5rzTOE1crcWMpkY3M7G5wzAOW7w5mf4k/hd/X2LELEE25filb/ahZJwe/Foc/fkMvpqkNL+RatO68 iB9HG3eJI7LEwch5ZLcyD6Pl5UTqE0/EYNlIj0nzrld303kvpbwGJ/hKUH4RHl46ToB7m0dGt+dwi C6nb0TAg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux)) id 1eSDP4-0008Rj-Ej; Fri, 22 Dec 2017 02:49:42 +0000 Received: from mail-pf0-x243.google.com ([2607:f8b0:400e:c00::243]) by bombadil.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux)) id 1eSDM5-00070w-6n for linux-arm-kernel@lists.infradead.org; Fri, 22 Dec 2017 02:46:48 +0000 Received: by mail-pf0-x243.google.com with SMTP id n6so14775751pfa.4 for ; Thu, 21 Dec 2017 18:46:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=tpR8qyGU2q4CSR7ehBU5bjr+Vz3UbL3xFgSfK2SiWZA=; b=pVl98C49gEzktXvp3CZ8AddwhHGhSIkDwn6pC4GQM/iv32omL3Ox/nnDhh82t3BsAF HNUBXwaAwpFDsIPUtspsnzJhRMFEeOl3C9NLpfYn9oA/Z2yQ0NhTz2LO5T7PBJjcoYPR LuqvZXbAU+xn8rhpGF137mW4f0Bsj3v18avrxMuapfGmSzyeEajiD7Cyo4f1u5b1kFsf SrFtUvcpbIg3kiHmNiRaJrNQ1a8IYZZVAEdUTDpFxp7fMJy6mIer56hYu6yVu5DdQNb0 lYK5kFPt/5gKeVYeDkWyrzrZ+7K90pFKDY32cimabAJTY4s2m6vLlfNP4/P2qOn7jpKL Dgog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=tpR8qyGU2q4CSR7ehBU5bjr+Vz3UbL3xFgSfK2SiWZA=; b=FQ679fbuurH44HyQ0laz4coZeB963eqckxns8y+iyWWZzALS1k/g2gwXXuRG8CX4ez fYGHRL+r/ckBMUQpdIocOAJ4XB6gIhgLmSjs1HRIesBD/uC8uAWfL9K6R+shL2Ab1DDh UOVcfa8WWKefGypUZtRtYoWBu7KUIn49UpI83XuB+haUWdGMXWxye8pP2NYAcLYRd2Xj YlJI+goMBiKgAVjYvRlobIPPMcopCYXHTAkww4XV1kt/yinVHUZtdjW7ud52UjkRT0Zp WRSaOM8nADghVq6fWumIUVea0wp1LVQW9uTY5KshkHmEsyW9Dx30Wj6O4OUeFFDyemns FyTw== X-Gm-Message-State: AKGB3mI5rWr/rTEX0BFs4sF7Ry6PxyfHxGiM8sei8mFzi3xR2QEfO0rm m7JpmYLEYgE/csPkYr14bAg= X-Google-Smtp-Source: ACJfBosskSKyXxyGFMNOKQFrGusZHGCz8zv0gX8qPWWd1jHT7aAsFJX/JcEN9dJb+8LAshWQL0vehg== X-Received: by 10.99.96.10 with SMTP id u10mr11382115pgb.303.1513910786277; Thu, 21 Dec 2017 18:46:26 -0800 (PST) Received: from aurora.jms.id.au ([203.0.153.9]) by smtp.gmail.com with ESMTPSA id u6sm42720595pfk.126.2017.12.21.18.46.20 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 21 Dec 2017 18:46:25 -0800 (PST) Received: by aurora.jms.id.au (sSMTP sendmail emulation); Fri, 22 Dec 2017 13:16:16 +1030 From: Joel Stanley To: Lee Jones , Michael Turquette , Stephen Boyd Subject: [PATCH v7 5/5] clk: aspeed: Add reset controller Date: Fri, 22 Dec 2017 13:15:22 +1030 Message-Id: <20171222024522.10362-6-joel@jms.id.au> X-Mailer: git-send-email 2.15.1 In-Reply-To: <20171222024522.10362-1-joel@jms.id.au> References: <20171222024522.10362-1-joel@jms.id.au> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20171221_184637_641389_FA337B62 X-CRM114-Status: GOOD ( 15.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ryan Chen , Arnd Bergmann , Andrew Jeffery , Benjamin Herrenschmidt , linux-kernel@vger.kernel.org, Rick Altherr , Jeremy Kerr , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP There are some resets that are not associated with gates. These are represented by a reset controller. Reviewed-by: Andrew Jeffery Signed-off-by: Joel Stanley Reviewed-by: Benjamin Herrenschmidt --- v7: - Rebase on dt-bindings patch v5: - Add Andrew's Reviewed-by v3: - Add named initalisers for the reset defines - Add define for ADC --- drivers/clk/clk-aspeed.c | 82 +++++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 81 insertions(+), 1 deletion(-) diff --git a/drivers/clk/clk-aspeed.c b/drivers/clk/clk-aspeed.c index dbd3c7774831..6fb344730cea 100644 --- a/drivers/clk/clk-aspeed.c +++ b/drivers/clk/clk-aspeed.c @@ -8,6 +8,7 @@ #include #include #include +#include #include #include @@ -267,6 +268,68 @@ static const struct clk_ops aspeed_clk_gate_ops = { .is_enabled = aspeed_clk_is_enabled, }; +/** + * struct aspeed_reset - Aspeed reset controller + * @map: regmap to access the containing system controller + * @rcdev: reset controller device + */ +struct aspeed_reset { + struct regmap *map; + struct reset_controller_dev rcdev; +}; + +#define to_aspeed_reset(p) container_of((p), struct aspeed_reset, rcdev) + +static const u8 aspeed_resets[] = { + [ASPEED_RESET_XDMA] = 25, + [ASPEED_RESET_MCTP] = 24, + [ASPEED_RESET_ADC] = 23, + [ASPEED_RESET_JTAG_MASTER] = 22, + [ASPEED_RESET_MIC] = 18, + [ASPEED_RESET_PWM] = 9, + [ASPEED_RESET_PCIVGA] = 8, + [ASPEED_RESET_I2C] = 2, + [ASPEED_RESET_AHB] = 1, +}; + +static int aspeed_reset_deassert(struct reset_controller_dev *rcdev, + unsigned long id) +{ + struct aspeed_reset *ar = to_aspeed_reset(rcdev); + u32 rst = BIT(aspeed_resets[id]); + + return regmap_update_bits(ar->map, ASPEED_RESET_CTRL, rst, 0); +} + +static int aspeed_reset_assert(struct reset_controller_dev *rcdev, + unsigned long id) +{ + struct aspeed_reset *ar = to_aspeed_reset(rcdev); + u32 rst = BIT(aspeed_resets[id]); + + return regmap_update_bits(ar->map, ASPEED_RESET_CTRL, rst, rst); +} + +static int aspeed_reset_status(struct reset_controller_dev *rcdev, + unsigned long id) +{ + struct aspeed_reset *ar = to_aspeed_reset(rcdev); + u32 val, rst = BIT(aspeed_resets[id]); + int ret; + + ret = regmap_read(ar->map, ASPEED_RESET_CTRL, &val); + if (ret) + return ret; + + return !!(val & rst); +} + +static const struct reset_control_ops aspeed_reset_ops = { + .assert = aspeed_reset_assert, + .deassert = aspeed_reset_deassert, + .status = aspeed_reset_status, +}; + static struct clk_hw *aspeed_clk_hw_register_gate(struct device *dev, const char *name, const char *parent_name, unsigned long flags, struct regmap *map, u8 clock_idx, u8 reset_idx, @@ -308,10 +371,11 @@ static int aspeed_clk_probe(struct platform_device *pdev) { const struct aspeed_clk_soc_data *soc_data; struct device *dev = &pdev->dev; + struct aspeed_reset *ar; struct regmap *map; struct clk_hw *hw; u32 val, rate; - int i; + int i, ret; map = syscon_node_to_regmap(dev->of_node); if (IS_ERR(map)) { @@ -319,6 +383,22 @@ static int aspeed_clk_probe(struct platform_device *pdev) return PTR_ERR(map); } + ar = devm_kzalloc(dev, sizeof(*ar), GFP_KERNEL); + if (!ar) + return -ENOMEM; + + ar->map = map; + ar->rcdev.owner = THIS_MODULE; + ar->rcdev.nr_resets = ARRAY_SIZE(aspeed_resets); + ar->rcdev.ops = &aspeed_reset_ops; + ar->rcdev.of_node = dev->of_node; + + ret = devm_reset_controller_register(dev, &ar->rcdev); + if (ret) { + dev_err(dev, "could not register reset controller\n"); + return ret; + } + /* SoC generations share common layouts but have different divisors */ soc_data = of_device_get_match_data(dev); if (!soc_data) {