Message ID | 20171226111227.4526-3-net147@gmail.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show
Return-Path: <linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org> Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 0C59E60211 for <patchwork-linux-arm@patchwork.kernel.org>; Tue, 26 Dec 2017 11:11:54 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 033F52D15F for <patchwork-linux-arm@patchwork.kernel.org>; Tue, 26 Dec 2017 11:11:54 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id EC45D2E505; Tue, 26 Dec 2017 11:11:53 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FROM, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 796672D15F for <patchwork-linux-arm@patchwork.kernel.org>; Tue, 26 Dec 2017 11:11:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=3RVB0qHWUsXqT95g9IFficdTm/fqo3+hGjsDlgg3C20=; b=P2kFupMe565KaOaX124z+bpSj8 xHUgVQivmHz8lJMEehut2hi8EyjpSoI3to4vk5oU3hVw178tGEmuJX9dfuC8GH87nZqDFbvxXqIXv RcpwPv82BTAJFA/L99d+hmIVy0hTmAh5Cbm3ass7ogylHm8iCz796XJyNRibzpG11VtNNb0gu7JxB 9WeLtZQVAW0/hNOPu9eB9At1DzCljtniCQNGyCTlEZdlLH15ThHZMOVm86YN33OrKiVuzeKkkCKVe CxswQYlwKkJmWNHv2xnxPFkzxj2A1iFBvhhTmzPktCFn+hLvhKKr4KLuygxl5j3GNe79OlfjXhCqP G/zpVPlw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux)) id 1eTn9C-0006Qs-6C; Tue, 26 Dec 2017 11:11:50 +0000 Received: from mail-pl0-x242.google.com ([2607:f8b0:400e:c01::242]) by bombadil.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux)) id 1eTn7k-0005Uz-Od for linux-arm-kernel@lists.infradead.org; Tue, 26 Dec 2017 11:10:22 +0000 Received: by mail-pl0-x242.google.com with SMTP id s3so17711199plp.4 for <linux-arm-kernel@lists.infradead.org>; Tue, 26 Dec 2017 03:10:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=7DtfEbNlSU4KTpMfKGwNGmsaKKTeMrzSSQ7esz0ucYU=; b=mM7A6VlgoTwknYMV6uVyx1aTHtF/5hBhatCZXLnSMvFGXRtx7JESME26+MPZCMv8Hg J0l6Ad+ebK4thqVQyKFhbhuw93Mf9J24uMCaynj8gWkUo9J8Y0i1TbL++Uei/ZCq9vWf 5V0gRkp0vaqVXURyxBm0hGaJJERzoPbBjurelS7tpbT63Aol0FvRZhPkGUDVgKTksUJP TpqDYrlyXOWUWjsIFmcLKfg+6FJvRQMfD7ykSih1GcL5xmkwo+nosx74XDHetVCEptFz 3twWkMlS9MgCrjmbQQ9TyQ3ZWUNMz+VcmcGfSdfVxw9bOP64TrysnowdUB0LvZrOrKx9 tT4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=7DtfEbNlSU4KTpMfKGwNGmsaKKTeMrzSSQ7esz0ucYU=; b=gUU3aFT1IoTpOa1DuermOuhDbUDYrk0JlNQJDud52oEiD9LXgh1ZlWcWGMgbaGAiHx xA/j3ckHkVm5D1FX+KJ2u3x5OiK4I+e1yqpiZEVDlZ74sdi57Ksx8xMb2ADrjyp7l0Xn v4dGPEkVTuHQw1pZs45dBZ6/8V/cPer1eVNB0U5RwfTImXzTcVicGaF5TxW3IQC4JGdB SMDKdT4684s7OwoybqiMFkzLUJTQ+4N0OEhf8CD87XxCdueF1/fXmHc/BEHbHCbbk6/1 VDwwRhSO5CctwjYviMT4C/w4+6MpHYrKu2+3X+UwfCB4y5ErBd6HSYHFq3sEArYFxmfo Mo3w== X-Gm-Message-State: AKGB3mJol4GaxFy7sqOEEwB24LrJ1s/xfdnroH6tDn7mkPKPIpKJzlfz loF62zUpWwIxBwSaDfPw9PE= X-Google-Smtp-Source: ACJfBosL3DoQkYDOuW86797x2h27g3oXadNHAUAxQURy8XHYXt5BoikvXP8t6EIQB0JJ9NIKzdwUXA== X-Received: by 10.84.242.134 with SMTP id d6mr24734802pll.98.1514286610042; Tue, 26 Dec 2017 03:10:10 -0800 (PST) Received: from 60-242-179-244.static.tpgi.com.au (60-242-179-244.static.tpgi.com.au. [60.242.179.244]) by smtp.gmail.com with ESMTPSA id u19sm54205444pfh.89.2017.12.26.03.10.08 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 26 Dec 2017 03:10:09 -0800 (PST) From: Jonathan Liu <net147@gmail.com> To: Maxime Ripard <maxime.ripard@free-electrons.com>, David Airlie <airlied@linux.ie>, Chen-Yu Tsai <wens@csie.org> Subject: [PATCH v2 2/3] drm/sun4i: hdmi: Fix incorrect assignment in sun4i_tmds_determine_rate Date: Tue, 26 Dec 2017 22:12:26 +1100 Message-Id: <20171226111227.4526-3-net147@gmail.com> X-Mailer: git-send-email 2.15.0 In-Reply-To: <20171226111227.4526-1-net147@gmail.com> References: <20171226111227.4526-1-net147@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20171226_031020_799544_ED6CBA10 X-CRM114-Status: GOOD ( 10.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: <linux-arm-kernel.lists.infradead.org> List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe> List-Archive: <http://lists.infradead.org/pipermail/linux-arm-kernel/> List-Post: <mailto:linux-arm-kernel@lists.infradead.org> List-Help: <mailto:linux-arm-kernel-request@lists.infradead.org?subject=help> List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe> Cc: linux-arm-kernel@lists.infradead.org, linux-sunxi@googlegroups.com, Jonathan Liu <net147@gmail.com>, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" <linux-arm-kernel-bounces@lists.infradead.org> Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP |
diff --git a/drivers/gpu/drm/sun4i/sun4i_hdmi_tmds_clk.c b/drivers/gpu/drm/sun4i/sun4i_hdmi_tmds_clk.c index 4d235e5ea31c..88eeeaf34638 100644 --- a/drivers/gpu/drm/sun4i/sun4i_hdmi_tmds_clk.c +++ b/drivers/gpu/drm/sun4i/sun4i_hdmi_tmds_clk.c @@ -105,7 +105,7 @@ static int sun4i_tmds_determine_rate(struct clk_hw *hw, if (!best_parent || abs(rate - rounded / i) < abs(rate - best_parent / best_div)) { best_parent = rounded; - best_div = i; + best_div = j; } } }
best_div is set to i which corresponds to rate halving when it should be set to j which corresponds to the divider. Fixes: 9c5681011a0c ("drm/sun4i: Add HDMI support") Signed-off-by: Jonathan Liu <net147@gmail.com> --- drivers/gpu/drm/sun4i/sun4i_hdmi_tmds_clk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)