diff mbox

Nokia N9: add support for up/down keys in the dts

Message ID 20180102125948.GA20051@amd (mailing list archive)
State New, archived
Headers show

Commit Message

Pavel Machek Jan. 2, 2018, 12:59 p.m. UTC
This adds support for volume up/down keys in the dts.

Signed-off-by: Pavel Machek <pavel@ucw.cz>

Comments

Sebastian Reichel Jan. 2, 2018, 7:42 p.m. UTC | #1
Hi,

On Tue, Jan 02, 2018 at 01:59:48PM +0100, Pavel Machek wrote:
> 
> This adds support for volume up/down keys in the dts.
> 
> Signed-off-by: Pavel Machek <pavel@ucw.cz>

Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>

-- Sebastian

> 
> diff --git a/arch/arm/boot/dts/omap3-n9.dts b/arch/arm/boot/dts/omap3-n9.dts
> index 39e35f8..57a6679 100644
> --- a/arch/arm/boot/dts/omap3-n9.dts
> +++ b/arch/arm/boot/dts/omap3-n9.dts
> @@ -11,9 +11,10 @@
>  /dts-v1/;
>  
>  #include "omap3-n950-n9.dtsi"
> +#include <dt-bindings/input/input.h>
>  
>  / {
>  	model = "Nokia N9";
>  	compatible = "nokia,omap3-n9", "ti,omap36xx", "ti,omap3";
>  };
>  
> @@ -72,3 +133,9 @@
>  	st,max-limit-y = <46>;
>  	st,max-limit-z = <46>;
>  };
> +
> +&twl_keypad {
> +	linux,keymap = < MATRIX_KEY(6, 8, KEY_VOLUMEUP)
> +			 MATRIX_KEY(7, 8, KEY_VOLUMEDOWN)
> +			 >;
> +};
> 
> 
> -- 
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Pavel Machek Jan. 18, 2018, 10:03 p.m. UTC | #2
On Tue 2018-01-02 20:42:36, Sebastian Reichel wrote:
> Hi,
> 
> On Tue, Jan 02, 2018 at 01:59:48PM +0100, Pavel Machek wrote:
> > 
> > This adds support for volume up/down keys in the dts.
> > 
> > Signed-off-by: Pavel Machek <pavel@ucw.cz>
> 
> Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>

Tony, ping? Can I get you to apply this one?

[PATCHv2] nokia N9: Add support for magnetometer

should be good to go, too...
									Pavel
									

> > diff --git a/arch/arm/boot/dts/omap3-n9.dts b/arch/arm/boot/dts/omap3-n9.dts
> > index 39e35f8..57a6679 100644
> > --- a/arch/arm/boot/dts/omap3-n9.dts
> > +++ b/arch/arm/boot/dts/omap3-n9.dts
> > @@ -11,9 +11,10 @@
> >  /dts-v1/;
> >  
> >  #include "omap3-n950-n9.dtsi"
> > +#include <dt-bindings/input/input.h>
> >  
> >  / {
> >  	model = "Nokia N9";
> >  	compatible = "nokia,omap3-n9", "ti,omap36xx", "ti,omap3";
> >  };
> >  
> > @@ -72,3 +133,9 @@
> >  	st,max-limit-y = <46>;
> >  	st,max-limit-z = <46>;
> >  };
> > +
> > +&twl_keypad {
> > +	linux,keymap = < MATRIX_KEY(6, 8, KEY_VOLUMEUP)
> > +			 MATRIX_KEY(7, 8, KEY_VOLUMEDOWN)
> > +			 >;
> > +};
> > 
> > 
> > -- 
> > (english) http://www.livejournal.com/~pavelmachek
> > (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
> 
>
Tony Lindgren Jan. 19, 2018, 3:43 p.m. UTC | #3
* Pavel Machek <pavel@ucw.cz> [180118 22:04]:
> On Tue 2018-01-02 20:42:36, Sebastian Reichel wrote:
> > Hi,
> > 
> > On Tue, Jan 02, 2018 at 01:59:48PM +0100, Pavel Machek wrote:
> > > 
> > > This adds support for volume up/down keys in the dts.
> > > 
> > > Signed-off-by: Pavel Machek <pavel@ucw.cz>
> > 
> > Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
> 
> Tony, ping? Can I get you to apply this one?

OK applying that for v4.16 so we have some kind of control of the
device without having to rely on the touch screen :)

> [PATCHv2] nokia N9: Add support for magnetometer
> 
> should be good to go, too...

I have that tagged for next after -rc1 thanks.

Regards,

Tony
Pavel Machek Jan. 28, 2018, 9:16 a.m. UTC | #4
Hi!

> > > > This adds support for volume up/down keys in the dts.
> > > > 
> > > > Signed-off-by: Pavel Machek <pavel@ucw.cz>
> > > 
> > > Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
> > 
> > Tony, ping? Can I get you to apply this one?
> 
> OK applying that for v4.16 so we have some kind of control of the
> device without having to rely on the touch screen :)

Thanks :-).

> > [PATCHv2] nokia N9: Add support for magnetometer
> > 
> > should be good to go, too...
> 
> I have that tagged for next after -rc1 thanks.

Actually, if you could get that one to v4.16, too. There's still lot
of work to be done to get N9 into usable state, and delaying here does
not do any good.

Best regards,
									Pavel
diff mbox

Patch

diff --git a/arch/arm/boot/dts/omap3-n9.dts b/arch/arm/boot/dts/omap3-n9.dts
index 39e35f8..57a6679 100644
--- a/arch/arm/boot/dts/omap3-n9.dts
+++ b/arch/arm/boot/dts/omap3-n9.dts
@@ -11,9 +11,10 @@ 
 /dts-v1/;
 
 #include "omap3-n950-n9.dtsi"
+#include <dt-bindings/input/input.h>
 
 / {
 	model = "Nokia N9";
 	compatible = "nokia,omap3-n9", "ti,omap36xx", "ti,omap3";
 };
 
@@ -72,3 +133,9 @@ 
 	st,max-limit-y = <46>;
 	st,max-limit-z = <46>;
 };
+
+&twl_keypad {
+	linux,keymap = < MATRIX_KEY(6, 8, KEY_VOLUMEUP)
+			 MATRIX_KEY(7, 8, KEY_VOLUMEDOWN)
+			 >;
+};