Message ID | 20180109020323.11852-3-net147@gmail.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show
Return-Path: <linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org> Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id D135760210 for <patchwork-linux-arm@patchwork.kernel.org>; Tue, 9 Jan 2018 02:04:18 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C511228A74 for <patchwork-linux-arm@patchwork.kernel.org>; Tue, 9 Jan 2018 02:04:18 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B9F2128A77; Tue, 9 Jan 2018 02:04:18 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FROM, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 63F7F28A74 for <patchwork-linux-arm@patchwork.kernel.org>; Tue, 9 Jan 2018 02:04:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=ObeXxUN+l95B4wrWGXyRDRNOHYkQBBgj1iXjI+rtLFU=; b=K9KHWYWq+o251yiHANLrmW7gvx QxlrfMcwqLXTx9yDS8cmA9BPtNPPLzevdRinX+Ygd5IRGBi6OqMgMeGGflOOK0OxMos+Ss3/Ev/dr +H2/Voicf0vzccc3YqBG7TqTmwZ0rgYgl27rQjmJXRoOIO2nJu+XNDyj/fE4I8l6/w4RiF1wWaJ1A HgExk8C5DxPrUz5LnBVCw7DkrVycyyq1uFgnDFOa11ZVZwvT3sG3AaipGSph/2CH0BpiN9vXe47HR HQYidVPrYsDGX4edq/Cr7KfHjQGIwa7K2wozHFzf6ypAeK/5bOOKyJiimuVB67w6+sA6FPk2XPO+F POgCYkog==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux)) id 1eYjGx-0000Jj-6P; Tue, 09 Jan 2018 02:04:15 +0000 Received: from mail-pf0-x241.google.com ([2607:f8b0:400e:c00::241]) by bombadil.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux)) id 1eYjGX-0008QW-IT for linux-arm-kernel@lists.infradead.org; Tue, 09 Jan 2018 02:03:55 +0000 Received: by mail-pf0-x241.google.com with SMTP id u19so7414835pfa.12 for <linux-arm-kernel@lists.infradead.org>; Mon, 08 Jan 2018 18:03:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=sVy0957OwxE+dTN9yzaeiHRI15CxCH6h2dNqmLSD6r0=; b=pWIZ63OTnFT9+B72B218FBcF7rGjq7Noay6YCUK+Z6cqYG9V1LWE6vEcQEG3lsigKL 2IKl22I3q912NEIulhDOlOYimELu7PTQZ4264GjPPY0QOEHL4sHNSwRAWT/tf8Y90wE7 Im8mTiJ3flrGfnef9jdMeVlrE3bq32narnkAoYNCfs5ixovHWsyTET2ExIrqQRGHiwdC rI7Jp1opMJP0Dn1GYrb3iszIS0/Vp4vJuaLa42Oh0S/fj2yosMaUbLRtMUpF2wSLZDJ0 UGvciW0FVgYYe1uksFL8BTlpAVoKRdu+2I1lgxBKwEprV1PyMSoSc8EyZ8zNOqlv8quA tvQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=sVy0957OwxE+dTN9yzaeiHRI15CxCH6h2dNqmLSD6r0=; b=H234Kbgq3N3ZRQFAlilLRAjwsWARzvo7XitmKl07HbqG3hRJIxSYptR19nBHjuYS5K jypDLRz3j1Bye+xxmG3+jw5IlfJzb13KpdSJ4vz9MfSlzEOcvj+1tPfEGWLm7XYE9TUl /pAbZ7oLak32O8GlcSIoQJL6aKdLogrOv/NyaX1Uxio3bVu4btj2ShLbVlhML5IT6F+b VI+Ex4PJYkA3KyuEPTYRvLXSsJWmWBvpEyaQjM43KAofXX+qLE3zBwq7ce2qjlaS2rvO hci/J7YE1LUGAbkcE1PYOpYLVTXt/ekcsrPUQZVwuged1GGjvQeiPfIn7ibRQ9WtdDBQ aqQw== X-Gm-Message-State: AKwxyte3o2sA8SKDp6mZJTw6ekp8zbrcW49vrypThyvgYfFJ15IPtRip SVTPdY9jZh1nM8+ymIbkxUg= X-Google-Smtp-Source: ACJfBovAYrY8tQ/0/eFs/H0Kxd/BR0BdZq78cYhzCBuR30/yd6fHy+pTCl0+EujAFXfwOEvuLRjvGA== X-Received: by 10.98.224.205 with SMTP id d74mr182261pfm.56.1515463418776; Mon, 08 Jan 2018 18:03:38 -0800 (PST) Received: from 60-242-179-244.static.tpgi.com.au (60-242-179-244.static.tpgi.com.au. [60.242.179.244]) by smtp.gmail.com with ESMTPSA id y1sm23768366pgc.52.2018.01.08.18.03.37 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 08 Jan 2018 18:03:38 -0800 (PST) From: Jonathan Liu <net147@gmail.com> To: Maxime Ripard <maxime.ripard@free-electrons.com>, David Airlie <airlied@linux.ie>, Chen-Yu Tsai <wens@csie.org> Subject: [PATCH v3 2/3] drm/sun4i: hdmi: Fix incorrect assignment in sun4i_tmds_determine_rate Date: Tue, 9 Jan 2018 13:03:22 +1100 Message-Id: <20180109020323.11852-3-net147@gmail.com> X-Mailer: git-send-email 2.15.1 In-Reply-To: <20180109020323.11852-1-net147@gmail.com> References: <20180109020323.11852-1-net147@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180108_180350_093476_6FC66517 X-CRM114-Status: GOOD ( 10.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: <linux-arm-kernel.lists.infradead.org> List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe> List-Archive: <http://lists.infradead.org/pipermail/linux-arm-kernel/> List-Post: <mailto:linux-arm-kernel@lists.infradead.org> List-Help: <mailto:linux-arm-kernel-request@lists.infradead.org?subject=help> List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe> Cc: linux-arm-kernel@lists.infradead.org, linux-sunxi@googlegroups.com, Jonathan Liu <net147@gmail.com>, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" <linux-arm-kernel-bounces@lists.infradead.org> Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP |
diff --git a/drivers/gpu/drm/sun4i/sun4i_hdmi_tmds_clk.c b/drivers/gpu/drm/sun4i/sun4i_hdmi_tmds_clk.c index 4d235e5ea31c..88eeeaf34638 100644 --- a/drivers/gpu/drm/sun4i/sun4i_hdmi_tmds_clk.c +++ b/drivers/gpu/drm/sun4i/sun4i_hdmi_tmds_clk.c @@ -105,7 +105,7 @@ static int sun4i_tmds_determine_rate(struct clk_hw *hw, if (!best_parent || abs(rate - rounded / i) < abs(rate - best_parent / best_div)) { best_parent = rounded; - best_div = i; + best_div = j; } } }
best_div is set to i which corresponds to rate halving when it should be set to j which corresponds to the divider. Fixes: 9c5681011a0c ("drm/sun4i: Add HDMI support") Signed-off-by: Jonathan Liu <net147@gmail.com> --- drivers/gpu/drm/sun4i/sun4i_hdmi_tmds_clk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)