From patchwork Tue Jan 9 11:06:09 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Miquel Raynal X-Patchwork-Id: 10151755 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 3A8D6603ED for ; Tue, 9 Jan 2018 11:06:42 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3DCF1274D2 for ; Tue, 9 Jan 2018 11:06:42 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 325B328464; Tue, 9 Jan 2018 11:06:42 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 710F4274D2 for ; Tue, 9 Jan 2018 11:06:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4tp3klr23qrF/DYE2dVdHADUyagkuvfNZ9nLXSoQ4TA=; b=bsxPvubBV6fwx6 Ii5uxyiCzF8HI64HVDNTEQI0NKZIPLD5Eo/mVlYcZQD+Jm5UztvmE4WVWfX1Z+Thvsws5cWnwQ+Cx oJg9d7q4mJ++OOpgDYyolYuEcxoO5G8iEKR+rrsE7m6sDOlp2YZfc0GndtgRRakrMbUzSOqTUpf1t YWkwbKKFl8dV423C9wpV1QH9t64f5LcDHyhT8zyHIrk8Qi1ieLCsFE8ZsR9aJMgbQ3v0YG+mtp/si a3F/U0HMemgtEjMUdD8I3CbbbwJmDkSckV7h0yT1J/EuEQjf7o15bMALmuy2Lcv+bXhXR1M0v2/Bd Sfrom9h+e81z+8BcUAxw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux)) id 1eYrjq-0004Ky-QS; Tue, 09 Jan 2018 11:06:38 +0000 Received: from mail.free-electrons.com ([62.4.15.54]) by bombadil.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux)) id 1eYrjj-000486-LQ; Tue, 09 Jan 2018 11:06:36 +0000 Received: by mail.free-electrons.com (Postfix, from userid 110) id B7973203B4; Tue, 9 Jan 2018 12:06:19 +0100 (CET) Received: from xps13 (LStLambert-657-1-97-87.w90-63.abo.wanadoo.fr [90.63.216.87]) by mail.free-electrons.com (Postfix) with ESMTPSA id 7000920371; Tue, 9 Jan 2018 12:06:09 +0100 (CET) Date: Tue, 9 Jan 2018 12:06:09 +0100 From: Miquel RAYNAL To: Robert Jarzmik Subject: Re: [PATCH 00/12] Marvell NAND controller rework with ->exec_op() Message-ID: <20180109120609.153b6bde@xps13> In-Reply-To: <87zi5nbh14.fsf@belgarion.home> References: <20171207201814.30411-1-miquel.raynal@free-electrons.com> <20171214070930.0b885f6d@bbrezillon> <877etkecig.fsf@belgarion.home> <20171218092535.2ca1fe13@xps13> <87y3lxccr7.fsf@belgarion.home> <20171220224121.2cb6f690@bbrezillon> <87lghucykr.fsf@belgarion.home> <20171222222441.0fd77df9@bbrezillon> <20171222233730.68d9cb9d@xps13> <87k1xdblxf.fsf@belgarion.home> <20171223155709.2ba16e95@xps13> <87fu81bc45.fsf@belgarion.home> <20180102120326.7a2cf1d1@xps13> <87d12scbiy.fsf@belgarion.home> <20180103084037.422b239a@xps13> <878tded89m.fsf@belgarion.home> <20180103211028.619cd16d@bbrezillon> <20180103215206.5d85b41b@bbrezillon> <87zi5nbh14.fsf@belgarion.home> Organization: Free Electrons X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180109_030632_448836_AAE0A06F X-CRM114-Status: GOOD ( 12.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Boris Brezillon , linux-mtd@lists.infradead.org, Ezequiel Garcia , Brian Norris , David Woodhouse , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Hello Robert, On Tue, 09 Jan 2018 08:57:59 +0100 Robert Jarzmik wrote: > Boris Brezillon writes: > > Ok I recovered my NAND. > > For the next try, I'd like you to provide another "temporary patch" > to disable BBT actual writing, just to be sure. Once the driver is > working properly, I'll make another try without the temporary patch. The best way to do it is to avoid using the BBT at all, and while I was looking for the right line to comment in the Zylonite's board file I found out that the boolean flash_bbt is not actually set and then I remembered an old mail from you, then you should: ----->8----- Then, do not forget to resize the partition that stores the BBT to remove the last 4 erase blocks from it to avoid UBI/UBIFS smashing it. Then you should be fine. You can test this branch (updated with last version I sent earlier): https://github.com/miquelraynal/linux/tree/marvell/nand-next/nfc Thanks, Miquèl diff --git a/arch/arm/mach-pxa/zylonite.c b/arch/arm/mach-pxa/zylonite.c index 0534949d63f6..d247ef01dc62 100644 --- a/arch/arm/mach-pxa/zylonite.c +++ b/arch/arm/mach-pxa/zylonite.c @@ -378,6 +378,8 @@ static struct mtd_partition zylonite_nand_partitions[] = { static struct pxa3xx_nand_platform_data zylonite_nand_info = { .parts = zylonite_nand_partitions, .nr_parts = ARRAY_SIZE(zylonite_nand_partitions), - .flash_bbt = 1, .keep_config = 1, }; static void __init zylonite_init_nand(void) -----8<-----