From patchwork Wed Feb 7 21:17:04 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Jernej_=C5=A0krabec?= X-Patchwork-Id: 10206197 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 16F3560327 for ; Wed, 7 Feb 2018 22:09:03 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F1DA628F76 for ; Wed, 7 Feb 2018 22:09:02 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E56FE28F86; Wed, 7 Feb 2018 22:09:02 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id BCD8328F78 for ; Wed, 7 Feb 2018 22:09:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=CV1MLe91YZ9wIZiI2faeNf22x2n9iTYTI3HJIg/pTgg=; b=qtdF/ExV0JlV4aKvZZGwtw52uN 31kMnkwXlbs/AoiXgTBpCy/WHKq8Wj8NIWSUvrs552H9W+y2dTb6Wr3Zi+z/ZXHkLjuQXqJs5TeF7 IicbxDjN3PF8h7lBynCeaJx5Hy5XeNNiC8mDfVUyDla2v3EnrPyn1qpExmj107svHyxszfVsCHpm+ K2cKf2lwO9dPf/Q2vSWSYmd3j2xmF+8oZn1kGpZtZpM3lLsWcrrG+VhxLrXsajdvXcbZhlGiz1qgz TDLyz4Aem/hEBHcnm0Gcpba18sfQnpkYBHTo3wPSSi7mJdouBwQAmognfXA1bKhzxZP1MuAqsS6SZ MSLrLuuQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux)) id 1ejXtj-0000G7-9M; Wed, 07 Feb 2018 22:08:59 +0000 Received: from merlin.infradead.org ([2001:8b0:10b:1231::1]) by bombadil.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux)) id 1ejXth-0000G0-Qv for linux-arm-kernel@bombadil.infradead.org; Wed, 07 Feb 2018 22:08:57 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=MXmewsbWlGm/qpDOJJhqsYYPA2KM4PvOin4piwz4LS4=; b=MdSzAZsO8x5Qu+o5i/Tmo0jXR j2I3XXHVa9n/0hmR3Kbq2LBp/0jX5HxggoDhpkOcXNlfbTzwMl3RMyPGfguchkfzaGfgol1hxqoEq 0vHO616RoCp1wffAoOMB2p/FMOr1rxyHPuN7ni4X9PlC7QNMwP/ATZEBnZGfFWDIzZawJfJNPhQ3c F1YTHe02Nb8ALwBC9rS66J6xSK6UByOEfdMbsRSLzd6yO01UGSb7Tg1sQFRGaXlCM7cSEHZdR1y71 Z2JhSd5KrW9tfaGlE1SmDJ7GKvEcY6yvUPOOuYOuc8nXjIMEXUlN2TiBWx/eGDh2dATVfgQNDlxeo FP1TJu4vA==; Received: from mailoutvs4.siol.net ([213.250.19.137] helo=mail.siol.net) by merlin.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux)) id 1ejX6N-0005ei-AM for linux-arm-kernel@lists.infradead.org; Wed, 07 Feb 2018 21:18:02 +0000 Received: from localhost (localhost [127.0.0.1]) by mail.siol.net (Postfix) with ESMTP id 70796522E4A; Wed, 7 Feb 2018 22:17:31 +0100 (CET) X-Virus-Scanned: amavisd-new at psrvmta10.zcs-production.pri Received: from mail.siol.net ([127.0.0.1]) by localhost (psrvmta10.zcs-production.pri [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id LPJBvYdVLHkv; Wed, 7 Feb 2018 22:17:31 +0100 (CET) Received: from mail.siol.net (localhost [127.0.0.1]) by mail.siol.net (Postfix) with ESMTPS id B06CA522E36; Wed, 7 Feb 2018 22:17:30 +0100 (CET) Received: from localhost.localdomain (cpe-86-58-68-135.ftth.triera.net [86.58.68.135]) (Authenticated sender: 031275009) by mail.siol.net (Postfix) with ESMTPSA id 49F49522E4A; Wed, 7 Feb 2018 22:17:28 +0100 (CET) From: Jernej Skrabec To: maxime.ripard@free-electrons.com, wens@csie.org, airlied@linux.ie, robh+dt@kernel.org, mark.rutland@arm.com, mturquette@baylibre.com, sboyd@kernel.org, architt@codeaurora.org, a.hajda@samsung.com, Laurent.pinchart@ideasonboard.com, narmstrong@baylibre.com, Jose.Abreu@synopsys.com Subject: [PATCH v4 03/12] drm/bridge/synopsys: dw-hdmi: Enable workaround for v1.32a Date: Wed, 7 Feb 2018 22:17:04 +0100 Message-Id: <20180207211713.3638-4-jernej.skrabec@siol.net> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180207211713.3638-1-jernej.skrabec@siol.net> References: <20180207211713.3638-1-jernej.skrabec@siol.net> X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, jernej.skrabec@siol.net, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-sunxi@googlegroups.com, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Allwinner SoCs have dw hdmi controller v1.32a which exhibits same magenta line issue as i.MX6Q and i.MX6DL. Enable workaround for it. Tests show that one iteration is enough. Acked-by: Laurent Pinchart Signed-off-by: Jernej Skrabec --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c index a38db40ce990..7ca14d7325b5 100644 --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c @@ -1634,9 +1634,10 @@ static void dw_hdmi_clear_overflow(struct dw_hdmi *hdmi) * then write one of the FC registers several times. * * The number of iterations matters and depends on the HDMI TX revision - * (and possibly on the platform). So far only i.MX6Q (v1.30a) and - * i.MX6DL (v1.31a) have been identified as needing the workaround, with - * 4 and 1 iterations respectively. + * (and possibly on the platform). So far i.MX6Q (v1.30a), i.MX6DL + * (v1.31a) and multiple Allwinner SoCs (v1.32a) have been identified + * as needing the workaround, with 4 iterations for v1.30a and 1 + * iteration for others. */ switch (hdmi->version) { @@ -1644,6 +1645,7 @@ static void dw_hdmi_clear_overflow(struct dw_hdmi *hdmi) count = 4; break; case 0x131a: + case 0x132a: count = 1; break; default: