From patchwork Wed Feb 14 16:10:36 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin King X-Patchwork-Id: 10219369 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 6E0DA601D7 for ; Wed, 14 Feb 2018 16:12:19 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5653E29000 for ; Wed, 14 Feb 2018 16:12:19 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 54775289D6; Wed, 14 Feb 2018 16:12:19 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id B7D752956F for ; Wed, 14 Feb 2018 16:11:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=XW3FOD3FCPL4C6JqTCKyqa1LW1oxxY4lAVzbMc9efm8=; b=G3ggspmcnqAEjt JZmXw94lwAPZRy0nwcXv12h2PigPa5cPMyitQuDPuC5FRwCrhXkuidHvXrJXpr8PMG7eWQcBkFzD8 oxklpP4jZUFRl0rYF5zNZLUNcxX+I7IxOtr7IdOVJgFvBDzT4hnFo7lXd3LgQknMnwQS0bVkRlBwR hIEFR4AGDx6HC53UN4uHMz2C7uhSdxsv79vmAhzY/goQ0gGbd/Q5dIMsSlU2E/e5f+nQBMzqffoGC ejAaSeU8jkQv+z7ac0NmF2+bnPmtSmxUTV0b4qAuoHvsiDTSagCC9ryo1m/V+FCA6ThM3Ni9LZbsC cfgu84G5YCcnWIEAzQuw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux)) id 1elzeG-0007La-OL; Wed, 14 Feb 2018 16:11:08 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by bombadil.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux)) id 1elzeB-0007GM-Ou for linux-arm-kernel@lists.infradead.org; Wed, 14 Feb 2018 16:11:05 +0000 Received: from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.76) (envelope-from ) id 1elzdl-0000PV-7E; Wed, 14 Feb 2018 16:10:37 +0000 From: Colin King To: Katsuhiro Suzuki , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Masahiro Yamada , alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH][next] ASoC: uniphier: remove redundant check of blk_id Date: Wed, 14 Feb 2018 16:10:36 +0000 Message-Id: <20180214161036.32446-1-colin.king@canonical.com> X-Mailer: git-send-email 2.15.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180214_081103_974017_BF88400F X-CRM114-Status: UNSURE ( 7.69 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP From: Colin Ian King The check of blk_id == AUD_CLK_IO is redundant as it also being performed in the following switch statement with the same return of -ENOTSUPP. Fix this by removing the redundant comparison. Detected by CoverityScan, CID#1465227 ("Logically dead code") Signed-off-by: Colin Ian King --- sound/soc/uniphier/aio-cpu.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/sound/soc/uniphier/aio-cpu.c b/sound/soc/uniphier/aio-cpu.c index 55f3248a31fd..7cf2316c69a2 100644 --- a/sound/soc/uniphier/aio-cpu.c +++ b/sound/soc/uniphier/aio-cpu.c @@ -134,9 +134,6 @@ static int uniphier_aio_set_sysclk(struct snd_soc_dai *dai, int clk_id, bool pll_auto = false; int pll_id, div_id; - if (clk_id == AUD_CLK_IO) - return -ENOTSUPP; - switch (clk_id) { case AUD_CLK_IO: return -ENOTSUPP;