From patchwork Fri Feb 23 13:31:14 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rasmus Villemoes X-Patchwork-Id: 10237689 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 09E2A602DC for ; Fri, 23 Feb 2018 13:32:02 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EDD1C295CF for ; Fri, 23 Feb 2018 13:32:01 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E283C295D5; Fri, 23 Feb 2018 13:32:01 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 6F087295CF for ; Fri, 23 Feb 2018 13:32:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=malp9GviaAFt9w6AVRqTg5JNotr/iXub0UgC6WZlQcc=; b=Nm4mGqmG5Kohdp whUGi67DvEOn/L1LYgAVkvE57dSZ9SvWttjxzmby5UnJnq8TnEZbaJjmZWK2DR+ehsQ0I8A/CwCWl avZbguGJx1PR2J1WJy76WYlVv4LykfNNGEIjoPI40OfS1n0dtf2GOEnxH7e9ImR/0rso6DIV7D615 JeG0ADfUUZ6KadzMHOIrx7DTLXth9Lz5R3aA08YanaFTq27TNhEH/urNQpnUttQXkOgcj/f4GqlTx aLWrNZbbg3bHkcf6wqMe7WLmuEH8PvUZaKXwX8oevcA2ZUU6jkN/WHyTRIDY1A096Ml/04q67eIN6 ka95rLS2Xfd/WOu3kjNQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux)) id 1epDRx-0000kw-7U; Fri, 23 Feb 2018 13:31:45 +0000 Received: from mail01.prevas.se ([62.95.78.3]) by bombadil.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux)) id 1epDRt-0000jD-6H for linux-arm-kernel@lists.infradead.org; Fri, 23 Feb 2018 13:31:42 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=prevas.dk; i=@prevas.dk; l=1804; q=dns/txt; s=ironport1; t=1519392701; x=1550928701; h=from:to:cc:subject:date:message-id:mime-version; bh=nABdyv6r6dVnTpTAI1QAhwjmAL4lTMJR4w0iIMD8SF4=; b=jAvj/HjVlgyBwPRtWmSfmDG5Tjcn8CINJGmDAqPa8rQu2UzT+KUL1f+b o3cuIn8Tci75T4CPzBo77aFGaDjoT0UyAq4ZzLWwaWaoSEY95/RrEhGpi EMcgMGc9Phx0V5XawHsVfRbtwmQUe/ckOpb+v+OiC17cZqzHTNItTOWfp 4=; X-IronPort-AV: E=Sophos;i="5.47,383,1515452400"; d="scan'208";a="3297971" Received: from vmprevas3.prevas.se (HELO smtp.prevas.se) ([172.16.8.103]) by ironport1.prevas.se with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Feb 2018 14:31:25 +0100 Received: from prevas-ravi.prevas.se (172.16.8.31) by smtp.prevas.se (172.16.8.103) with Microsoft SMTP Server (TLS) id 14.3.361.1; Fri, 23 Feb 2018 14:31:25 +0100 From: Rasmus Villemoes To: Shawn Guo , Rob Herring , "Mark Rutland" , Russell King Subject: [RFC PATCH] ARM: dts: ls1021a: add size-cells and address-cells to scfg and dcfg nodes Date: Fri, 23 Feb 2018 14:31:14 +0100 Message-ID: <20180223133114.7091-1-rasmus.villemoes@prevas.dk> X-Mailer: git-send-email 2.15.1 MIME-Version: 1.0 X-Originating-IP: [172.16.8.31] X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180223_053141_573489_817CE626 X-CRM114-Status: GOOD ( 14.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Rasmus Villemoes Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP A single u32 is sufficient to specify a register in the Device Configuration Unit/Supplemental Configuration Unit. Moreover, they only consist of 32 bit registers (for the DCFG we even have "These registers only support 32-bit accesses." according to the reference manual), so no size specification is needed. Signed-off-by: Rasmus Villemoes --- None of the in-tree .dts files using ls1021a.dtsi currently define a subnode of either node. It is possible, though somewhat unlikely, that some out-of-tree .dts file is built against the in-tree ls1021a.dtsi, and I don't know if such files are treated the same as out-of-tree modules (i.e., they get to fix the breakage). The reason I'm proposing to add these is that I'm about to add a subnode of scfg with a reg property, and if possible I'd like to avoid the somewhat clumsy reg = <0 0x1ac 0 4>; when reg = <0x1ac>; would convey the same information. But if the #address-cells and #size-cells properties are set in stone once the .dtsi is in mainline, I'll just accept the clumsiness. arch/arm/boot/dts/ls1021a.dtsi | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/arm/boot/dts/ls1021a.dtsi index c31dad98f989..3c9fadcd611d 100644 --- a/arch/arm/boot/dts/ls1021a.dtsi +++ b/arch/arm/boot/dts/ls1021a.dtsi @@ -159,6 +159,8 @@ dcfg: dcfg@1ee0000 { compatible = "fsl,ls1021a-dcfg", "syscon"; reg = <0x0 0x1ee0000 0x0 0x10000>; + #address-cells = <1>; + #size-cells = <0>; big-endian; }; @@ -202,6 +204,8 @@ scfg: scfg@1570000 { compatible = "fsl,ls1021a-scfg", "syscon"; reg = <0x0 0x1570000 0x0 0x10000>; + #address-cells = <1>; + #size-cells = <0>; big-endian; };