| Message ID | 20180301092420.1191-3-enric.balletbo@collabora.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Enric, Am Donnerstag, 1. März 2018, 10:24:16 CET schrieb Enric Balletbo i Serra: > The extcon property is used to detect the cable-state but some boards, > like Sapphire, currently does not seem to support, others might just not > need, as are supposed to work in host-mode only. So, extcon property is > not really a required property, move to be optional instead. The change itself is justified, the "justification" in the message might need some rework, as this sounds more like a kernel-side issue, while the extcon should always be optional. Something like: The extcon property is used to detect the cable-state but some boards just connect the type-c phy to a regular USB-A connector without any power-delivery and thus no controller reporting the cable-state. So the extcon property is not really a required property, move it to be optional instead. For the change itself: Reviewed-by: Heiko Stuebner <heiko@sntech.de> > Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> > --- > > Documentation/devicetree/bindings/phy/phy-rockchip-typec.txt | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/phy/phy-rockchip-typec.txt > b/Documentation/devicetree/bindings/phy/phy-rockchip-typec.txt index > 6ea867e3176f..a66f23a01129 100644 > --- a/Documentation/devicetree/bindings/phy/phy-rockchip-typec.txt > +++ b/Documentation/devicetree/bindings/phy/phy-rockchip-typec.txt > @@ -14,6 +14,8 @@ Required properties: > - resets : a list of phandle + reset specifier pairs > - reset-names : string reset name, must be: > "uphy", "uphy-pipe", "uphy-tcphy" > + > +Optional properties: > - extcon : extcon specifier for the Power Delivery > > Note, there are 2 type-c phys for RK3399, and they are almost identical, > except
diff --git a/Documentation/devicetree/bindings/phy/phy-rockchip-typec.txt b/Documentation/devicetree/bindings/phy/phy-rockchip-typec.txt index 6ea867e3176f..a66f23a01129 100644 --- a/Documentation/devicetree/bindings/phy/phy-rockchip-typec.txt +++ b/Documentation/devicetree/bindings/phy/phy-rockchip-typec.txt @@ -14,6 +14,8 @@ Required properties: - resets : a list of phandle + reset specifier pairs - reset-names : string reset name, must be: "uphy", "uphy-pipe", "uphy-tcphy" + +Optional properties: - extcon : extcon specifier for the Power Delivery Note, there are 2 type-c phys for RK3399, and they are almost identical, except
The extcon property is used to detect the cable-state but some boards, like Sapphire, currently does not seem to support, others might just not need, as are supposed to work in host-mode only. So, extcon property is not really a required property, move to be optional instead. Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> --- Documentation/devicetree/bindings/phy/phy-rockchip-typec.txt | 2 ++ 1 file changed, 2 insertions(+)