| Message ID | 20180301101837.27969-10-jeffy.chen@rock-chips.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Mar 01, 2018 at 06:18:32PM +0800, Jeffy Chen wrote: > Add clock property, since we are going to control clocks in rockchip > iommu driver. > > Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com> > --- > > Changes in v6: None Really? There was a different number of clocks before. > Changes in v5: None > Changes in v4: None > Changes in v3: None > Changes in v2: None > > Documentation/devicetree/bindings/iommu/rockchip,iommu.txt | 7 +++++++ > 1 file changed, 7 insertions(+) Reviewed-by: Rob Herring <robh@kernel.org>
Hi Rob, Thanks for your reply. On 03/06/2018 10:27 AM, Rob Herring wrote: > On Thu, Mar 01, 2018 at 06:18:32PM +0800, Jeffy Chen wrote: >> Add clock property, since we are going to control clocks in rockchip >> iommu driver. >> >> Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com> >> --- >> >> Changes in v6: None > > Really? There was a different number of clocks before. hmm, right, forgot to modify the change log, sorry... > >> Changes in v5: None >> Changes in v4: None >> Changes in v3: None >> Changes in v2: None >> >> Documentation/devicetree/bindings/iommu/rockchip,iommu.txt | 7 +++++++ >> 1 file changed, 7 insertions(+) > > Reviewed-by: Rob Herring <robh@kernel.org> > > >
diff --git a/Documentation/devicetree/bindings/iommu/rockchip,iommu.txt b/Documentation/devicetree/bindings/iommu/rockchip,iommu.txt index 2098f7732264..6ecefea1c6f9 100644 --- a/Documentation/devicetree/bindings/iommu/rockchip,iommu.txt +++ b/Documentation/devicetree/bindings/iommu/rockchip,iommu.txt @@ -14,6 +14,11 @@ Required properties: "single-master" device, and needs no additional information to associate with its master device. See: Documentation/devicetree/bindings/iommu/iommu.txt +- clocks : A list of clocks required for the IOMMU to be accessible by + the host CPU. +- clock-names : Should contain the following: + "iface" - Main peripheral bus clock (PCLK/HCL) (required) + "aclk" - AXI bus clock (required) Optional properties: - rockchip,disable-mmu-reset : Don't use the mmu reset operation. @@ -27,5 +32,7 @@ Example: reg = <0xff940300 0x100>; interrupts = <GIC_SPI 16 IRQ_TYPE_LEVEL_HIGH>; interrupt-names = "vopl_mmu"; + clocks = <&cru ACLK_VOP1>, <&cru HCLK_VOP1>; + clock-names = "aclk", "iface"; #iommu-cells = <0>; };
Add clock property, since we are going to control clocks in rockchip iommu driver. Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com> --- Changes in v6: None Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: None Documentation/devicetree/bindings/iommu/rockchip,iommu.txt | 7 +++++++ 1 file changed, 7 insertions(+)