From patchwork Fri Mar 2 17:03:10 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miquel Raynal X-Patchwork-Id: 10255209 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 7BFAF60211 for ; Fri, 2 Mar 2018 17:04:36 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6B8DA2580E for ; Fri, 2 Mar 2018 17:04:36 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6061525D99; Fri, 2 Mar 2018 17:04:36 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id D3A6E2580E for ; Fri, 2 Mar 2018 17:04:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=3oOSWNwN7fm4eQ5SiNWGxfNarvkLbtHpoAa9J9o0zjI=; b=gx1bj8aRdNegRJf6EmP22WMgxj zYreETGFUVWaaP5EEng5j5/98nnoN/RtURrIgKGjtfCLONnjBBE38oTI+6KaEFadpZ78KHQ12zReR c44rpx+cuJq2yb823EMk8YRMZwLGaodT9YqrOsoqPwv1JgRdmXSa0ueoKJziCWzjykJrQRA5xFyGk +2Mu4CVqgGVjoVQzDhsTFDhSnA0j3yTZJwPYxfkZFwXZmbjbK29/XtI11cCn6lGlJqPM3+McUqxrv dq5uO5f4sIJfmx7BNOJfghUU7Kv39GVQJcLL9HI5xy8OIMrdOQp2k1/E+KSmKqQWo/MIjdyEV1HLN mvaXU65A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux)) id 1ero6f-0002ao-HF; Fri, 02 Mar 2018 17:04:29 +0000 Received: from mail.bootlin.com ([62.4.15.54]) by bombadil.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux)) id 1ero6Y-0002Xx-TW; Fri, 02 Mar 2018 17:04:25 +0000 Received: by mail.bootlin.com (Postfix, from userid 110) id 4EFD6207EF; Fri, 2 Mar 2018 18:04:11 +0100 (CET) Received: from localhost.localdomain (unknown [91.224.148.103]) by mail.bootlin.com (Postfix) with ESMTPSA id 722BD2036E; Fri, 2 Mar 2018 18:04:10 +0100 (CET) From: Miquel Raynal To: Boris Brezillon , Richard Weinberger , David Woodhouse , Brian Norris , Marek Vasut , Cyrille Pitchen , Josh Wu , Kamal Dasu , Harvey Hunt , Stefan Agner Subject: [PATCH 02/52] mtd: rawnand: bf5xx: fix probe function error path Date: Fri, 2 Mar 2018 18:03:10 +0100 Message-Id: <20180302170400.6712-3-miquel.raynal@bootlin.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20180302170400.6712-1-miquel.raynal@bootlin.com> References: <20180302170400.6712-1-miquel.raynal@bootlin.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180302_090423_273426_2C047ECA X-CRM114-Status: GOOD ( 10.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Miquel Raynal MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP An error after nand_scan_tail() should trigger a nand_release(). The helper mtd_device_register() (wrapped by bf5xx_nand_add_partition()) returns an error code that should be checked and nand_release() called accordingly. Signed-off-by: Miquel Raynal --- drivers/mtd/nand/raw/bf5xx_nand.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/mtd/nand/raw/bf5xx_nand.c b/drivers/mtd/nand/raw/bf5xx_nand.c index 9a1d8d104570..da7a6083b0e5 100644 --- a/drivers/mtd/nand/raw/bf5xx_nand.c +++ b/drivers/mtd/nand/raw/bf5xx_nand.c @@ -831,11 +831,16 @@ static int bf5xx_nand_probe(struct platform_device *pdev) #endif /* add NAND partition */ - bf5xx_nand_add_partition(info); + err = bf5xx_nand_add_partition(info); + if (err) + goto out_err_release_nand; dev_dbg(&pdev->dev, "initialised ok\n"); + return 0; +out_err_release_nand: + nand_release(mtd); out_err_nand_scan: bf5xx_nand_dma_remove(info); out_err: