From patchwork Fri Mar 2 17:03:47 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miquel Raynal X-Patchwork-Id: 10255293 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id BD2376037F for ; Fri, 2 Mar 2018 17:39:22 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A6A3E27816 for ; Fri, 2 Mar 2018 17:39:22 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9A12C27853; Fri, 2 Mar 2018 17:39:22 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 3666627816 for ; Fri, 2 Mar 2018 17:39:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=i4d2sx8v0gC3n+iFnZw0vglvIFiqKcQjpoyULQZingo=; b=dKfYmk6jxRAvgkyhzK8RB+n+tW RIKoYLIuNCpFQiPsZe9L7qt4Ls63sMPj95OMrs5JJt2SejmnKnlnu2/fmXvk2KuOawr6OEqxQMdsa ignFc1ytMec9UTaRblcYjhEXbRHodcv2TOH0JhkkR0X+xT4ZuE2DBbDaONdMN1IelUmmmkYXOarsP +hgdp347pea451UO3kSj5XSSoH+1daiNDtSiCIRhVIq6xv27p3NRUXnNaKzcUjnu83H4eB/cIcWuV IOyeXwa/4nOpNUrx9D6eW9yYUGW1stxg2LRQkVAl98gmz/h4YM3j5LKh9ZjKNm/tqNwHA4dPTMRrm ImnBxKZw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux)) id 1eroeI-00080F-9f; Fri, 02 Mar 2018 17:39:14 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux)) id 1eroAA-0005sL-Lg; Fri, 02 Mar 2018 17:08:06 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=XduT54gds9Qec+j7Hkh+ev0+h2C7Z0BALcUH2MK4dX0=; b=sLdum3j0Kt+lHv74rd0+4K28Y 4ryIcmDd8apGkWxpk7CuSS9hFClXXJ/LrgjtJ7zckbOFSUsaa/bzxat1K228pu/ryAzMXcME9slH6 Wj8Tj287ICRcD4V9cJvmMw4RYF48iS1XZ+cXV696YHn/RtlP0fEUuqXDDgXmQlYu8G4yvIbm5klKx JuCnhkuOePNGvjooIT/JhRm9RnL0uljgKDdbyEcJhalL9JLAwpz2xisqT8dxltTtfJPktQUJvA3Vq 4XDJ7iOk3zVwifiAjvUkxT1RldZrIdcnPY54HUpZQjxPPjTUr03k8EEFotiuYuHiKCOKqcYqj5gCP qwxOGP7oA==; Received: from mail.bootlin.com ([62.4.15.54]) by casper.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux)) id 1ero7B-0005ra-Gy; Fri, 02 Mar 2018 17:05:02 +0000 Received: by mail.bootlin.com (Postfix, from userid 110) id 87A31209F6; Fri, 2 Mar 2018 18:04:38 +0100 (CET) Received: from localhost.localdomain (unknown [91.224.148.103]) by mail.bootlin.com (Postfix) with ESMTPSA id 984AF207F2; Fri, 2 Mar 2018 18:04:37 +0100 (CET) From: Miquel Raynal To: Boris Brezillon , Richard Weinberger , David Woodhouse , Brian Norris , Marek Vasut , Cyrille Pitchen , Josh Wu , Kamal Dasu , Harvey Hunt , Stefan Agner Subject: [PATCH 39/52] mtd: rawnand: tango: fix probe function error path Date: Fri, 2 Mar 2018 18:03:47 +0100 Message-Id: <20180302170400.6712-40-miquel.raynal@bootlin.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20180302170400.6712-1-miquel.raynal@bootlin.com> References: <20180302170400.6712-1-miquel.raynal@bootlin.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180302_170501_582930_B9D0539A X-CRM114-Status: GOOD ( 13.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Miquel Raynal MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP An error after nand_scan_tail() should trigger a nand_release(). Signed-off-by: Miquel Raynal --- drivers/mtd/nand/raw/tango_nand.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/mtd/nand/raw/tango_nand.c b/drivers/mtd/nand/raw/tango_nand.c index c5bee00b7f5e..69e5eb136edc 100644 --- a/drivers/mtd/nand/raw/tango_nand.c +++ b/drivers/mtd/nand/raw/tango_nand.c @@ -591,8 +591,10 @@ static int chip_init(struct device *dev, struct device_node *np) tchip->bb_cfg = BB_CFG(mtd->writesize, BBM_SIZE); err = mtd_device_register(mtd, NULL, 0); - if (err) + if (err) { + nand_release(mtd); return err; + } nfc->chips[cs] = tchip;