| Message ID | 20180312161050.7647-2-harald@ccbib.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 12/03/18 16:10, Harald Geyer wrote: > Add the proper pin group node to reference in board files. > > Signed-off-by: Harald Geyer <harald@ccbib.org> That looks correct to me, so: Reviewed-by: Andre Przywara <andre.przywara@arm.com> But out of curiosity, what is this used for? In patch 5/5 I see it being used, but without a clue for what? Shouldn't enabling an I2C node be accompanied by some child node, presenting the device on the bus? I guess this I2C is not on some kind of "header" on that laptop? Cheers, Andre. > --- > arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > index 1b6dc31e7d91..64e452a758fa 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > @@ -309,6 +309,11 @@ > interrupt-controller; > #interrupt-cells = <3>; > > + i2c0_pins: i2c0_pins { > + pins = "PH0", "PH1"; > + function = "i2c0"; > + }; > + > i2c1_pins: i2c1_pins { > pins = "PH2", "PH3"; > function = "i2c1"; >
André Przywara writes: > On 12/03/18 16:10, Harald Geyer wrote: > > Add the proper pin group node to reference in board files. > > > > Signed-off-by: Harald Geyer <harald@ccbib.org> > > That looks correct to me, so: > > Reviewed-by: Andre Przywara <andre.przywara@arm.com> > > But out of curiosity, what is this used for? In patch 5/5 I see it being > used, but without a clue for what? Shouldn't enabling an I2C node be > accompanied by some child node, presenting the device on the bus? > I guess this I2C is not on some kind of "header" on that laptop? I enabled it because the ANX6345 eDP-bridge is on that bus. There is no linux (mainline) driver for this chip at the moment, the bootloader initializes it. However I'm using the i2c-dev driver to read (and maybe) change some register values from user space. i2cdetect sees devices at 0x38, 0x39 and 0x3d - all of which might be the ANX6345. I haven't looked into this in detail. Since you are asking: Actually the teres has a "header" with usb-otg, spi, i2c1 and some gpios, but it isn't exposed on the exterior of the case and nothing is connected to it. So I didn't bother with adding nodes for this in DT. Curious what olimex are planning to do with that. Thanks for your review, Harald > Cheers, > Andre. > > > --- > > arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > > index 1b6dc31e7d91..64e452a758fa 100644 > > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > > @@ -309,6 +309,11 @@ > > interrupt-controller; > > #interrupt-cells = <3>; > > > > + i2c0_pins: i2c0_pins { > > + pins = "PH0", "PH1"; > > + function = "i2c0"; > > + }; > > + > > i2c1_pins: i2c1_pins { > > pins = "PH2", "PH3"; > > function = "i2c1"; > > >
On Tue, Mar 13, 2018 at 09:46:51AM +0100, Harald Geyer wrote: > André Przywara writes: > > On 12/03/18 16:10, Harald Geyer wrote: > > > Add the proper pin group node to reference in board files. > > > > > > Signed-off-by: Harald Geyer <harald@ccbib.org> > > > > That looks correct to me, so: > > > > Reviewed-by: Andre Przywara <andre.przywara@arm.com> > > > > But out of curiosity, what is this used for? In patch 5/5 I see it being > > used, but without a clue for what? Shouldn't enabling an I2C node be > > accompanied by some child node, presenting the device on the bus? > > I guess this I2C is not on some kind of "header" on that laptop? > > I enabled it because the ANX6345 eDP-bridge is on that bus. There is > no linux (mainline) driver for this chip at the moment, the bootloader > initializes it. However I'm using the i2c-dev driver to read (and maybe) > change some register values from user space. > > i2cdetect sees devices at 0x38, 0x39 and 0x3d - all of which might > be the ANX6345. I haven't looked into this in detail. That's alright then, just put a comment in the DT on what this bus is used for. Thanks! Maxime
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi index 1b6dc31e7d91..64e452a758fa 100644 --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi @@ -309,6 +309,11 @@ interrupt-controller; #interrupt-cells = <3>; + i2c0_pins: i2c0_pins { + pins = "PH0", "PH1"; + function = "i2c0"; + }; + i2c1_pins: i2c1_pins { pins = "PH2", "PH3"; function = "i2c1";
Add the proper pin group node to reference in board files. Signed-off-by: Harald Geyer <harald@ccbib.org> --- arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 5 +++++ 1 file changed, 5 insertions(+)