diff mbox

ARM: dts: exynos: Add #sound-dai-cells property to exynos5250 i2s nodes

Message ID 20180313171220.26333-1-s.nawrocki@samsung.com (mailing list archive)
State New, archived
Headers show

Commit Message

Sylwester Nawrocki/Kernel \(PLT\) /SRPOL/Staff Engineer/Samsung Electronics March 13, 2018, 5:12 p.m. UTC 
The #sound-dai-cells property may be required to reference the CPU DAI
properly. This change is required for Snow HDMI audio.

Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
---
 arch/arm/boot/dts/exynos5250.dtsi | 3 +++
 1 file changed, 3 insertions(+)

Comments

Sylwester Nawrocki/Kernel \(PLT\) /SRPOL/Staff Engineer/Samsung Electronics March 14, 2018, 10:10 a.m. UTC | #1 
On 03/13/2018 06:12 PM, Sylwester Nawrocki wrote:
> The #sound-dai-cells property may be required to reference the CPU DAI
> properly. This change is required for Snow HDMI audio.
> 
> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>

There is

Reported-by: Marek Szyprowski <m.szyprowski@samsung.com>

tag missing here.

> ---
>  arch/arm/boot/dts/exynos5250.dtsi | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
> index ebc79114b0ce..45283a6c5eee 100644
> --- a/arch/arm/boot/dts/exynos5250.dtsi
> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> @@ -499,6 +499,7 @@
>  			pinctrl-0 = <&i2s0_bus>;
>  			power-domains = <&pd_mau>;
>  			#clock-cells = <1>;
> +			#sound-dai-cells = <1>;
>  		};
>  
>  		i2s1: i2s@12d60000 {
> @@ -513,6 +514,7 @@
>  			pinctrl-names = "default";
>  			pinctrl-0 = <&i2s1_bus>;
>  			power-domains = <&pd_mau>;
> +			#sound-dai-cells = <1>;
>  		};
>  
>  		i2s2: i2s@12d70000 {
> @@ -527,6 +529,7 @@
>  			pinctrl-names = "default";
>  			pinctrl-0 = <&i2s2_bus>;
>  			power-domains = <&pd_mau>;
> +			#sound-dai-cells = <1>;
>  		};
>  
>  		usb_dwc3 {
>
Krzysztof Kozlowski March 14, 2018, 7:15 p.m. UTC | #2 
On Wed, Mar 14, 2018 at 11:10:48AM +0100, Sylwester Nawrocki wrote:
> On 03/13/2018 06:12 PM, Sylwester Nawrocki wrote:
> > The #sound-dai-cells property may be required to reference the CPU DAI
> > properly. This change is required for Snow HDMI audio.
> > 
> > Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> 
> There is
> 
> Reported-by: Marek Szyprowski <m.szyprowski@samsung.com>
> 
> tag missing here.
> 

Thanks, applied with Marek's tag.

Best regards,
Krzysztof
diff mbox

Patch

diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
index ebc79114b0ce..45283a6c5eee 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -499,6 +499,7 @@ 
 			pinctrl-0 = <&i2s0_bus>;
 			power-domains = <&pd_mau>;
 			#clock-cells = <1>;
+			#sound-dai-cells = <1>;
 		};
 
 		i2s1: i2s@12d60000 {
@@ -513,6 +514,7 @@ 
 			pinctrl-names = "default";
 			pinctrl-0 = <&i2s1_bus>;
 			power-domains = <&pd_mau>;
+			#sound-dai-cells = <1>;
 		};
 
 		i2s2: i2s@12d70000 {
@@ -527,6 +529,7 @@ 
 			pinctrl-names = "default";
 			pinctrl-0 = <&i2s2_bus>;
 			power-domains = <&pd_mau>;
+			#sound-dai-cells = <1>;
 		};
 
 		usb_dwc3 {