From patchwork Sun Mar 25 18:09:54 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Agner X-Patchwork-Id: 10306815 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id E99A760212 for ; Sun, 25 Mar 2018 22:17:25 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CD80429352 for ; Sun, 25 Mar 2018 22:17:25 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C1CB9293F8; Sun, 25 Mar 2018 22:17:25 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 3375E293F0 for ; Sun, 25 Mar 2018 22:17:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=r7A03cNIsiidhebcAQjC7791AoXP/xVltN+HzxnrDVE=; b=SZ2Nej6ah6so5fFeDiVCAlNznz YL5I8m2a89H+BOvm8np8ChpgPy7pFoSur4xklKVh9UWYBuDnvbLTxuxGiN2zFqUKTTXI34XheiMTZ XoFjbeAgo78a+8J4hVPnyIdsUqaw0bUwlaMGCqB8ueEzQhfypi+qJ0uBGxw5C7FQWre6iRYvGmUHu QAAqn1c49g39ao7v4mMaQGxeFVYQ35Kq8t/SQMHBh7ERqbSsFet+/tcGmvEzcZC29ggjHHnD1FZk3 kOh2zB0SLlxc789/OToSVYZVWk5arC6yghpGAW3E0sA+qsrQYBkeoaPMqVWeaTDrtlTab9yD+ZqOf flcyx8OA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1f0Dwz-0001Z6-KR; Sun, 25 Mar 2018 22:17:17 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1f0Dpu-0000cp-ES for linux-arm-kernel@bombadil.infradead.org; Sun, 25 Mar 2018 22:09:58 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=ceur5MvwF+nbNlkWUIJ5nsRSZFLG4CXehdr2aBP5Uiw=; b=OF1OjPnpx6Xe+hlUuAjP5BZR4 GEyV9ULcPYbQ9GsUaoDZOnoSr64ZFs7XZuTBLwBweQ9A+YI9Fo3LwV2AZpMsUpu3RN+1HDLUKDQ23 77kNK9IB7sa+q3Z0sob3SEM7X3WyoGDVivzWOAJAQue1NCGEJLot5LpTK2ie+3YhNwe9xOA/GY8Sr l1lEKu20iMMZRGXud2SGCFJsHUEzPrH7eKc7Quv+DhsfuBPztN9Yzwm0tcpF/0hHtW411W39C5bJZ q22z2xGYFcyLwteRnpmHMNPK4/4iHa13mcF5LXAtwHdIOUYfu177quHBHAxSU8YTXyaKj4B8OoW7O FIjwBhEsA==; Received: from mail.kmu-office.ch ([2a02:418:6a02::a2]) by casper.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1f0A6k-0002pt-TR for linux-arm-kernel@lists.infradead.org; Sun, 25 Mar 2018 18:11:09 +0000 Received: from trochilidae.lan (unknown [IPv6:2001:1620:c6e:0:814c:3584:bd88:6cb6]) by mail.kmu-office.ch (Postfix) with ESMTPSA id 9FCD15C1FAF; Sun, 25 Mar 2018 20:09:35 +0200 (CEST) From: Stefan Agner To: linux@armlinux.org.uk, ard.biesheuvel@linaro.org, arnd@arndb.de Subject: [PATCH v2 1/6] bus: arm-cci: use asm unreachable Date: Sun, 25 Mar 2018 20:09:54 +0200 Message-Id: <20180325180959.28008-2-stefan@agner.ch> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180325180959.28008-1-stefan@agner.ch> References: <20180325180959.28008-1-stefan@agner.ch> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=agner.ch; s=dkim; t=1522001375; bh=ceur5MvwF+nbNlkWUIJ5nsRSZFLG4CXehdr2aBP5Uiw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References; b=aECLbi3AgUfNfjqskfQJ26//QUaOqtXsLjhbgyryBBnmZcrktlbzU+8MJ44kkojyPsMxHrqwX+ABVb+6ePTZpELuf0Y63pkOexN732t32Q+RuL+Bj3ys8k2zdKmSzyIq91Zt3qY2bqFrfLur6ZHm9zlpvmoxPH8yHvqH2mibJOs= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180325_191106_981189_94AD1A91 X-CRM114-Status: GOOD ( 10.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nicolas.pitre@linaro.org, keescook@chromium.org, marc.zyngier@arm.com, linux-kernel@vger.kernel.org, Stefan Agner , mka@chromium.org, robin.murphy@arm.com, linux-arm-kernel@lists.infradead.org, Bernhard.Rosenkranzer@linaro.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Mixing asm and C code is not recommended in a naked function by gcc and leads to an error when using clang: drivers/bus/arm-cci.c:2107:2: error: non-ASM statement in naked function is not supported unreachable(); ^ While the function is marked __naked it actually properly return in asm. There is no need for the unreachable() call. Suggested-by: Russell King Signed-off-by: Stefan Agner --- Changes in v2: - Don't add assembly ASM_UNREACHABLE, just drop unreachable() drivers/bus/arm-cci.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/bus/arm-cci.c b/drivers/bus/arm-cci.c index 5426c04fe24b..fc2da3a617ac 100644 --- a/drivers/bus/arm-cci.c +++ b/drivers/bus/arm-cci.c @@ -2103,8 +2103,6 @@ asmlinkage void __naked cci_enable_port_for_self(void) [sizeof_struct_cpu_port] "i" (sizeof(struct cpu_port)), [sizeof_struct_ace_port] "i" (sizeof(struct cci_ace_port)), [offsetof_port_phys] "i" (offsetof(struct cci_ace_port, phys)) ); - - unreachable(); } /**