| Message ID | 20180327053104.3812-1-jagan@amarulasolutions.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Mar 27, 2018 at 11:01 AM, Jagan Teki <jagan@amarulasolutions.com> wrote: > Like axp221, axp223, axp813 the axp803 is also supporting external > regulator to drive the OTG VBus through N_VBUSEN PMIC pin. > > Add support for it. > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > Reviewed-by: Rob Herring <robh@kernel.org> > Reviewed-by: Chen-Yu Tsai <wens@csie.org> > --- > Changes for v5: > - Collect Chen-Yu reviewed-by tag > Changes for v4: > - rebase on master > Changes for v3: > - Update drivevbus in table of regulators Can you pick these, has some dependency with drivevbus on other patches. Jagan.
On Thu, Apr 05, 2018 at 12:11:39PM +0530, Jagan Teki wrote: > On Tue, Mar 27, 2018 at 11:01 AM, Jagan Teki <jagan@amarulasolutions.com> wrote: > > Like axp221, axp223, axp813 the axp803 is also supporting external > > regulator to drive the OTG VBus through N_VBUSEN PMIC pin. > > > > Add support for it. > > > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > > Reviewed-by: Rob Herring <robh@kernel.org> > > Reviewed-by: Chen-Yu Tsai <wens@csie.org> > > --- > > Changes for v5: > > - Collect Chen-Yu reviewed-by tag > > Changes for v4: > > - rebase on master > > Changes for v3: > > - Update drivevbus in table of regulators > > Can you pick these, has some dependency with drivevbus on other > patches. I'm not the regulator maintainer, nor the AXP maintainer for that matter. Mark Brown and Chen-Yu are, respectively. Maxime
On Thu, Apr 5, 2018 at 2:46 PM, Maxime Ripard <maxime.ripard@bootlin.com> wrote: > On Thu, Apr 05, 2018 at 12:11:39PM +0530, Jagan Teki wrote: >> On Tue, Mar 27, 2018 at 11:01 AM, Jagan Teki <jagan@amarulasolutions.com> wrote: >> > Like axp221, axp223, axp813 the axp803 is also supporting external >> > regulator to drive the OTG VBus through N_VBUSEN PMIC pin. >> > >> > Add support for it. >> > >> > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> >> > Reviewed-by: Rob Herring <robh@kernel.org> >> > Reviewed-by: Chen-Yu Tsai <wens@csie.org> >> > --- >> > Changes for v5: >> > - Collect Chen-Yu reviewed-by tag >> > Changes for v4: >> > - rebase on master >> > Changes for v3: >> > - Update drivevbus in table of regulators >> >> Can you pick these, has some dependency with drivevbus on other >> patches. > > I'm not the regulator maintainer, nor the AXP maintainer for that > matter. Mark Brown and Chen-Yu are, respectively. I've already reviewed all the patches. Please resend the series and include Mark Brown, the regulator subsystem maintainer. He clearly isn't in the current recipient list, so no wonder things didn't move forward. Once he applies the driver bits, we'll apply any pending device tree changes. ChenYu
diff --git a/Documentation/devicetree/bindings/mfd/axp20x.txt b/Documentation/devicetree/bindings/mfd/axp20x.txt index 9455503b0299..d1762f3b30af 100644 --- a/Documentation/devicetree/bindings/mfd/axp20x.txt +++ b/Documentation/devicetree/bindings/mfd/axp20x.txt @@ -43,7 +43,7 @@ Optional properties: regulator to drive the OTG VBus, rather then as an input pin which signals whether the board is driving OTG VBus or not. - (axp221 / axp223 / axp813 only) + (axp221 / axp223 / axp803/ axp813 only) - x-powers,master-mode: Boolean (axp806 only). Set this when the PMIC is wired for master mode. The default is slave mode. @@ -132,6 +132,7 @@ FLDO2 : LDO : fldoin-supply : shared supply LDO_IO0 : LDO : ips-supply : GPIO 0 LDO_IO1 : LDO : ips-supply : GPIO 1 RTC_LDO : LDO : ips-supply : always on +DRIVEVBUS : Enable output : drivevbus-supply : external regulator AXP806 regulators, type, and corresponding input supply names: diff --git a/drivers/regulator/axp20x-regulator.c b/drivers/regulator/axp20x-regulator.c index 181622b2813d..91b8ff8bac15 100644 --- a/drivers/regulator/axp20x-regulator.c +++ b/drivers/regulator/axp20x-regulator.c @@ -721,6 +721,8 @@ static int axp20x_regulator_probe(struct platform_device *pdev) case AXP803_ID: regulators = axp803_regulators; nregulators = AXP803_REG_ID_MAX; + drivevbus = of_property_read_bool(pdev->dev.parent->of_node, + "x-powers,drive-vbus-en"); break; case AXP806_ID: regulators = axp806_regulators;