| Message ID | 20180330125047.13936-3-ssuloev@orpaltech.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Mar 30, 2018 at 03:50:43PM +0300, Sergey Suloev wrote: > The chip select polarity flag is declared as supported > but is not handled in the code. This is more of a fix and should really have come before the cosmetic changes in patch 1. In general it's best to put fixes fist in a series unless there's a strong reason to do something else, that makes it easier to get the fixes in without them getting caught by review issues with other code.
diff --git a/drivers/spi/spi-sun6i.c b/drivers/spi/spi-sun6i.c index 88ad45e..78acc1f 100644 --- a/drivers/spi/spi-sun6i.c +++ b/drivers/spi/spi-sun6i.c @@ -193,6 +193,12 @@ static void sun6i_spi_set_cs(struct spi_device *spi, bool enable) else reg &= ~SUN6I_TFR_CTL_CS_LEVEL; + /* Handle chip select "reverse" polarity */ + if (spi->mode & SPI_CS_HIGH) + reg &= ~SUN6I_TFR_CTL_SPOL; + else + reg |= SUN6I_TFR_CTL_SPOL; + /* We want to control the chip select manually */ reg |= SUN6I_TFR_CTL_CS_MANUAL;
The chip select polarity flag is declared as supported but is not handled in the code. Signed-off-by: Sergey Suloev <ssuloev@orpaltech.com> --- drivers/spi/spi-sun6i.c | 6 ++++++ 1 file changed, 6 insertions(+)