From patchwork Thu Apr 12 11:03:14 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Dmitry V. Levin" X-Patchwork-Id: 10338197 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 00C6C60134 for ; Thu, 12 Apr 2018 11:04:21 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E2344287AA for ; Thu, 12 Apr 2018 11:04:20 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D2F38287AD; Thu, 12 Apr 2018 11:04:20 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 55B52287AA for ; Thu, 12 Apr 2018 11:04:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=OoCgAMn+/QFBQtrCsZjS0MYgYJfMNwCAqIAn7nC9D4M=; b=mcZgfdsY17hXUcIuMmH7wEe/O zHlSh2wzHJGKuQPkRgmARKWyfmSyb5r/bhjvqg7SMoy+lxrIgk/p7Hy/0hVLAtjfB+PiBGyq7oBOs mKA66XNI3m+N8r/BPzdh24on3XGVcx7XyTlv9BNo9nj8a0pmtkhhrAbi5eZIHMIK1gXH5zBpfNBfD xnObXIVzf2DWPDXRF7yrXmLnsl306pPqiVZKLwMOB8I34GKMbtUgRyKDC/CQ6iVmIiSXg3ESFN9oY sBnAzmHzkWZj2mmZLbMBh0vpT3ft8usgKNsC8d5jL1GHQ19VfMzJwYjnNn60n1XfQzdm4ZC+U88Ha rZeEA/ROg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1f6a1R-0001Lm-E1; Thu, 12 Apr 2018 11:04:09 +0000 Received: from vmicros1.altlinux.org ([194.107.17.57]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1f6a0l-0000oJ-2A for linux-arm-kernel@lists.infradead.org; Thu, 12 Apr 2018 11:03:30 +0000 Received: from mua.local.altlinux.org (mua.local.altlinux.org [192.168.1.14]) by vmicros1.altlinux.org (Postfix) with ESMTP id 1F11172D1DB; Thu, 12 Apr 2018 14:03:15 +0300 (MSK) Received: by mua.local.altlinux.org (Postfix, from userid 508) id 105047CC686; Thu, 12 Apr 2018 14:03:14 +0300 (MSK) Date: Thu, 12 Apr 2018 14:03:14 +0300 From: "Dmitry V. Levin" To: Russell King - ARM Linux Subject: Re: sparc/ppc/arm compat siginfo ABI regressions: sending SIGFPE via kill() returns wrong values in si_pid and si_uid Message-ID: <20180412110314.GA28070@altlinux.org> Mail-Followup-To: Russell King - ARM Linux , "Eric W. Biederman" , sparclinux@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Linus Torvalds , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20180409152253.GD10489@altlinux.org> <20180412013435.GA21219@altlinux.org> <20180412095811.GC16141@n2100.armlinux.org.uk> MIME-Version: 1.0 In-Reply-To: <20180412095811.GC16141@n2100.armlinux.org.uk> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180412_040327_296625_321EB72D X-CRM114-Status: GOOD ( 11.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, "Eric W. Biederman" , sparclinux@vger.kernel.org, Linus Torvalds , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP On Thu, Apr 12, 2018 at 10:58:11AM +0100, Russell King - ARM Linux wrote: > On Thu, Apr 12, 2018 at 04:34:35AM +0300, Dmitry V. Levin wrote: > > A similar commit v4.16-rc1~159^2~37 > > ("signal/arm: Document conflicts with SI_USER and SIGFPE") must have > > introduced a similar ABI regression to compat arm. > > So, could you explain how can this change cause a regression? > > +#define FPE_FIXME 0 > - vfp_raise_sigfpe(0, regs); > + vfp_raise_sigfpe(FPE_FIXME, regs); No, this hunk hasn't caused the regression, but another one did: This is due to FPE_FIXME handling in kernel/signal.c diff --git a/arch/arm/include/uapi/asm/siginfo.h b/arch/arm/include/uapi/asm/siginfo.h new file mode 100644 index 0000000..d051388 --- /dev/null +++ b/arch/arm/include/uapi/asm/siginfo.h @@ -0,0 +1,13 @@ +#ifndef __ASM_SIGINFO_H +#define __ASM_SIGINFO_H + +#include + +/* + * SIGFPE si_codes + */ +#ifdef __KERNEL__ +#define FPE_FIXME 0 /* Broken dup of SI_USER */ +#endif /* __KERNEL__ */ + +#endif