| Message ID | 20180427001745.4116-25-david@lechnology.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Apr 26, 2018 at 07:17:42PM -0500, David Lechner wrote: > This adds new device tree bindings for the timer IP block of TI > DaVinci-like SoCs. > > Signed-off-by: David Lechner <david@lechnology.com> > --- > > v9 changes: > - new patch in v9 > > > .../bindings/timer/ti,davinci-timer.txt | 24 +++++++++++++++++++ > 1 file changed, 24 insertions(+) > create mode 100644 Documentation/devicetree/bindings/timer/ti,davinci-timer.txt > > diff --git a/Documentation/devicetree/bindings/timer/ti,davinci-timer.txt b/Documentation/devicetree/bindings/timer/ti,davinci-timer.txt > new file mode 100644 > index 000000000000..2091eca46981 > --- /dev/null > +++ b/Documentation/devicetree/bindings/timer/ti,davinci-timer.txt > @@ -0,0 +1,24 @@ > +* Device tree bindings for Texas Instruments DaVinci timer > + > +This document provides bindings for the 64-bit timer in the DaVinci > +architecture devices. The timer can be configured as a general-purpose 64-bit > +timer, dual general-purpose 32-bit timers. When configured as dual 32-bit > +timers, each half can operate in conjunction (chain mode) or independently > +(unchained mode) of each other. > + > +It is global timer is a free running up-counter and can generate interrupt Doesn't make sense, too many 'is'. There's no interrupt property listed. > +when the counter reaches preset counter values. > + > +Required properties: > + > +- compatible : should be "ti,davinci-timer". > +- reg : specifies base physical address and count of the registers. > +- clocks : the clock feeding the timer clock. > + > +Example: > + > + clocksource: timer@20000 { > + compatible = "ti,davinci-timer"; > + reg = <0x20000 0x1000>; > + clocks = <&pll0_auxclk>; > + }; > -- > 2.17.0 >
Sekhar, On 04/27/2018 09:05 AM, Rob Herring wrote: > On Thu, Apr 26, 2018 at 07:17:42PM -0500, David Lechner wrote: >> This adds new device tree bindings for the timer IP block of TI >> DaVinci-like SoCs. >> >> Signed-off-by: David Lechner <david@lechnology.com> >> --- >> >> v9 changes: >> - new patch in v9 >> >> >> .../bindings/timer/ti,davinci-timer.txt | 24 +++++++++++++++++++ >> 1 file changed, 24 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/timer/ti,davinci-timer.txt >> >> diff --git a/Documentation/devicetree/bindings/timer/ti,davinci-timer.txt b/Documentation/devicetree/bindings/timer/ti,davinci-timer.txt >> new file mode 100644 >> index 000000000000..2091eca46981 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/timer/ti,davinci-timer.txt >> @@ -0,0 +1,24 @@ >> +* Device tree bindings for Texas Instruments DaVinci timer >> + >> +This document provides bindings for the 64-bit timer in the DaVinci >> +architecture devices. The timer can be configured as a general-purpose 64-bit >> +timer, dual general-purpose 32-bit timers. When configured as dual 32-bit >> +timers, each half can operate in conjunction (chain mode) or independently >> +(unchained mode) of each other. >> + >> +It is global timer is a free running up-counter and can generate interrupt > > Doesn't make sense, too many 'is'. > > There's no interrupt property listed. > >> +when the counter reaches preset counter values. >> + >> +Required properties: >> + >> +- compatible : should be "ti,davinci-timer". >> +- reg : specifies base physical address and count of the registers. >> +- clocks : the clock feeding the timer clock. >> + >> +Example: >> + >> + clocksource: timer@20000 { >> + compatible = "ti,davinci-timer"; >> + reg = <0x20000 0x1000>; >> + clocks = <&pll0_auxclk>; >> + }; >> -- >> 2.17.0 >> What do you think about trying to reuse the keystone timer here instead of introducing our own binding? I assume it is basically the same since the watchdog timer is shared already between davinci and keystone.
On Wednesday 02 May 2018 07:22 AM, David Lechner wrote: > Sekhar, > > On 04/27/2018 09:05 AM, Rob Herring wrote: >> On Thu, Apr 26, 2018 at 07:17:42PM -0500, David Lechner wrote: >>> This adds new device tree bindings for the timer IP block of TI >>> DaVinci-like SoCs. >>> >>> Signed-off-by: David Lechner <david@lechnology.com> >>> --- >>> >>> v9 changes: >>> - new patch in v9 >>> >>> >>> .../bindings/timer/ti,davinci-timer.txt | 24 +++++++++++++++++++ >>> 1 file changed, 24 insertions(+) >>> create mode 100644 >>> Documentation/devicetree/bindings/timer/ti,davinci-timer.txt >>> >>> diff --git >>> a/Documentation/devicetree/bindings/timer/ti,davinci-timer.txt >>> b/Documentation/devicetree/bindings/timer/ti,davinci-timer.txt >>> new file mode 100644 >>> index 000000000000..2091eca46981 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/timer/ti,davinci-timer.txt >>> @@ -0,0 +1,24 @@ >>> +* Device tree bindings for Texas Instruments DaVinci timer >>> + >>> +This document provides bindings for the 64-bit timer in the DaVinci >>> +architecture devices. The timer can be configured as a >>> general-purpose 64-bit >>> +timer, dual general-purpose 32-bit timers. When configured as dual >>> 32-bit >>> +timers, each half can operate in conjunction (chain mode) or >>> independently >>> +(unchained mode) of each other. >>> + >>> +It is global timer is a free running up-counter and can generate >>> interrupt >> >> Doesn't make sense, too many 'is'. >> >> There's no interrupt property listed. >> >>> +when the counter reaches preset counter values. >>> + >>> +Required properties: >>> + >>> +- compatible : should be "ti,davinci-timer". >>> +- reg : specifies base physical address and count of the registers. >>> +- clocks : the clock feeding the timer clock. >>> + >>> +Example: >>> + >>> + clocksource: timer@20000 { >>> + compatible = "ti,davinci-timer"; >>> + reg = <0x20000 0x1000>; >>> + clocks = <&pll0_auxclk>; >>> + }; >>> -- >>> 2.17.0 >>> > > What do you think about trying to reuse the keystone timer here instead of > introducing our own binding? I assume it is basically the same since the > watchdog timer is shared already between davinci and keystone. When we move to using timer support to drivers/clocksource, surely we should look at reusing the keystone timer. But even then, I think having a separate binding document for DaVinci is not illegal. Since we are not at a stage where we re-use Keystone driver, I prefer the binding to be separate as well. The timer IP on DA830/DA850 is not the same as that available on Keystone and older DaVinci devices. There are additional compare registers (starting at 0x60) on DA830/DA850 devices which allow the same timer to be used for both clocksource and clockevent. We use that facility on DA830 today because there was a shortage of timers on that device and majority of timers had to be dedicated for DSP use. So, I think its safer to introduce a "ti,da830-timer" compatible for DA830 and DA850 timers. On interrupts question, yes, we dont use interrupt number from DT today. But defining an interrupt property that looks correct is fine, I think. Thanks, Sekhar
diff --git a/Documentation/devicetree/bindings/timer/ti,davinci-timer.txt b/Documentation/devicetree/bindings/timer/ti,davinci-timer.txt new file mode 100644 index 000000000000..2091eca46981 --- /dev/null +++ b/Documentation/devicetree/bindings/timer/ti,davinci-timer.txt @@ -0,0 +1,24 @@ +* Device tree bindings for Texas Instruments DaVinci timer + +This document provides bindings for the 64-bit timer in the DaVinci +architecture devices. The timer can be configured as a general-purpose 64-bit +timer, dual general-purpose 32-bit timers. When configured as dual 32-bit +timers, each half can operate in conjunction (chain mode) or independently +(unchained mode) of each other. + +It is global timer is a free running up-counter and can generate interrupt +when the counter reaches preset counter values. + +Required properties: + +- compatible : should be "ti,davinci-timer". +- reg : specifies base physical address and count of the registers. +- clocks : the clock feeding the timer clock. + +Example: + + clocksource: timer@20000 { + compatible = "ti,davinci-timer"; + reg = <0x20000 0x1000>; + clocks = <&pll0_auxclk>; + };
This adds new device tree bindings for the timer IP block of TI DaVinci-like SoCs. Signed-off-by: David Lechner <david@lechnology.com> --- v9 changes: - new patch in v9 .../bindings/timer/ti,davinci-timer.txt | 24 +++++++++++++++++++ 1 file changed, 24 insertions(+) create mode 100644 Documentation/devicetree/bindings/timer/ti,davinci-timer.txt