From patchwork Wed May 9 20:05:28 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 10390793 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 1D2A360318 for ; Wed, 9 May 2018 20:06:07 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0BDDF2852E for ; Wed, 9 May 2018 20:06:07 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 00347286AA; Wed, 9 May 2018 20:06:06 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 91A932852E for ; Wed, 9 May 2018 20:06:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=3ZSRaZG9s6AJpBr8/99Yje8dpjFEnUWYi9RNMyES6FE=; b=t3Y Rqq9UdySPxq/8AAHfF+4ahrPykVFNH+5tDgkWSY+Z9Inq06RnKmI18f8kl+U01LTDsV644XH+QKtA Qr+cC4ocGaEkm3DuROHcOHnT9fv4qNv3Zb9vAGD0/Hnsray+YxbGrhqYedJacT9y0Z9TQF/AlHhsE QhKJK/32Js+si1Yxtu+gn+Cyb7OVvmK4qwMvBumiLLk2pmLUv8yFCXon57DH2NBs8Qj+/GAwMbzP9 6AvONhizmpyk9vvfhx0JAERUu/Q5owkqa98idCrYwBbHVyh7/Xl5XvK3BI/rA01m4AUlszh3k9r8b 1e6kXBFY34uxPcWQbYPFr3xwvdg/BnQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fGVLZ-0005AE-Mc; Wed, 09 May 2018 20:05:57 +0000 Received: from mail-pf0-x243.google.com ([2607:f8b0:400e:c00::243]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fGVLV-00059Q-Fk for linux-arm-kernel@lists.infradead.org; Wed, 09 May 2018 20:05:54 +0000 Received: by mail-pf0-x243.google.com with SMTP id f20so17364886pfn.0 for ; Wed, 09 May 2018 13:05:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id; bh=lUh8dHDz9V7YhZF4KfhQXkpvmaWOQsflZOS65SJv/oU=; b=Fc3w1r48pOPsRe4IoEnGRhvqZjC52bir3+1iTMECYrWQQlKncpRXilj/a/j1edvUit 0j2au0WXCg7hF6w16bCqxOT//UC5hPxnaJLebDAM+EBJZTiwR9KBsZCUrACXsnmneQkT 0SN5vQv6e+MVusSy9Cv6lFyPn5PGUEy5TOywA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=lUh8dHDz9V7YhZF4KfhQXkpvmaWOQsflZOS65SJv/oU=; b=ROzXL7L1Ru9OuIjssbMrRg9avJwDTRTOIIVlbvlZBr74oZVILXAG0+83SklBaHWlQW rMFYnpCaR/gmr14dcYOdgn7BamponQY9b8b1ZriMrhwYgHhrMD0Lp/QP12VZYMdA3cO7 xHRn72FabO6+pzEax+hpWEo/wdHfy3tSksV0wjeBEjcjrDtIbMDdOcfw1T44ih+jeZUD ku6jvfLYd6rvR+s1IAoQMksAmdE58DmDlL+JrxOizCPbR1JNcv21QRLMY17JTul+RkOU 8o5iFAxjXNl8LU8PRPgYiPZBrTVA8uvstzXj/5ohfUpmm5uXXu64SGSKHTJ4aWPBLC8/ 3jXw== X-Gm-Message-State: ALQs6tA9Hg/2KVfpkAeaiE5IMSkwAqDAKTdW2AErBjTWTB1ETSmhYRRF bwcnCMer9QHkMxBKx1HWKjpdLA== X-Google-Smtp-Source: AB8JxZpcVEFAdICUmU4Pey3x0gRXCfRG4d+Z0e028xDg46GxosDMsdDA7D0FHaUDJ+1EtidtPJG5uw== X-Received: by 10.98.61.84 with SMTP id k81mr45164642pfa.193.1525896342680; Wed, 09 May 2018 13:05:42 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:0:1000:1511:bde7:107f:fd5:44c8]) by smtp.gmail.com with ESMTPSA id n73sm21923743pfb.167.2018.05.09.13.05.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 09 May 2018 13:05:41 -0700 (PDT) From: Douglas Anderson To: andy.gross@linaro.org Subject: [PATCH] arm64: dts: sdm845: Fix xo_board clock name and speed Date: Wed, 9 May 2018 13:05:28 -0700 Message-Id: <20180509200528.233451-1-dianders@chromium.org> X-Mailer: git-send-email 2.17.0.441.gb46fe60e1d-goog X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180509_130553_557386_EDFF9F54 X-CRM114-Status: GOOD ( 18.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: tdas@codeaurora.org, devicetree@vger.kernel.org, sboyd@kernel.org, linux-arm-msm@vger.kernel.org, Will Deacon , Douglas Anderson , anischal@codeaurora.org, David Brown , Rob Herring , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Mark Rutland , bjorn.andersson@linaro.org, linux-soc@vger.kernel.org, linux-kernel@vger.kernel.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP The RPMh clock driver assumes that the xo_board clock is named "xo_board", not "xo-board". Add a "clock-output-names" property to the device tree to get the right name. Also add the proper speed for the xo-clock as 38400000. This is internally divided in RPMh clock driver to get "bi_tcxo" at 19200000. After this change the clock tree in /sys/kernel/debug/clk/clk_summary looks much better. NOTES: - Technically you could argue that this clock could belong in board .dts files, not in the SoC one. However at the moment it's believed that 100% of sdm845 boards will have an external clock at 38.4. It can always be moved later if necessary. - We could rename the "xo-board" device tree node to "xo_board" to achieve the same effect as this patch. Presumably device-tree folks would rather keep node names using dashes though. - We could change the RPMh clock driver to use a dash to achieve the same effect as this patch, but all other clocks in the clock tree use underscores. It seems silly to change just this one. Fixes: 7bafa643647f ("arm64: dts: sdm845: Add minimal dts/dtsi files for sdm845 SoC and MTP") Signed-off-by: Douglas Anderson --- arch/arm64/boot/dts/qcom/sdm845.dtsi | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi index 486ace9a9e8b..4945f8cccd6c 100644 --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi @@ -137,7 +137,8 @@ xo_board: xo-board { compatible = "fixed-clock"; #clock-cells = <0>; - clock-frequency = <19200000>; + clock-frequency = <38400000>; + clock-output-names = "xo_board"; }; sleep_clk: sleep-clk {