| Message ID | 20180517090552.5704-4-daniel@zonque.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, May 17, 2018 at 11:05:52AM +0200, Daniel Mack wrote: > The touchscreen driver no longer configures the device as wakeup source by > default. A "wakeup-source" property is needed. > > To avoid regressions, this patch changes the DTS files for the only two > users of this driver that didn't have this property yet. > > Signed-off-by: Daniel Mack <daniel@zonque.org> > Cc: Shawn Guo <shawnguo@kernel.org> > Cc: Sascha Hauer <kernel@pengutronix.de> > Cc: Fabio Estevam <fabio.estevam@nxp.com> > Cc: Rob Herring <robh+dt@kernel.org> Applied this one, thanks.
On Sun, May 20, 2018 at 09:05:30PM +0800, Shawn Guo wrote: > On Thu, May 17, 2018 at 11:05:52AM +0200, Daniel Mack wrote: > > The touchscreen driver no longer configures the device as wakeup source by > > default. A "wakeup-source" property is needed. > > > > To avoid regressions, this patch changes the DTS files for the only two > > users of this driver that didn't have this property yet. > > > > Signed-off-by: Daniel Mack <daniel@zonque.org> > > Cc: Shawn Guo <shawnguo@kernel.org> > > Cc: Sascha Hauer <kernel@pengutronix.de> > > Cc: Fabio Estevam <fabio.estevam@nxp.com> > > Cc: Rob Herring <robh+dt@kernel.org> > > Applied this one, thanks. I think there are few more that need "wakeup-source" added: arch/arm/boot/dts/am437x-sk-evm.dts arch/arm/boot/dts/imx6q-var-dt6customboard.dts arch/arm/boot/dts/imx6qdl-nit6xlite.dtsi arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi arch/arm/boot/dts/imx6qdl-nitrogen6_som2.dtsi arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi Thanks.
On Tuesday, May 22, 2018 08:20 PM, Dmitry Torokhov wrote: > On Sun, May 20, 2018 at 09:05:30PM +0800, Shawn Guo wrote: >> On Thu, May 17, 2018 at 11:05:52AM +0200, Daniel Mack wrote: >>> The touchscreen driver no longer configures the device as wakeup source by >>> default. A "wakeup-source" property is needed. >>> >>> To avoid regressions, this patch changes the DTS files for the only two >>> users of this driver that didn't have this property yet. >>> >>> Signed-off-by: Daniel Mack <daniel@zonque.org> >>> Cc: Shawn Guo <shawnguo@kernel.org> >>> Cc: Sascha Hauer <kernel@pengutronix.de> >>> Cc: Fabio Estevam <fabio.estevam@nxp.com> >>> Cc: Rob Herring <robh+dt@kernel.org> >> >> Applied this one, thanks. > > I think there are few more that need "wakeup-source" added: > > arch/arm/boot/dts/am437x-sk-evm.dts > arch/arm/boot/dts/imx6q-var-dt6customboard.dts > arch/arm/boot/dts/imx6qdl-nit6xlite.dtsi > arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi > arch/arm/boot/dts/imx6qdl-nitrogen6_som2.dtsi > arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi Oh, sorry for having missed them. Will send patches. Thanks, Daniel
diff --git a/arch/arm/boot/dts/imx28-tx28.dts b/arch/arm/boot/dts/imx28-tx28.dts index 0ebbc83852d0..094a39a67ec8 100644 --- a/arch/arm/boot/dts/imx28-tx28.dts +++ b/arch/arm/boot/dts/imx28-tx28.dts @@ -328,6 +328,7 @@ interrupts = <5 IRQ_TYPE_EDGE_FALLING>; reset-gpios = <&gpio2 6 GPIO_ACTIVE_LOW>; wake-gpios = <&gpio4 9 GPIO_ACTIVE_HIGH>; + wakeup-source; }; touchscreen: tsc2007@48 { diff --git a/arch/arm/boot/dts/imx53-tx53-x03x.dts b/arch/arm/boot/dts/imx53-tx53-x03x.dts index 0ecb43d88522..dbf0d73dc7b9 100644 --- a/arch/arm/boot/dts/imx53-tx53-x03x.dts +++ b/arch/arm/boot/dts/imx53-tx53-x03x.dts @@ -220,6 +220,7 @@ interrupts = <15 IRQ_TYPE_EDGE_FALLING>; reset-gpios = <&gpio2 22 GPIO_ACTIVE_LOW>; wake-gpios = <&gpio2 21 GPIO_ACTIVE_HIGH>; + wakeup-source; }; touchscreen: tsc2007@48 {
The touchscreen driver no longer configures the device as wakeup source by default. A "wakeup-source" property is needed. To avoid regressions, this patch changes the DTS files for the only two users of this driver that didn't have this property yet. Signed-off-by: Daniel Mack <daniel@zonque.org> Cc: Shawn Guo <shawnguo@kernel.org> Cc: Sascha Hauer <kernel@pengutronix.de> Cc: Fabio Estevam <fabio.estevam@nxp.com> Cc: Rob Herring <robh+dt@kernel.org> --- arch/arm/boot/dts/imx28-tx28.dts | 1 + arch/arm/boot/dts/imx53-tx53-x03x.dts | 1 + 2 files changed, 2 insertions(+)