| Message ID | 20180518012052.31345-1-aford173@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Friday 18 May 2018 06:50 AM, Adam Ford wrote: > When booting from MMC/SD in rw mode, the system crashes because ... in rw mode on DA850 EVM, .. > the write protect pin should be active high and not active low. > This patch fixes the polarity of the WP pin. > > Fixes: 67c6b6ff221f ("ARM: davinci: board-da850-evm: fix GPIO > lookup for MMC/SD") Fixes: bdf0e8364fd3 ("ARM: davinci: da850-evm: use gpio descriptor for mmc pins") is more appropriate since thats where the bug was actually introduced and thats how far back you want the patch backported. > > Signed-off-by: Adam Ford <aford173@gmail.com> With these changes, applied to fixes for v4.18. Thanks, Sekhar
diff --git a/arch/arm/mach-davinci/board-da850-evm.c b/arch/arm/mach-davinci/board-da850-evm.c index e22fb40e34bc..6d5beb11bd96 100644 --- a/arch/arm/mach-davinci/board-da850-evm.c +++ b/arch/arm/mach-davinci/board-da850-evm.c @@ -774,7 +774,7 @@ static struct gpiod_lookup_table mmc_gpios_table = { GPIO_LOOKUP("davinci_gpio.0", DA850_MMCSD_CD_PIN, "cd", GPIO_ACTIVE_LOW), GPIO_LOOKUP("davinci_gpio.0", DA850_MMCSD_WP_PIN, "wp", - GPIO_ACTIVE_LOW), + GPIO_ACTIVE_HIGH), }, };
When booting from MMC/SD in rw mode, the system crashes because the write protect pin should be active high and not active low. This patch fixes the polarity of the WP pin. Fixes: 67c6b6ff221f ("ARM: davinci: board-da850-evm: fix GPIO lookup for MMC/SD") Signed-off-by: Adam Ford <aford173@gmail.com>