From patchwork Fri May 18 19:51:54 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 10412017 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 26F9B6031B for ; Fri, 18 May 2018 19:52:15 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1479328AC4 for ; Fri, 18 May 2018 19:52:15 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 083BA28AC7; Fri, 18 May 2018 19:52:15 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 89F2728AC4 for ; Fri, 18 May 2018 19:52:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mX2wL+2878S/mG6NiAUpizJES1K+Yjqzu7reEdjTFNs=; b=YcK/ypvb+gR2z+ GLJz7ewtJotB4arhM/ziGCkdkNiK5jTjmHO/ENupghpYCHBUehWMtFjlpEGWFxlTSXfe65F1OitVR RkyKAiekBongeI6u8Pf3CDtf3LUb62Uwp2T4qZKwT1Lw0K4JA7jOzWP+ustr5vG/BJGwQgBGTFtwf LKr4e1jQ1sKHcVNnB2JNR8o5PY7s3u3By1sh54OEXFjujEtfEkoivd7oTyzvQUVPL68WQCCkyfp07 OgrpuieAFUqBtFv7M3a2q2ap95M/4vYFFGk2PRLKpbz4rfuLs+8NEwc8oxwQf2gBs1uVkH65PyuGv D0QeIXhLtgCQj+EaVs/w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fJlQB-0003XM-Nf; Fri, 18 May 2018 19:52:11 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fJlQ8-0003Wo-P2; Fri, 18 May 2018 19:52:10 +0000 Received: from localhost (unknown [69.71.5.252]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2D0FA20833; Fri, 18 May 2018 19:51:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1526673117; bh=s+IvFzHJmI31aaAuswNYWy4VNiZx9oOjSeMwPzkSmPw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=e4tgWQ3IVyJKRz+yOxeZY/dr0T0j27JUoaMH9b+Ex/wNHlQNvZhamyP0dy/1cMMr7 +T08L7eKeyJKVuwPq5L/+4Mw9kbsRdVTRGC4yta0YazDyWNbV3aZ7cn5F23K7Upuv7 kZg33jluhzXaqaXonzYpSCIEgeMUxvh2ChSGRIjw= Date: Fri, 18 May 2018 14:51:54 -0500 From: Bjorn Helgaas To: honghui.zhang@mediatek.com Subject: Re: [PATCH v7 2/2] PCI: mediatek: Using chained IRQ to setup IRQ handle Message-ID: <20180518195154.GB41790@bhelgaas-glaptop.roam.corp.google.com> References: <1525412853-24367-1-git-send-email-honghui.zhang@mediatek.com> <1525412853-24367-3-git-send-email-honghui.zhang@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1525412853-24367-3-git-send-email-honghui.zhang@mediatek.com> User-Agent: Mutt/1.9.2 (2017-12-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180518_125208_838077_AFF2133C X-CRM114-Status: GOOD ( 14.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: youlin.pei@mediatek.com, devicetree@vger.kernel.org, hongkun.cao@mediatek.com, lorenzo.pieralisi@arm.com, marc.zyngier@arm.com, linux-pci@vger.kernel.org, sean.wang@mediatek.com, xinping.qian@mediatek.com, linux-kernel@vger.kernel.org, yt.shen@mediatek.com, matthias.bgg@gmail.com, ryder.lee@mediatek.com, linux-mediatek@lists.infradead.org, yong.wu@mediatek.com, bhelgaas@google.com, yingjoe.chen@mediatek.com, eddie.huang@mediatek.com, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP On Fri, May 04, 2018 at 01:47:33PM +0800, honghui.zhang@mediatek.com wrote: > From: Honghui Zhang > > Using irq_chip solution to setup IRQs in order to consist > with IRQ framework. > > Signed-off-by: Honghui Zhang > Acked-by: Ryder Lee > --- > drivers/pci/host/pcie-mediatek.c | 206 ++++++++++++++++++++++----------------- > 1 file changed, 115 insertions(+), 91 deletions(-) > > diff --git a/drivers/pci/host/pcie-mediatek.c b/drivers/pci/host/pcie-mediatek.c > index c3dc549..dabf1086 100644 > --- a/drivers/pci/host/pcie-mediatek.c > +++ b/drivers/pci/host/pcie-mediatek.c > ... > -static int mtk_pcie_msi_map(struct irq_domain *domain, unsigned int irq, > - irq_hw_number_t hwirq) > +static struct msi_domain_info mtk_msi_domain_info = { I think this patch should be amended to include this: Lorenzo, if you want to fold that in and update your branch, I can pull it. If not, I can add a patch on top, which should only break compile-testing bisection. diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig index 0d0177ce436c..368b70d9371b 100644 --- a/drivers/pci/host/Kconfig +++ b/drivers/pci/host/Kconfig @@ -193,7 +193,7 @@ config PCIE_MEDIATEK bool "MediaTek PCIe controller" depends on (ARM || ARM64) && (ARCH_MEDIATEK || COMPILE_TEST) depends on OF - depends on PCI + depends on PCI_MSI_IRQ_DOMAIN select PCIEPORTBUS help Say Y here if you want to enable PCIe controller support on