From patchwork Tue May 29 15:08:23 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Will Deacon X-Patchwork-Id: 10436165 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 973C560327 for ; Tue, 29 May 2018 15:17:18 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 851BD28816 for ; Tue, 29 May 2018 15:17:18 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7930D2883A; Tue, 29 May 2018 15:17:18 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id EADEB28816 for ; Tue, 29 May 2018 15:17:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Ho/+bsLqjKaaGYVfp43Ftxd4TRXKvU/tNzgDw+5tBFE=; b=XW6ADli88nQgTA MXUj2kgM4fzgN0eJHAWY1ivqj13cetDgFcbapYajS+S+ENn0kz9iyreF7et3IWRyhQHBmYsM/zCbl S7y9L3pNkb7DJTcbPhDhnBrbaY/pJMw5Ff0IetZb2d19ZS9fKHI8eyWPa5kH1+wSZB2Ygdhc7ZVLV AXvMagMX8bZoXLUqtmtE5H7my3os58aiTxv0c9Zs1cT/GzebVr504k+CS3uIMcaGHD5BfUw4Ac7xf mn1KVNrIJAApk85rg5kVZ1Sqpo6NK0C3iSl6VXOs70Q0gm/n5pNoPcbQHavrLFWhV+i53gqsaa6oT KbBbxMLKWkQANbKX5dZg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fNgN3-0004Ur-Sh; Tue, 29 May 2018 15:17:09 +0000 Received: from casper.infradead.org ([85.118.1.10]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fNgLr-0003q7-3C; Tue, 29 May 2018 15:15:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=3l4lko53HqqUFXruYCjZzaQe5H7mH5R526zjnNOrB9I=; b=fgIgRKHhcyHRbulkx0E2CwsGQ /ZMAX16TSJB+WN/1oGEk9clx4zq7HseDLUVLCLOo5daD8KpBgPxXCvSX/kVdK/a/q4Jz4/nU3UpvS KHI3e5xjSFc2zY39dtCeghf7TElHrboJ0OgvNStWJjXD/uhyWNITuvNIkfmtvR0Ia1EWykcnOmmXs yHG54LFBOKB5qrs5WHV4TtGfTJA+Pz1LIDEqYa8OYMsj82hZX4ii2Xa6v7VOikAkEG7BONORSUfpI o4iZCA5jBAXLrMOmwyHzGi8/o3fLTJh3aOek5w/378VPEDH4+luZBK+9L90AwatiFg1KfT+iTHU/8 AlNDtzd5w==; Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70] helo=foss.arm.com) by casper.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fNgEH-0002nY-8v; Tue, 29 May 2018 15:08:07 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7042580D; Tue, 29 May 2018 08:07:54 -0700 (PDT) Received: from edgewater-inn.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 3EA813F557; Tue, 29 May 2018 08:07:54 -0700 (PDT) Received: by edgewater-inn.cambridge.arm.com (Postfix, from userid 1000) id D7FCE1AE51D5; Tue, 29 May 2018 16:08:23 +0100 (BST) Date: Tue, 29 May 2018 16:08:23 +0100 From: Will Deacon To: Sudeep Holla Subject: Re: [PATCH v9 00/12] Support PPTT for ARM64 Message-ID: <20180529150823.GD17159@arm.com> References: <20180511235807.30834-1-jeremy.linton@arm.com> <20180517170523.h7tuvbzdfluuidcz@armageddon.cambridge.arm.com> <09fb3fe7-d703-43f1-74f7-f8cb5ff1f67a@arm.com> <551905a6-eaa8-97df-06ec-1ceedfbc164f@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <551905a6-eaa8-97df-06ec-1ceedfbc164f@arm.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180529_160805_454166_6B6F2348 X-CRM114-Status: GOOD ( 20.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , austinwc@codeaurora.org, tnowicki@caviumnetworks.com, Catalin Marinas , Palmer Dabbelt , linux-riscv@lists.infradead.org, wangxiongfeng2@huawei.com, vkilari@codeaurora.org, Lorenzo Pieralisi , jhugo@codeaurora.org, Morten.Rasmussen@arm.com, ACPI Devel Maling List , Geert Uytterhoeven , Len Brown , John Garry , Al Stone , Linux ARM , Ard Biesheuvel , Greg KH , "Rafael J. Wysocki" , Linux Kernel Mailing List , Jeremy Linton , Linux-Renesas , Hanjun Guo , Dietmar Eggemann Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP On Tue, May 29, 2018 at 02:18:40PM +0100, Sudeep Holla wrote: > On 29/05/18 12:56, Geert Uytterhoeven wrote: > > On Tue, May 29, 2018 at 1:14 PM, Sudeep Holla wrote: > >> On 29/05/18 11:48, Geert Uytterhoeven wrote: > >>> System supend still works fine on systems with big cores only: > >>> > >>> R-Car H3 ES1.0 (4xCA57 (4xCA53 disabled in firmware)) > >>> R-Car M3-N (2xCA57) > >>> > >>> Reverting this commit fixes the issue for me. > >> > >> I can't find anything that relates to system suspend in these patches > >> unless they are messing with something during CPU hot plug-in back > >> during resume. > > > > It's only the last patch that introduces the breakage. > > > > As specified in the commit log, it won't change any behavior for DT > systems if it's non-NUMA or single node system. So I am still wondering > what could trigger this regression. I wonder if we're somehow giving an uninitialised/invalid NUMA configuration to the scheduler, although I can't see how this would happen. Geert -- if you enable CONFIG_DEBUG_PER_CPU_MAPS=y and apply the diff below do you see anything shouting in dmesg? Will --->8 diff --git a/arch/arm64/mm/numa.c b/arch/arm64/mm/numa.c index dad128ba98bf..e3de033339b4 100644 --- a/arch/arm64/mm/numa.c +++ b/arch/arm64/mm/numa.c @@ -58,7 +58,7 @@ EXPORT_SYMBOL(node_to_cpumask_map); */ const struct cpumask *cpumask_of_node(int node) { - if (WARN_ON(node >= nr_node_ids)) + if (WARN_ON((unsigned)node >= nr_node_ids)) return cpu_none_mask; if (WARN_ON(node_to_cpumask_map[node] == NULL))