From patchwork Fri Jun 1 11:10:02 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 10443017 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 7F4A3603D7 for ; Fri, 1 Jun 2018 11:12:20 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 71E1928A52 for ; Fri, 1 Jun 2018 11:12:20 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 65C7928ACE; Fri, 1 Jun 2018 11:12:20 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id EBEDD28CEF for ; Fri, 1 Jun 2018 11:12:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=ao6700gNn8Vx8uvNF41OPCxW+q25v4ZGfYVCuuCPrN0=; b=G+UXw2PyUv+nVoh14phfRauoEF yN+1kcRwhr+rG+Ttm5bkTF0APS7sjUb7P2XrIw2UZXwfuloNQMr6bWUyk/4WANcA3tx7fazob34+U +6XYJJXqQg/MoS6YCVvklwQDzxgvi/6UFlEZPsDGCIkqmflP3IB7yOtzlD/6nV0IyH1S5EUS8ODID eol6BXvgqzw/7txYWZVQ2ZNNLpBLEopk0j+XN2OFZEQadcxY6m+DS448QOooPDAk4BjB0fGnNn+v6 zddwmEH6baJr4qENCqB2TqglJYN/vZ22HOwEJE8uRtDk+exEEGGUd9p5aYUV1w0MLKwkALYbvIb8L EfjnJ8pA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fOhyd-0006wd-Of; Fri, 01 Jun 2018 11:12:11 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fOhxO-0006EG-Av; Fri, 01 Jun 2018 11:12:08 +0000 Received: from localhost (LFbn-1-12247-202.w90-92.abo.wanadoo.fr [90.92.61.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2AF45208B4; Fri, 1 Jun 2018 11:10:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1527851443; bh=ScRdVeZX7Bh3B/ndZXxRnP1IHMSCOsLqXmquYNtRX6Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DL1qUv9fHpYcJleh0g1rDWX06KOvilREZRzOh8SSQgC9k0bKKX3WABzkqZFAlt25W S7bCcyfd8iFZ5S/kziwkJKK9/Xy85Mzra+7Ydtm0fEpyJ8f1viQFUCM0tcV5BZftse OaOUo3Kxyyt9oJEj9nkyA4QgAfF4BPqFhI0zZjN0= From: Greg Kroah-Hartman To: devel@driverdev.osuosl.org Subject: [PATCH 4/6] staging: vc04_services: remove struct vchiq_debugfs_info Date: Fri, 1 Jun 2018 13:10:02 +0200 Message-Id: <20180601111004.1670-4-gregkh@linuxfoundation.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180601111004.1670-1-gregkh@linuxfoundation.org> References: <20180601111004.1670-1-gregkh@linuxfoundation.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180601_041054_461223_E30E7765 X-CRM114-Status: GOOD ( 13.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stefan Wahren , Kees Cook , Arnd Bergmann , Greg Kroah-Hartman , Keerthi Reddy , linux-rpi-kernel@lists.infradead.org, Dan Carpenter , linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP This structure, and the one static variable that was declared with it, were not being used for anything. The log_categories field was being set, but never used again. So just remove it entirely as it is not needed at all. Suggested-by: Eric Anholt Cc: Stefan Wahren Cc: Kees Cook Cc: Dan Carpenter Cc: Arnd Bergmann Cc: Keerthi Reddy Cc: linux-rpi-kernel@lists.infradead.org Cc: linux-arm-kernel@lists.infradead.org Signed-off-by: Greg Kroah-Hartman --- .../interface/vchiq_arm/vchiq_debugfs.c | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_debugfs.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_debugfs.c index 12ed560c95a7..f18cd56c3634 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_debugfs.c +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_debugfs.c @@ -51,14 +51,6 @@ #define VCHIQ_LOG_INFO_STR "info" #define VCHIQ_LOG_TRACE_STR "trace" -/* Top-level debug info */ -struct vchiq_debugfs_info { - /* log categories */ - struct dentry *log_categories; -}; - -static struct vchiq_debugfs_info debugfs_info; - /* Global 'vchiq' debugfs and clients entry used by all instances */ struct dentry *vchiq_dbg_dir; struct dentry *vchiq_dbg_clients; @@ -159,16 +151,12 @@ static void vchiq_debugfs_create_log_entries(struct dentry *top) size_t i; dir = debugfs_create_dir("log", vchiq_dbg_dir); - debugfs_info.log_categories = dir; for (i = 0; i < n_log_entries; i++) { void *levp = (void *)vchiq_debugfs_log_entries[i].plevel; dir = debugfs_create_file(vchiq_debugfs_log_entries[i].name, - 0644, - debugfs_info.log_categories, - levp, - &debugfs_log_fops); + 0644, dir, levp, &debugfs_log_fops); vchiq_debugfs_log_entries[i].dir = dir; } }