From patchwork Thu Jun 28 23:21:20 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luc Van Oostenryck X-Patchwork-Id: 10495349 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id F1C9C6022E for ; Thu, 28 Jun 2018 23:21:43 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DACFE2955B for ; Thu, 28 Jun 2018 23:21:43 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id CCE8529573; Thu, 28 Jun 2018 23:21:43 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FROM, MAILING_LIST_MULTI autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 58C762955B for ; Thu, 28 Jun 2018 23:21:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=X1GY2jbLbEth30/7ifg77op2EGHNS/YBsTr0Tgb646E=; b=ACQtlRacs9dyMd 6CF85b9WiIUvUs2kJt64KhzxNNn7M3KOaIT7YpE6Pm/CG/hZPy5lfPx+mXqxyAaSJ3vQYe+cl6gmw O4jNiaWNMsqDGRYJScasaqYs67HmQAHjuhk5hJdJ/3Nq+VlGYqS6F7GuAYIuPUUmbf2+oTXr6t0Op D9K7RgZZbmZbIVGbhfTvbmfzIaUIerLKfYSarqokGqTo6+XjXeRlxdiPAZP+wmlyXsJYoPVOGNHLY wPgqoIrUotlhSt/KoOfqLxMJ5+JitA7nV4HgqR1vuIbUxLEWERXBpZN+UbnIqm0xiEZMIBdHCofqH FEfhdliH3TDjC7uiR7Xw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fYgEM-0004ox-Gs; Thu, 28 Jun 2018 23:21:38 +0000 Received: from mail-ed1-x544.google.com ([2a00:1450:4864:20::544]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fYgEI-0004nQ-4l for linux-arm-kernel@lists.infradead.org; Thu, 28 Jun 2018 23:21:36 +0000 Received: by mail-ed1-x544.google.com with SMTP id g15-v6so1747254edr.12 for ; Thu, 28 Jun 2018 16:21:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=afXq2aPv2B3MzZ3D5CMcFffuyIH8CG7CNLmnWRAl9fw=; b=ejd6ElVvCipsxSWm6qlewdixNBcU/QLTjo9yHO8dLRV75bTHJJcx31V3m40PPCGIc9 sMGTtJ9E6lwXQpZc1R+KxHfUwDa4YV4abXV8vzoP+p4WmNz+HkzweQdDpEScsvLvwAYQ z8/yLG90U8D01gczXmwXhrer2y7Kfxf/iUVED1dotD0YAmc4N8uLCRWx2zR6Cftrmvz4 UZYzd1Bh6rVWTUTSqtDWTrbUAMiHc9pNkvX+xZSB1jOHxXvw//yKLlqj8TrPOqi4G/5j 8dVwgipifzvc0b0GWSIoBeeoeU5I4AK0+3Xr1t35Z0hFMMrQPWwXxe28YGkbmwx+bv9J RdYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=afXq2aPv2B3MzZ3D5CMcFffuyIH8CG7CNLmnWRAl9fw=; b=Vp9QEaMB5lgd8O5eO6RTJkx2V+DZEB9u9LPtk8GBPn35FQChhJvqVgyFD41k6wJw5b fIJUThug8ufpXlOgQlGFXNsnDJ2rMORUy6JWbUnooxvha2gubyZPkTPX73oasdCwUIF2 nXP5mNZGuguW3XqoQ9qQ4JlbSuspn4w2s36EAyluetJ1mplf5kQZ6Ip1vN8IItV9djKe O/AmbkcnQYP7x/Q3Hio84/bFbnbLG/bije2DWwmQzx1mqnQebNBu41yF0bPGHrt+1LAf 1+54e4+UxUVAqgY9JgcTK4tnS745iX5EMc5GX6BqVDWzSQyLnG+AkEmN/1f/3+7PqlHz LQtQ== X-Gm-Message-State: APt69E1Cbey5Gff7vAGfzPCevfp91daG1jaPe3jwc0r02R77UypSyrnS 3y/TOzYMDEwSih2kYLJgppU= X-Google-Smtp-Source: AAOMgpdBoq6+5FtqzCFhHl0g5i0C9BIzNWVuhy4PvMKiwyRPXeO65ofzTyjU3kSMeZ4ZYoBTnTzzWw== X-Received: by 2002:aa7:c0c9:: with SMTP id j9-v6mr10824645edp.135.1530228082448; Thu, 28 Jun 2018 16:21:22 -0700 (PDT) Received: from ltop.local ([2a02:a03f:40dc:3d00:7d3e:ff9f:2e8:f5a5]) by smtp.gmail.com with ESMTPSA id w17-v6sm3361284edr.30.2018.06.28.16.21.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 28 Jun 2018 16:21:21 -0700 (PDT) Date: Fri, 29 Jun 2018 01:21:20 +0200 From: Luc Van Oostenryck To: Catalin Marinas Subject: [PATCH] sparse: stricter warning for explicit cast to ulong Message-ID: <20180628232119.5jaavhewv5nb6ufb@ltop.local> References: <20180626172900.ufclp2pfrhwkxjco@armageddon.cambridge.arm.com> <0cef1643-a523-98e7-95e2-9ec595137642@arm.com> <20180627171757.amucnh5znld45cpc@armageddon.cambridge.arm.com> <20180628061758.j6bytsaj5jk4aocg@ltop.local> <20180628102741.vk6vphfinlj3lvhv@armageddon.cambridge.arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20180628102741.vk6vphfinlj3lvhv@armageddon.cambridge.arm.com> User-Agent: NeoMutt/20180622 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180628_162134_193828_643F885B X-CRM114-Status: GOOD ( 20.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Kate Stewart , "linux-doc@vger.kernel.org" , Will Deacon , Linux Memory Management List , "linux-kselftest@vger.kernel.org" , Chintan Pandya , Shuah Khan , Ingo Molnar , "linux-arch@vger.kernel.org" , Jacob Bramley , linux-sparse@vger.kernel.org, Dmitry Vyukov , Evgeniy Stepanov , Kees Cook , Ruben Ayrapetyan , Andrey Konovalov , Ramana Radhakrishnan , Al Viro , nd , Linux ARM , Kostya Serebryany , Greg Kroah-Hartman , LKML , Lee Smith , Andrew Morton , Robin Murphy , "Kirill A . Shutemov" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP sparse issues a warning when user pointers are casted to integer types except to unsigned longs which are explicitly allowed. However it may happen that we would like to also be warned on casts to unsigned long. Fix this by adding a new warning flag: -Wcast-from-as (to mirrors -Wcast-to-as) which extends -Waddress-space to all casts that remove an address space attribute (without using __force). References: https://lore.kernel.org/lkml/20180628102741.vk6vphfinlj3lvhv@armageddon.cambridge.arm.com/ Signed-off-by: Luc Van Oostenryck --- This patch is available in the Git repository at: git://github.com/lucvoo/sparse-dev.git warn-cast-from-as ---------------------------------------------------------------- Luc Van Oostenryck (1): stricter warning for explicit cast to ulong evaluate.c | 4 +-- lib.c | 2 ++ lib.h | 1 + sparse.1 | 9 ++++++ validation/Waddress-space-strict.c | 56 ++++++++++++++++++++++++++++++++++++++ 5 files changed, 70 insertions(+), 2 deletions(-) create mode 100644 validation/Waddress-space-strict.c diff --git a/evaluate.c b/evaluate.c index 194b97218..64e1067ce 100644 --- a/evaluate.c +++ b/evaluate.c @@ -2998,14 +2998,14 @@ static struct symbol *evaluate_cast(struct expression *expr) } } - if (ttype == &ulong_ctype) + if (ttype == &ulong_ctype && !Wcast_from_as) tas = -1; else if (tclass == TYPE_PTR) { examine_pointer_target(ttype); tas = ttype->ctype.as; } - if (stype == &ulong_ctype) + if (stype == &ulong_ctype && !Wcast_from_as) sas = -1; else if (sclass == TYPE_PTR) { examine_pointer_target(stype); diff --git a/lib.c b/lib.c index 308f8f699..0bb5232ab 100644 --- a/lib.c +++ b/lib.c @@ -248,6 +248,7 @@ static struct token *pre_buffer_end = NULL; int Waddress = 0; int Waddress_space = 1; int Wbitwise = 1; +int Wcast_from_as = 0; int Wcast_to_as = 0; int Wcast_truncate = 1; int Wconstexpr_not_const = 0; @@ -678,6 +679,7 @@ static const struct flag warnings[] = { { "address", &Waddress }, { "address-space", &Waddress_space }, { "bitwise", &Wbitwise }, + { "cast-from-as", &Wcast_from_as }, { "cast-to-as", &Wcast_to_as }, { "cast-truncate", &Wcast_truncate }, { "constexpr-not-const", &Wconstexpr_not_const}, diff --git a/lib.h b/lib.h index b0453bb6e..46e685421 100644 --- a/lib.h +++ b/lib.h @@ -137,6 +137,7 @@ extern int preprocess_only; extern int Waddress; extern int Waddress_space; extern int Wbitwise; +extern int Wcast_from_as; extern int Wcast_to_as; extern int Wcast_truncate; extern int Wconstexpr_not_const; diff --git a/sparse.1 b/sparse.1 index 806fb0cf0..62956f18b 100644 --- a/sparse.1 +++ b/sparse.1 @@ -77,6 +77,15 @@ Sparse issues these warnings by default. To turn them off, use \fB\-Wno\-bitwise\fR. . .TP +.B \-Wcast\-from\-as +Warn about which remove an address space to a pointer type. + +This is similar to \fB\-Waddress\-space\fR but will also warn +on casts to \fBunsigned long\fR. + +Sparse does not issues these warnings by default. +. +.TP .B \-Wcast\-to\-as Warn about casts which add an address space to a pointer type. diff --git a/validation/Waddress-space-strict.c b/validation/Waddress-space-strict.c new file mode 100644 index 000000000..ad23f74ae --- /dev/null +++ b/validation/Waddress-space-strict.c @@ -0,0 +1,56 @@ +#define __user __attribute__((address_space(1))) + +typedef unsigned long ulong; +typedef long long llong; +typedef struct s obj_t; + +static void expl(int i, ulong u, llong l, void *v, obj_t *o, obj_t __user *p) +{ + (obj_t*)(i); + (obj_t __user*)(i); + + (obj_t*)(u); + (obj_t __user*)(u); + + (obj_t*)(l); + (obj_t __user*)(l); + + (obj_t*)(v); + (obj_t __user*)(v); + + (int)(o); + (ulong)(o); + (llong)(o); + (void *)(o); + (obj_t*)(o); + (obj_t __user*)(o); + + (int)(p); // w + (ulong)(p); // w! + (llong)(p); // w + (void *)(p); // w + (obj_t*)(p); // w + (obj_t __user*)(p); // ok +} + +/* + * check-name: Waddress-space-strict + * check-command: sparse -Wcast-from-as -Wcast-to-as $file + * + * check-error-start +Waddress-space-strict.c:10:10: warning: cast adds address space to expression () +Waddress-space-strict.c:13:10: warning: cast adds address space to expression () +Waddress-space-strict.c:16:10: warning: cast adds address space to expression () +Waddress-space-strict.c:19:10: warning: cast adds address space to expression () +Waddress-space-strict.c:26:10: warning: cast adds address space to expression () +Waddress-space-strict.c:28:10: warning: cast removes address space of expression +Waddress-space-strict.c:29:10: warning: cast removes address space of expression +Waddress-space-strict.c:30:10: warning: cast removes address space of expression +Waddress-space-strict.c:31:10: warning: cast removes address space of expression +Waddress-space-strict.c:32:10: warning: cast removes address space of expression +Waddress-space-strict.c:9:10: warning: non size-preserving integer to pointer cast +Waddress-space-strict.c:10:10: warning: non size-preserving integer to pointer cast +Waddress-space-strict.c:21:10: warning: non size-preserving pointer to integer cast +Waddress-space-strict.c:28:10: warning: non size-preserving pointer to integer cast + * check-error-end + */